Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/901#issuecomment-144935255
@borisroman: Are the answers to your questions sufficient? Can you review
again please?
---
If your project is set up for it, you can reply to this email and
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/901
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/901#issuecomment-145036915
Thanks @borisroman, merged!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/901#issuecomment-145001598
@remibergsma Anwser is sufficient. I'll cleanup after 4.6 is released.
Regarding the PR: :+1: LGTM
I ran the test_vm_lifecycle which succeeded
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/901#issuecomment-144847280
@karuturi Thanks a lot, works great! LGTM
I registered a template with invalid headers, as per CLOUDSTACK-8808.
At first everything is normal:
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/901#discussion_r40881668
--- Diff: core/src/com/cloud/storage/template/QCOW2Processor.java ---
@@ -75,6 +76,16 @@ public FormatInfo process(String templatePath,
ImageFormat
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack/pull/901
CLOUDSTACK-8808: Successfully registered VHD template is downloaded again
due to missing virtualsize property in template.properties
We have multiple file processors to process different types
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/901#discussion_r40784661
--- Diff: core/src/com/cloud/storage/template/QCOW2Processor.java ---
@@ -75,6 +76,16 @@ public FormatInfo process(String templatePath,
ImageFormat
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/901#issuecomment-144439566
Thanks @karuturi for picking this up. Will have a look soon!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
