Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/828#issuecomment-175667189
@sureshanaparti LGTM, can you add a unit test for the new methods and
rebase against latest master
---
If your project is set up for it, you can reply to this emai
GitHub user sureshanaparti opened a pull request:
https://github.com/apache/cloudstack/pull/828
CLOUDSTACK-8854: Apple Mac OS/X VM get created without USB controller in
ESXi hypervisors
CLOUDSTACK-8854: Apple Mac OS/X VM get created without USB controller in
ESXi hypervisors
Github user sateesh-chodapuneedi commented on the pull request:
https://github.com/apache/cloudstack/pull/828#issuecomment-140357559
LGTM.
Can you please share more details on testing you have performed?
---
If your project is set up for it, you can reply to this email and have yo
Github user sureshanaparti commented on the pull request:
https://github.com/apache/cloudstack/pull/828#issuecomment-140369704
@sateesh-chodapuneedi These changes were successfully tested on Apple
hardware. When a VM is created with guest OS as Apple Mac OS, the USB
controller (EHCI+U
Github user sateesh-chodapuneedi commented on the pull request:
https://github.com/apache/cloudstack/pull/828#issuecomment-140370176
@sureshanaparti that sounds good.
Thanks for the patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/828#discussion_r39597202
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java ---
@@ -598,6 +601,19 @@ public static void
setBasicVmConfig(VirtualMachine
Github user sateesh-chodapuneedi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/828#discussion_r39598013
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java ---
@@ -598,6 +601,19 @@ public static void
setBasicVmConfig(Vi
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/828#discussion_r39624157
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java ---
@@ -598,6 +601,19 @@ public static void
setBasicVmConfig(VirtualM
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/828#discussion_r39824131
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java ---
@@ -598,6 +601,19 @@ public static void
setBasicVmConfig(VirtualMachine
Github user sureshanaparti commented on the pull request:
https://github.com/apache/cloudstack/pull/828#issuecomment-141356708
@bhaisaab @sateesh-chodapuneedi Update code as per the existing
conventions. Please check. Working on the unit test. Thanks.
---
If your project is set up f
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/828#issuecomment-216190037
tag:vmware-pickup
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/828#issuecomment-216190007
@sureshanaparti please rebase against latest master and push -f, update on
status of your PR
---
If your project is set up for it, you can reply to this email and ha
12 matches
Mail list logo
