[GitHub] cloudstack pull request: CLOUDSTACK-8985: Deleted volume's removed...

2015-10-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/968 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8985: Deleted volume's removed...

2015-10-28 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/968#issuecomment-151795514 LGTM, based on a set of tests that I run on this branch (which I rebased myself first): ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -

[GitHub] cloudstack pull request: CLOUDSTACK-8985: Deleted volume's removed...

2015-10-25 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/968#issuecomment-151027065 @mike-tutkowski currently only RM can merge, so I'll do that once the criteria are met. I need 2x LGTM and some tests run on this branch. So far, I see only a LG

[GitHub] cloudstack pull request: CLOUDSTACK-8985: Deleted volume's removed...

2015-10-25 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/968#issuecomment-151018044 Are we OK with this PR, everyone? If so, at this point in the release, is it the job of the RM to merge or should I do that? Thanks! --- If your project is s

[GitHub] cloudstack pull request: CLOUDSTACK-8985: Deleted volume's removed...

2015-10-25 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/968#issuecomment-150954369 @remibergsma I destroyed the vms in which I ran it already. --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] cloudstack pull request: CLOUDSTACK-8985: Deleted volume's removed...

2015-10-25 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/968#issuecomment-150947060 @DaanHoogland Could you please paste the nose command you run and the output. Thanks! --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: CLOUDSTACK-8985: Deleted volume's removed...

2015-10-24 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/968#issuecomment-150842979 I'm not at my computer right now, but I should be able to perform the rebase later this afternoon. On Saturday, October 24, 2015, Daan Hoogland

[GitHub] cloudstack pull request: CLOUDSTACK-8985: Deleted volume's removed...

2015-10-24 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/968#issuecomment-150840869 @remibergsma I ran the ssvm and vpc tests in the env from your company and we'll have to trust Mike for the solidfire specifics. He'll have to fix broken stuff

[GitHub] cloudstack pull request: CLOUDSTACK-8985: Deleted volume's removed...

2015-10-24 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/968#issuecomment-150839822 @mike-tutkowski Please rebase with current master and then force-push your commits. If you find another reviewer, I can run some tests next week to see i

[GitHub] cloudstack pull request: CLOUDSTACK-8985: Deleted volume's removed...

2015-10-24 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/968#issuecomment-150802473 @mike-tutkowski you'll have to force push i thinks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] cloudstack pull request: CLOUDSTACK-8985: Deleted volume's removed...

2015-10-23 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/968#issuecomment-150701469 @DaanHoogland How do I restart that build (the one that failed due to a timeout)? Can I do it from this UI or do I have to go elsewhere? Thanks! --- If your

[GitHub] cloudstack pull request: CLOUDSTACK-8985: Deleted volume's removed...

2015-10-23 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/968#issuecomment-150678276 Perhaps the management server serializes delete commands that it sends to a given plug-in. On Friday, October 23, 2015, Mike Tutkowski wro

[GitHub] cloudstack pull request: CLOUDSTACK-8985: Deleted volume's removed...

2015-10-23 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/968#issuecomment-150677439 I have actually not witnessed any issue with concurrent deletions. I've run tests on that and they passed just fine. On Friday, October 23, 2015, p

[GitHub] cloudstack pull request: CLOUDSTACK-8985: Deleted volume's removed...

2015-10-23 Thread pdube
Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/968#issuecomment-150675450 @mike-tutkowski Thanks. That makes more sense now. So concurrent deletions would still be a problem? --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-8985: Deleted volume's removed...

2015-10-23 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/968#issuecomment-150663033 @DaanHoogland At present, I don't have any way to run SolidFire integration tests inside of the Apache community. Perhaps I can leverage a virtual appliance a

[GitHub] cloudstack pull request: CLOUDSTACK-8985: Deleted volume's removed...

2015-10-23 Thread pdube
Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/968#issuecomment-150575383 The fix looks like it will work, but it seems like it is just a workaround. Shouldn't the column be updated correctly instead? Either in this method or the oth

[GitHub] cloudstack pull request: CLOUDSTACK-8985: Deleted volume's removed...

2015-10-22 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/968#issuecomment-150490749 checked with the regular tests of the SBP integration test suits and there all pass (except for the vp offering things) @mike-tutkowski Do you have any recommen

[GitHub] cloudstack pull request: CLOUDSTACK-8985: Deleted volume's removed...

2015-10-22 Thread mike-tutkowski
GitHub user mike-tutkowski opened a pull request: https://github.com/apache/cloudstack/pull/968 CLOUDSTACK-8985: Deleted volume's removed column not updated I found this issue when a SolidFire integration test yesterday wasn't able to delete primary storage because it claimed there