Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/970#issuecomment-151083526
Code look good to me, no rocket science involved.
I will test it with XenServer 6.5, but I might need help figuring out how
to get it covered.
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/970#issuecomment-151091001
Since a8212d9 changed names from "xen" to "xenserver", shouldn't the change
be to rename the files s3xen to s3xenserver and swiftxen to swiftxenserver in
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/970#issuecomment-151104185
Good point, @koushik-das.
@remibergsma: do you agree on that one as well?
---
If your project is set up for it, you can reply to this email and
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/970#issuecomment-151092704
Ping @runseb.
Is there a handle/userid for Tim Mackey?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/970#issuecomment-151081518
@remibergsma @borisroman - I'm starting tests now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user xenserverarmy commented on the pull request:
https://github.com/apache/cloudstack/pull/970#issuecomment-151157372
@koushik-das One of the goals of a8212d9ef458dd7ac64b021e6fa33fcf64b3cce0
was to ensure that we have clarity in which hypervisor we support since Xen !=
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/970#issuecomment-151182430
I will test if renaming the plugin works (and make sure there are no links
to its name).
---
If your project is set up for it, you can reply to this email and
Github user remibergsma closed the pull request at:
https://github.com/apache/cloudstack/pull/970
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/970#issuecomment-151206019
New PR #982
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/970#issuecomment-150662299
Based on code review, LGTM :+1:
I haven't spun up a cluster to run integration tests...
---
If your project is set up for it, you can reply to this
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/970#issuecomment-150663941
@borisroman Thanks, will ask @wilderrodrigues to run some integration tests.
---
If your project is set up for it, you can reply to this email and have your
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/970
CLOUDSTACK-8987 call s3xen/swiftxen plugins with their name
It's called `s3xen`, not `s3xenserver`. While investigating, I found the
same issue for `swiftxen`.
Regresion from
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/970#issuecomment-150526387
Verified this is also broken in `4.5` btw.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/970#issuecomment-150664161
@remibergsma @wilderrodrigues Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
14 matches
Mail list logo
