Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/1307#issuecomment-222167149
### ACS CI BVT Run
**Sumarry:**
Build Number 65
Hypervisor xenserver
NetworkType Advanced
Passed=71
Failed=2
Skipped=3
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1307#issuecomment-216220089
@kansal please rebase and push -f, thanks
Please reply to outstanding comments
---
If your project is set up for it, you can reply to this email and have
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/1307#issuecomment-202054442
### ACS CI BVT Run
**Sumarry:**
Build Number 135
Hypervisor xenserver
NetworkType Advanced
Passed=105
Failed=0
Skipped=4
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/1307#issuecomment-175963626
@bhaisaab I am still not very confident if we can remove sending stop
command to when VM is in the the poweroff state (on host) and stopped state (in
DB). But as
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1307#issuecomment-175689441
Ping?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1307#issuecomment-168964453
+0 code LGTM but the fact that this check is needed is a smell. It points
to a possible bug in the statemachine driving the handling of power reports.
---
If
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1307#issuecomment-169132663
Agree with @DaanHoogland the code doesn't seem bad and probably fixes the
issue. But something is wrong here indeed. Codewise it looks good.
---
If your project is
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/1307#issuecomment-168977391
@DaanHoogland With the current code, even if the VM is in poweroff(or power
report missing) state and stopped state in DB, and receives a stop command, it
gets this
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1307#issuecomment-168983922
@kansal I remember a discussion in a prior PR but not the number. The
scenario would be something like hypervisor has been disconnected or rebooted
and
GitHub user kansal opened a pull request:
https://github.com/apache/cloudstack/pull/1307
CLOUDSTACK-9208: Assertion Error in VM_POWER_STATE handler- Fixed
Root Cause: In the case of VM_POWER_STATE handler, if PowerOff or
PowerReportMissing state is encountered,
10 matches
Mail list logo
