[GitHub] cloudstack pull request: Cloudstack-8961: Changes related to the U...

2016-05-02 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1255#issuecomment-216211177 @kansal thanks, interesting fix. can you rebase against latest master We'll need some manual testing to verify this and evaluate if this is the right place to

Re: [GitHub] cloudstack pull request: Cloudstack-8961: Changes related to the U...

2016-04-23 Thread Marcus Jorge
Fx"dxxxffzxzsd Em 21 de abr de 2016 07:10, "jayapalu" escreveu: > Github user jayapalu commented on the pull request: > > https://github.com/apache/cloudstack/pull/1255#issuecomment-212842613 > > @kansal Can you please complete the localisation changes. > > > --- > If your project is set

[GitHub] cloudstack pull request: Cloudstack-8961: Changes related to the U...

2016-04-21 Thread jayapalu
Github user jayapalu commented on the pull request: https://github.com/apache/cloudstack/pull/1255#issuecomment-212842613 @kansal Can you please complete the localisation changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: Cloudstack-8961: Changes related to the U...

2016-04-21 Thread kansal
Github user kansal commented on the pull request: https://github.com/apache/cloudstack/pull/1255#issuecomment-212834905 @nitin-maharana Yes. Will update and rebase the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] cloudstack pull request: Cloudstack-8961: Changes related to the U...

2016-04-21 Thread nitin-maharana
Github user nitin-maharana commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1255#discussion_r60544689 --- Diff: ui/scripts/network.js --- @@ -6517,7 +6445,192 @@ } } } -

[GitHub] cloudstack pull request: Cloudstack-8961: Changes related to the U...

2016-04-21 Thread nitin-maharana
Github user nitin-maharana commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1255#discussion_r60544256 --- Diff: ui/scripts/network.js --- @@ -4508,99 +4524,11 @@ $('').addClass('psk').html(_l('me

[GitHub] cloudstack pull request: Cloudstack-8961: Changes related to the U...

2016-04-21 Thread nitin-maharana
Github user nitin-maharana commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1255#discussion_r60544347 --- Diff: ui/scripts/network.js --- @@ -6517,7 +6445,192 @@ } } } -

[GitHub] cloudstack pull request: Cloudstack-8961: Changes related to the U...

2015-12-16 Thread kansal
Github user kansal commented on the pull request: https://github.com/apache/cloudstack/pull/1255#issuecomment-165342311 cc @milamberspace @karuturi Have reopened this PR against the current master. This is in continuation with #941. ![screen shot 2015-12-17 at 11 02 13 am](https:

[GitHub] cloudstack pull request: Cloudstack-8961: Changes related to the U...

2015-12-16 Thread kansal
GitHub user kansal opened a pull request: https://github.com/apache/cloudstack/pull/1255 Cloudstack-8961: Changes related to the UI of VPN Users management. The current VPN uses are added in the VPN tab inside the public IP after the VPN is enabled. For each network(for which VPN is

[GitHub] cloudstack pull request: CLOUDSTACK-8961: Changes related to the U...

2015-12-16 Thread kansal
Github user kansal closed the pull request at: https://github.com/apache/cloudstack/pull/941 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8961: Changes related to the U...

2015-12-16 Thread kansal
Github user kansal commented on the pull request: https://github.com/apache/cloudstack/pull/941#issuecomment-165340109 Closing this PR, will create a new one against 4.6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: CLOUDSTACK-8961: Changes related to the U...

2015-11-02 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/941#issuecomment-152971271 @kansal Can you address the localization concerns? Also, if possible could you provide screenshots of the change? --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CLOUDSTACK-8961: Changes related to the U...

2015-10-29 Thread milamberspace
Github user milamberspace commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/941#discussion_r43433516 --- Diff: ui/scripts/network.js --- @@ -6504,7 +6432,123 @@ } } } -

[GitHub] cloudstack pull request: CLOUDSTACK-8961: Changes related to the U...

2015-10-29 Thread milamberspace
Github user milamberspace commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/941#discussion_r43433493 --- Diff: ui/scripts/network.js --- @@ -6504,7 +6432,123 @@ } } } -

[GitHub] cloudstack pull request: CLOUDSTACK-8961: Changes related to the U...

2015-10-29 Thread milamberspace
Github user milamberspace commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/941#discussion_r43433480 --- Diff: ui/scripts/network.js --- @@ -4495,99 +4511,11 @@ $('').addClass('psk').html(_l('mess

[GitHub] cloudstack pull request: CLOUDSTACK-8961: Changes related to the U...

2015-10-17 Thread kansal
GitHub user kansal opened a pull request: https://github.com/apache/cloudstack/pull/941 CLOUDSTACK-8961: Changes related to the UI of VPN Users management. The current VPN uses are added in the VPN tab inside the public IP after the VPN is enabled. For each network(for which VPN is