Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/1378#issuecomment-221844538
Making a new PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user ProjectMoon closed the pull request at:
https://github.com/apache/cloudstack/pull/1378
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1378#issuecomment-216221868
LGTM @ProjectMoon please send the PR for 4.7+; the merge workflow is from
4.7+
Please close this one and open another PR against 4.7+ thanks
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/1378#issuecomment-197705664
### ACS CI BVT Run
**Sumarry:**
Build Number 105
Hypervisor xenserver
NetworkType Advanced
Passed=104
Failed=14
Skipped=4
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/1378#issuecomment-181286402
Apparently cloud-utils has a test failure. Will run tests locally and see
what happens.
---
If your project is set up for it, you can reply to this email and
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/1378#issuecomment-181313425
Jenkins failed with a false positive again, similar to another issue I had
with a different pull request.
---
If your project is set up for it, you can reply
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/1378#issuecomment-181280984
License header is now in the file. Let's hope the tests succeed.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/1378#issuecomment-181300513
The tests all succeed locally. Looking at the error message, it appears to
be some one-off thing. Will try to force them to run again.
---
If your project is
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1378#issuecomment-181037780
Thanks, @ProjectMoon! Now you just need to add the license header (I
believe that's what caused jenkins to fail).
---
If your project is set up for it, you
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/1378#issuecomment-180308047
@cristofolini the unit test has been added.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/1378#issuecomment-179181050
I will try to add a unit test later today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1378#issuecomment-177565744
@ProjectMoon Even if you've managed to test this in an actual environment,
I think a small unit test just to assert that the correct values for the class
name
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/1378#issuecomment-176762035
The checks failed on unit tests which exist only on pull request #1360.
Which is ... interesting. Will try to retrigger build.
---
If your project is set up
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/1378#issuecomment-176787411
@DaanHoogland The build is now passing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/1378#issuecomment-176670512
Now that #1382 has been merged to 4.6, the checks should succeed.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1378#issuecomment-176147131
Yes, nothing to do with your code but it is genuine. You can add the
license to ActionEventUtilsTest to make the build pass. The license is there in
higher
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1378#issuecomment-176181871
have a look in target/rat.txt and see what those are. maybe some remanence
of your prior work.
---
If your project is set up for it, you can reply to this
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/1378#issuecomment-176159834
I added the license header.
Out of curiosity, I ran the `org.apache.rat:apache-rat-plugin:0.10:check`
locally on my PR branch and it reported 59
GitHub user ProjectMoon opened a pull request:
https://github.com/apache/cloudstack/pull/1378
Emit event UUIDs on template deletion
When a template is deleted, it emits a usage event over the event bus.
However, it does not emit the UUID or class name of the template over the event
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/1378#issuecomment-176144240
Says a license is missing, but this only touches one existing file.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/1378#issuecomment-176194553
I added the license check to ActionEventUtilsTest and of course now the
checks pass. But may it is a better idea to put the license in as a separate
PR? Not
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/1378#issuecomment-176204562
After some discussion on IRC, going to remove the addition of the license
header here and fix it in a separate PR.
---
If your project is set up for it, you
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/1378#issuecomment-176197509
It looks like it was some old Debian package build causing a bunch of
extraneous files to be placed into the rat report. Cleaned up those and the
report is now
23 matches
Mail list logo
