Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/761#issuecomment-137843740
Created issue for it: CLOUDSTACK-8811
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user remibergsma closed the pull request at:
https://github.com/apache/cloudstack/pull/761
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/761#issuecomment-136681350
@remibergsma
I merged the PR following the new merge style you and @miguelaferreira did.
I dunno why it's still not updated. Let's wait a bit more.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/761#issuecomment-136939562
Anyone github bug? why is @hubot here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/761#issuecomment-136286725
Changes LGTM for 4.4.
@miguelaferreira @remibergsma These can be fixed properly in a future
release. isVmAlive() can return some enum (like yes, no, unknown)
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/761#issuecomment-136302213
I didn't realise this was a hotfix for 4.4.
I wouldn't want this fix for master, but for a previous release that has a
critical bug, I can live with it.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/761#issuecomment-136318482
It has been partially fixed on 4.6, but still the code can be improved
since it might return null. Below an snippet of the 4.6 code:
@Override
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/761#issuecomment-136317069
Seems Travis is broken for 4.4 :-s
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/761#issuecomment-136302649
The rats build failed because some files (mostly travis related) do not
have license headers.
These files have not been changed in this PR.
```
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/761#issuecomment-136321979
Just discussed with @remibergsma and went over the old (4.4) code, the
change made by @rajesh-battala - which broke the behaviour - and how 4.6 now
is. The
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/761#issuecomment-136314787
Travis error seems not related. I can force push to see if it works this
time. At least the Apache pull-analysis build succeeded.
---
If your project is set up
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/761#issuecomment-136099464
@miguelaferreira Thanks. I guess returning `null` is done in many of the
Investigators right now, but would be great to improve it. If we at least could
make it
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/761#issuecomment-136095882
@remi: passing null to a method or returning null from a method is always a
bad choose. There are better ways to express I don't know (e.g. Using
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/761
Have HyperV behave in 4.4 and return null instead of false
Commit 6a4927f660f776bcbd12ae45f4e63ae2c2e96774 made the HyperV
investigator return false instead of null.
Returning
14 matches
Mail list logo
