Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/680
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/680#issuecomment-131050116
@borisroman Great, looks like we're ready to go. I'll wait for Travis to
turn green and then merge.
---
If your project is set up for it, you can reply to this
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/680#issuecomment-131036175
@wido @DaanHoogland Removed last comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/680#issuecomment-131033140
code LGTM, less comment is better in this case but I'll settle.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/680#discussion_r37060434
--- Diff: ui/scripts/cloudStack.js ---
@@ -143,8 +143,11 @@
if
(json.listcapabilitiesresponse.capability.userpublictempl
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/680#discussion_r37060382
--- Diff: server/src/com/cloud/server/ManagementServerImpl.java ---
@@ -3378,6 +3379,10 @@ private String signRequest(final String request,
final Str
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/680#issuecomment-131032218
@wido my comments we're on outdated code. I will have another look
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/680#issuecomment-131030262
Code looks good to me, but I see there are still some outstanding comments?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/680#issuecomment-130659980
@remibergsma Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/680#issuecomment-130656396
@borisroman Please squash the commits here as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/680#issuecomment-130321431
please comment on testing the stuff, for instance ref unit - or integration
tests that cover the code in the PR description/comment or, alternatively add
unit t
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/680#discussion_r36865220
--- Diff: ui/scripts/instances.js ---
@@ -2498,8 +2502,11 @@
} else if (jsonObj.state == 'Error') {
allowedActions.push(
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/680#discussion_r36865186
--- Diff: ui/scripts/instances.js ---
@@ -2425,11 +2425,15 @@
var allowedActions = [];
if (jsonObj.state == 'Destroyed
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/680#discussion_r36865162
--- Diff: ui/scripts/instances.js ---
@@ -618,11 +618,11 @@
createForm: {
title: 'label.
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/680#issuecomment-130232580
@wilderrodrigues @DaanHoogland @remibergsma Here are the interface changes
related to #593.
---
If your project is set up for it, you can reply to this email and
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/680
Interface changes related to CLOUDSTACK-8580
See issue CLOUDSTACK-8580 and individual commits.
You can merge this pull request into a Git repository by running:
$ git pull https://github
16 matches
Mail list logo
