Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1100
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1100#issuecomment-160389915
LGTM based on the tests below. Can't really judge the change itself.
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,re
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1100#issuecomment-160226913
@remibergsma I have rebase the PR and resolved the conflicts for
@alexandrelimassantana
---
If your project is set up for it, you can reply to this emai
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1100#issuecomment-160190122
@alexandrelimassantana Can you rebase please and resolve the conflict?
Thanks!
---
If your project is set up for it, you can reply to this email and have your
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1100#issuecomment-158874243
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user alexandrelimassantana commented on the pull request:
https://github.com/apache/cloudstack/pull/1100#issuecomment-158764180
Thanks for that look-up @rafaelweingartner. Yeah that class was very old,
it's use in the hierarchy, as of now, was just for forwading an interface
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1100#issuecomment-158688747
Sure ;)
He is one of my team mates of that project we talked about.
Today was one of the days that we meet and try to clean some code. We
normally
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1100#issuecomment-158688687
ah @rafaelweingartner you did the check for @alexandrelimassantana , ok ;)
---
If your project is set up for it, you can reply to this email and have your
repl
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1100#issuecomment-158688620
Hi @DaanHoogland,
That class was created 5 years ago by âManuel Amadorâ, at that time the
class had some logic. Then, someone called âDarren She
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1100#issuecomment-158684056
@alexandrelimassantana Did you check who created the
DefaultUserAuthenticator? Your change makes sense to me but I would like to
know why it was created before
GitHub user alexandrelimassantana opened a pull request:
https://github.com/apache/cloudstack/pull/1100
Removal of DefaultUserAuthenticator empty class.
The DefaultUserAuthenticator is an empty class, extending from the
AdapterBase and implementing the UserAuthenticator interface
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/852
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/852#issuecomment-147090501
LGTM, thanks for the cleanup :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/852#issuecomment-141721291
Nice work @alexandrelimassantana, the class âDefaultUserAuthenticatorâ
does not bring anything new to the hierarchy. Moreover, it has a comment âUse
GitHub user alexandrelimassantana opened a pull request:
https://github.com/apache/cloudstack/pull/852
Removal of DefaultUserAuthenticator empty class.
The DefaultUserAuthenticator is an empty class, extending from the
AdapterBase and implementing the UserAuthenticator interface.
15 matches
Mail list logo
