GitHub user rafaelweingartner opened a pull request:
https://github.com/apache/cloudstack/pull/1444
Worked around some possible runtime exceptions introduced in PR 780.
@Remi, @remibergsma I have created this PR to work out those possible
problems introduce by PR #780 that may happe
Github user eriweb commented on the pull request:
https://github.com/apache/cloudstack/pull/1444#issuecomment-198791923
Thanks for your PR @rafaelweingartner, for tracking purposes, would you
mind creating a jira ticket and including the ticket id in the PR title?
---
If your project
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1444#issuecomment-198797607
@eriweb sure I can.
I will just wait for @swill and @remibergsma feedback.
If we decide to revert #780, then I will close this PR; otherwise, we can
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1444#issuecomment-198881402
This PR has some nice improvements, so that's great @rafaelweingartner!
Still, I'm clueless why people merge without running a single integration
test.
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1444#issuecomment-198889972
@remibergsma I understand your point.
Anyways if we decide to revert that PR, I can get the changes it introduce
and apply here; then we can follow the
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1444#issuecomment-199500059
@rafaelweingartner, thank you for offering to merge in the changes from
#780. I have reverted that merge, if you can merge it here and we can run
integration tests a
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1444#issuecomment-199568119
@remibergsma, @swill I had cherry-picked the changes of PR #780 into this
PR and then I applied my changes to solve those problems that were reported
ther
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1444#discussion_r57194036
--- Diff:
plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java
---
@@ -484,6 +489,10 @@ public DomainBlockStat
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1444#discussion_r57202601
--- Diff:
plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java
---
@@ -484,6 +489,10 @@ public Dom
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1444#discussion_r57208531
--- Diff:
plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java
---
@@ -484,6 +489,10 @@ public DomainBlockStat
10 matches
Mail list logo
