[MERGE] CS-2163

2013-04-28 Thread Nitin Mehta
I would like to merge the feature which will add the ability in CS so that the user can have better control over first class objects in CS - The feature can be found in the branch cs-2163 and has been rebased with master. - Jira ticket: https://issues.apache.org/jira/browse/CLOUDSTACK-2163 - The

Re: [MERGE] CS-2163

2013-04-29 Thread Chip Childers
On Mon, Apr 29, 2013 at 04:01:27AM +, Nitin Mehta wrote: > I would like to merge the feature which will add the ability in CS so that > the user can have better control over first class objects in CS > > - The feature can be found in the branch cs-2163 and has been rebased with > master. > -

Re: [MERGE] CS-2163

2013-04-29 Thread Min Chen
Nitin, I have several questions after reading your FS: 1. The API to be modified should also include some list APIs to control which resources to be displayed to the end user based on your new flag, right? You didn't mention such APIs in your FS, so I am asking for clarification. 2. If ans

Re: [MERGE] CS-2163

2013-04-29 Thread Prasanna Santhanam
On Mon, Apr 29, 2013 at 04:01:27AM +, Nitin Mehta wrote: > I would like to merge the feature which will add the ability in CS so that > the user can have better control over first class objects in CS > > - The feature can be found in the branch cs-2163 and has been rebased with > master. > -

Re: [MERGE] CS-2163

2013-04-30 Thread Nitin Mehta
Prasanna - Thanks for your question. The reasons for not using createTags are as follows :- - tags functionality is for grouping resources than adding meta information and is allowed to all users. What I am proposing is for the admin to have better control over the first class objects in CS. This

Re: [MERGE] CS-2163

2013-04-30 Thread Prasanna Santhanam
On Tue, Apr 30, 2013 at 09:25:40AM +, Nitin Mehta wrote: > Prasanna - Thanks for your question. The reasons for not using createTags > are as follows :- > > - tags functionality is for grouping resources than adding meta > information and is allowed to all users. What I am proposing is for the

Re: [MERGE] CS-2163

2013-04-30 Thread Prasanna Santhanam
Also - tags supports many more resources in CloudStack already as compared to the resources you are adding for meta-information. All the more reason to enhance existing APIs? On Tue, Apr 30, 2013 at 08:21:39PM +0530, Prasanna Santhanam wrote: > On Tue, Apr 30, 2013 at 09:25:40AM +, Nitin Mehta

Re: [MERGE] CS-2163

2013-04-30 Thread Min Chen
+1 to Prasanna's argument. Tags provide more flexibility and extensibility than adding column to existing db schema. What happens if later on we want to add finer control to these resources not specific to end user? Adding another column? Also, I haven't seen your answer to my questions in this t

Re: [MERGE] CS-2163

2013-04-30 Thread Nitin Mehta
Min - Thanks for your questions. I have updated the FS with the list Apis. I also updated the FS with the DB view changes. This was already done while submitting the merge request.Thanks for pointing this out. Thanks, -Nitin On 29/04/13 11:07 PM, "Min Chen" wrote: >Nitin, > > I have sever

Re: [MERGE] CS-2163

2013-05-02 Thread Abhinandan Prateek
The tags are name-value pairs basically meant to label resources by a user. The purpose of the current API is to add useful meta information to resources so that they can be meaningfully controlled by external tools. The current implementation of meta info API may look similar to tags with possib

Re: [MERGE] CS-2163

2013-05-02 Thread Chip Childers
On Thu, May 02, 2013 at 12:40:45PM +0530, Abhinandan Prateek wrote: > > The tags are name-value pairs basically meant to label resources by a user. > The purpose of the current API is to add useful meta information to > resources so that they can be meaningfully controlled by external tools. > >

Re: [MERGE] CS-2163

2013-05-02 Thread Chiradeep Vittal
On 5/2/13 6:24 AM, "Chip Childers" wrote: >On Thu, May 02, 2013 at 12:40:45PM +0530, Abhinandan Prateek wrote: >> >> The tags are name-value pairs basically meant to label resources by a >>user. >> The purpose of the current API is to add useful meta information to >> resources so that they ca

Re: [MERGE] CS-2163

2013-05-02 Thread Chip Childers
On Thu, May 02, 2013 at 10:50:25AM -0700, Chiradeep Vittal wrote: > > > On 5/2/13 6:24 AM, "Chip Childers" wrote: > > >On Thu, May 02, 2013 at 12:40:45PM +0530, Abhinandan Prateek wrote: > >> > >> The tags are name-value pairs basically meant to label resources by a > >>user. > >> The purpose

Re: [MERGE] CS-2163

2013-05-02 Thread Murali Reddy
On 02/05/13 11:20 PM, "Chiradeep Vittal" wrote: > > >On 5/2/13 6:24 AM, "Chip Childers" wrote: > >>On Thu, May 02, 2013 at 12:40:45PM +0530, Abhinandan Prateek wrote: >>> >>> The tags are name-value pairs basically meant to label resources by a >>>user. >>> The purpose of the current API is to

Re: [MERGE] CS-2163

2013-05-03 Thread Chip Childers
On Fri, May 03, 2013 at 04:11:21AM +, Murali Reddy wrote: > On 02/05/13 11:20 PM, "Chiradeep Vittal" > wrote: > > > > > > >On 5/2/13 6:24 AM, "Chip Childers" wrote: > > > >>On Thu, May 02, 2013 at 12:40:45PM +0530, Abhinandan Prateek wrote: > >>> > >>> The tags are name-value pairs basicall

Re: [MERGE] CS-2163

2013-05-06 Thread Murali Reddy
On 03/05/13 7:47 PM, "Chip Childers" wrote: >On Fri, May 03, 2013 at 04:11:21AM +, Murali Reddy wrote: >> >> >> I would like to see this as, meta-data that has semantic meaning to >> CloudStack vs meta-data that's purely user meta-data that has no meaning >> to CloudStack and its plug-ins. '

Re: [MERGE] CS-2163

2013-05-06 Thread Prasanna Santhanam
On Mon, May 06, 2013 at 11:39:49AM +, Murali Reddy wrote: > On 03/05/13 7:47 PM, "Chip Childers" wrote: > > >On Fri, May 03, 2013 at 04:11:21AM +, Murali Reddy wrote: > >> > >> > >> I would like to see this as, meta-data that has semantic meaning to > >> CloudStack vs meta-data that's pu

Re: [MERGE] CS-2163

2013-05-06 Thread Prasanna Santhanam
On Mon, May 06, 2013 at 11:39:49AM +, Murali Reddy wrote: > On 03/05/13 7:47 PM, "Chip Childers" wrote: > > >On Fri, May 03, 2013 at 04:11:21AM +, Murali Reddy wrote: > >> > >> > >> I would like to see this as, meta-data that has semantic meaning to > >> CloudStack vs meta-data that's pu

Re: [MERGE] CS-2163

2013-05-06 Thread Murali Reddy
On 06/05/13 5:18 PM, "Prasanna Santhanam" wrote: >> >> Agree. There could be use cases for both services that are cloud >>provider >> managed (admin) vs self-service that need to access/store meta-data. We >> need to keep design to be flexible. Also current proposal to add new API >> for each of

Re: [MERGE] CS-2163

2013-05-06 Thread Abhinandan Prateek
On 06/05/13 5:20 PM, "Prasanna Santhanam" wrote: >On Mon, May 06, 2013 at 11:39:49AM +, Murali Reddy wrote: >> On 03/05/13 7:47 PM, "Chip Childers" wrote: >> >> >On Fri, May 03, 2013 at 04:11:21AM +, Murali Reddy wrote: >> >> >> >> >> >> I would like to see this as, meta-data that has

Re: [MERGE] CS-2163

2013-05-09 Thread Nitin Mehta
On 03/05/13 7:58 PM, "Chip Childers" wrote: >On Fri, May 03, 2013 at 04:11:21AM +, Murali Reddy wrote: >> On 02/05/13 11:20 PM, "Chiradeep Vittal" >> wrote: >> >> > >> > >> >On 5/2/13 6:24 AM, "Chip Childers" wrote: >> > >> >>On Thu, May 02, 2013 at 12:40:45PM +0530, Abhinandan Prateek w

Re: [MERGE] CS-2163

2013-05-09 Thread Nitin Mehta
Updated the FS [1] as per the discussion. So the plan is to introduce a generic api to add semantic meta data to the first class objects. AddResourceDetail - Add details to resource * resourceIds - List of resource ids * resourceType - Example - volume, nic etc. * details - Map of key/value pairs

Re: [MERGE] CS-2163

2013-05-11 Thread Chip Childers
On Thu, May 09, 2013 at 09:55:02AM +, Nitin Mehta wrote: > Updated the FS [1] as per the discussion. So the plan is to introduce a > generic api to > add semantic meta data to the first class objects. > > AddResourceDetail - Add details to resource > > * resourceIds - List of resource ids > *

Re: [MERGE] CS-2163

2013-05-12 Thread Nitin Mehta
Chip - The change is not significant but a subset of the work already done. Going this path makes the model of adding semantic metadata more flexible and can be extended to have a more flexible ACL in future as well. I am already done with the changes and have added the unit and integration tests a

Re: [MERGE] CS-2163

2013-05-13 Thread Nitin Mehta
This has been merged into master now. On 12/05/13 2:40 PM, "Nitin Mehta" wrote: >Chip - The change is not significant but a subset of the work already >done. Going this path makes the model of adding semantic metadata more >flexible and can be extended to have a more flexible ACL in future as >w