Add reviewer to Review requests (was: ReviewBoard)

2014-02-02 Thread Daan Hoogland
LS, I would like to see contributers add reviewers to their submissions. I noticed quite soe old review requests that don't have anyone's attention. There are component 'owners' for everything and I have easy speach as I am not listed as contact for any component but I wouldn't mind being

Re: Add reviewer to Review requests (was: ReviewBoard)

2014-02-02 Thread Daan Hoogland
It should be on the wiki : https://cwiki.apache.org/confluence/display/CLOUDSTACK/Current+Maintainers+Per+Component On Sun, Feb 2, 2014 at 4:19 PM, Laszlo Hornyak laszlo.horn...@gmail.com wrote: Hi Daan, I would start doing so right now, but I have never heard of a list of component

Re: Add reviewer to Review requests (was: ReviewBoard)

2014-02-02 Thread Daan Hoogland
but I would give preference to whoever you discussed a thingy with. On Sun, Feb 2, 2014 at 4:27 PM, Daan Hoogland daan.hoogl...@gmail.com wrote: It should be on the wiki : https://cwiki.apache.org/confluence/display/CLOUDSTACK/Current+Maintainers+Per+Component On Sun, Feb 2, 2014 at 4:19 PM,

Re: Add reviewer to Review requests (was: ReviewBoard)

2014-02-02 Thread Prasanna Santhanam
the best way is to find the person who changed the file you changed most and include them as reviewer. `git blame` FTW. On Sun, Feb 02, 2014 at 04:29:39PM +0100, Daan Hoogland wrote: but I would give preference to whoever you discussed a thingy with. On Sun, Feb 2, 2014 at 4:27 PM, Daan

Re: Add reviewer to Review requests (was: ReviewBoard)

2014-02-02 Thread Laszlo Hornyak
Bookmarked, thank you! This developer guide I worked with so far is seriously misleading. On Sun, Feb 2, 2014 at 4:27 PM, Daan Hoogland daan.hoogl...@gmail.comwrote: It should be on the wiki : https://cwiki.apache.org/confluence/display/CLOUDSTACK/Current+Maintainers+Per+Component On Sun,

Re: Add reviewer to Review requests (was: ReviewBoard)

2014-02-02 Thread Daan Hoogland
Good advice Prasanna, better then the maintainers list!! On Sun, Feb 2, 2014 at 5:19 PM, Laszlo Hornyak laszlo.horn...@gmail.com wrote: Bookmarked, thank you! This developer guide I worked with so far is seriously misleading. On Sun, Feb 2, 2014 at 4:27 PM, Daan Hoogland