Re: Clean up of unused constants

2017-09-28 Thread Boris Stoyanov
+1 of course, please let us know when you submit the PR and we’ll run some tests on it. Thanks, Boris Stoyanov boris.stoya...@shapeblue.com  www.shapeblue.com 53 Chandos Place, Covent Garden, London WC2N 4HSUK @shapeblue > On Sep 26, 2017, at 6:48 PM, Nitin Kumar Maharana >

Re: Clean up of unused constants

2017-09-26 Thread Nitin Kumar Maharana
+1 for removal of unused ones but prior to remove, Can you please check once what Rafael suggested. "using the value without referencing the constant”. Thanks, Nitin On 26-Sep-2017, at 7:25 PM, Rafael Weingärtner > wrote: IMO, if

Re: Clean up of unused constants

2017-09-26 Thread Nicolas Vazquez
+1 too. Thanks Sigert From: Gabriel Beims Bräscher <gabrasc...@gmail.com> Sent: Tuesday, September 26, 2017 11:17:19 AM To: dev@cloudstack.apache.org Subject: Re: Clean up of unused constants +1 on removing unused code. 2017-09-26 11:16 GMT-03:00 Marc-

Re: Clean up of unused constants

2017-09-26 Thread Gabriel Beims Bräscher
+1 on removing unused code. 2017-09-26 11:16 GMT-03:00 Marc-Aurèle Brothier : > +1 to sort them too > > On Tue, Sep 26, 2017 at 4:13 PM, Daan Hoogland < > daan.hoogl...@shapeblue.com> > wrote: > > > +1 Sigert, be my guest. We will run integration tests on your changes > >

Re: Clean up of unused constants

2017-09-26 Thread Marc-Aurèle Brothier
+1 to sort them too On Tue, Sep 26, 2017 at 4:13 PM, Daan Hoogland wrote: > +1 Sigert, be my guest. We will run integration tests on your changes > anyway, so low risk ;) > > On 2017/09/26 15:55, "Rafael Weingärtner" > wrote: > > IMO,

Re: Clean up of unused constants

2017-09-26 Thread Daan Hoogland
+1 Sigert, be my guest. We will run integration tests on your changes anyway, so low risk ;) On 2017/09/26 15:55, "Rafael Weingärtner" wrote: IMO, if something is not used or if something does not work, it has to be removed or fixed. I am +1 for the

Re: Clean up of unused constants

2017-09-26 Thread Rafael Weingärtner
IMO, if something is not used or if something does not work, it has to be removed or fixed. I am +1 for the removal of unused constants. Did you check if the value of these unused constants were being used somewhere? I mean, using the value without referencing the constant. On 9/26/2017

Clean up of unused constants

2017-09-26 Thread Sigert GOEMINNE
Hi all, Am I allowed to remove all unused constants in ApiConstants.java? Kind regards, *Sigert Goeminne* Software Development Engineer