Re: No more direct commits to master please!

On 09/12/2015 02:29 PM, Miguel Ferreira wrote: > Hi Wido, > > I’ve been investigating what could have gone wrong with commit > "CLOUDSTACK-8799 fixed for vpc networks.” > (b66dcda49f370e6fc91ebff889a694f17826ca44). > This commit was directly pushed to master, that is, it was not merged as

Re: No more direct commits to master please!

Hi Wido, I’ve been investigating what could have gone wrong with commit "CLOUDSTACK-8799 fixed for vpc networks.” (b66dcda49f370e6fc91ebff889a694f17826ca44). This commit was directly pushed to master, that is, it was not merged as part of a PR. PR 784 contais the same commit (with different

No more direct commits to master please!

Hi all, What happened to master? I see a lot of direct commits. I thought we agreed to make a PR, then _merge_ it to master with the script in ./tools/git/git-pr. We’re getting ready for a 4.6 RC and this makes stuff extra hard to track. Most direct commits seem to come from PRs, but I don’t

Re: No more direct commits to master please!

On 11-09-15 16:26, Remi Bergsma wrote: > Hi all, > > What happened to master? I see a lot of direct commits. I thought we agreed > to make a PR, then _merge_ it to master with the script in ./tools/git/git-pr. > Errr, I used that script? This is what my Bash history shows me:

Re: No more direct commits to master please!

Hi Wido, In order to figure out what went wrong, could you please point me to the merge commit (the one saying “Merge pull request …”) for commit b66dcda49f370e6fc91ebff889a694f17826ca44 ? Cheers, \ Miguel Ferreira mferre...@schubergphilis.com On 11