Re: Review Request 13771: CLOUDSTACK-4346 replace URI getHost() and create(String) calls

Sheng, Dave, Chiradeep and Hugo, Can you please review this? In my experience the time that this patch will expire is rather short, I have been resolving conflicts on this a lot. If now, given the 4.2 release is inconvenient, I would like to set a window for submitting this in which I will rebase

Re: Review Request 13771: CLOUDSTACK-4346 replace URI getHost() and create(String) calls

Hi Daan, I started to take a look - the diff is ~10k lines long, most of which appears to be whitespace changes. Are the whitespace changes important? Without them, the patch might be a lot easier to review. Thanks, Dave. On Sun, Aug 25, 2013 at 7:37 PM, Daan Hoogland wrote: > Sheng, Dave,

Re: Review Request 13771: CLOUDSTACK-4346 replace URI getHost() and create(String) calls

You are right, I incorporated Alex' auto format for eclipse. Sorry for that. Being sick at home today, I will try to submit an update without it tomorrow. regards, On Mon, Aug 26, 2013 at 6:04 AM, Dave Cahill wrote: > Hi Daan, > > I started to take a look - the diff is ~10k lines long, most o

Re: Review Request 13771: CLOUDSTACK-4346 replace URI getHost() and create(String) calls

Get well soon! On Mon, Aug 26, 2013 at 3:48 PM, Daan Hoogland wrote: > You are right, I incorporated Alex' auto format for eclipse. Sorry for > that. Being sick at home today, I will try to submit an update without it > tomorrow. > > regards, > > > > On Mon, Aug 26, 2013 at 6:04 AM, Dave Cahill

Re: Review Request 13771: CLOUDSTACK-4346 replace URI getHost() and create(String) calls

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13771/ --- (Updated Aug. 27, 2013, 11:36 a.m.) Review request for cloudstack, Chiradeep Vi

RE: Review Request 13771: CLOUDSTACK-4346 replace URI getHost() and create(String) calls

; Subject: Re: Review Request 13771: CLOUDSTACK-4346 replace URI getHost() > and create(String) calls > > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 13771: CLOUDSTACK-4346 replace URI getHost() and create(String) calls

Donal, These were tested creating and deleting various types of networks with clients. to be precise: a standard network a bridged network a nicira based network a standard vpc with two tiert networks. kind regards, On Tue, Aug 27, 2013 at 3:27 PM, Donal Lafferty wrote: > How were the changes

Re: Review Request 13771: CLOUDSTACK-4346 replace URI getHost() and create(String) calls

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13771/#review25650 --- plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/Bridg

Re: Review Request 13771: CLOUDSTACK-4346 replace URI getHost() and create(String) calls

> On Aug. 28, 2013, 2:05 a.m., Dave Cahill wrote: > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java, > > line 100 > > > > > > Not an issue, just to jog my memory - we're using stat

Re: Review Request 13771: CLOUDSTACK-4346 replace URI getHost() and create(String) calls

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13771/ --- (Updated Aug. 28, 2013, 2:37 p.m.) Review request for cloudstack, Chiradeep Vit

Re: Review Request 13771: CLOUDSTACK-4346 replace URI getHost() and create(String) calls

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13771/#review25724 --- Ship it! LGTM. - Dave Cahill On Aug. 28, 2013, 2:37 p.m., daan H

Re: Review Request 13771: CLOUDSTACK-4346 replace URI getHost() and create(String) calls

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13771/ --- (Updated Aug. 31, 2013, 7:57 p.m.) Review request for cloudstack, Chiradeep Vit

Re: Review Request 13771: CLOUDSTACK-4346 replace URI getHost() and create(String) calls

Wido, I just added you for your kvm interesse. Do you mind having a look before I commit this? regards, Daan On Sat, Aug 31, 2013 at 9:57 PM, daan Hoogland wrote: >This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13771/ > Review request for clouds

Re: Review Request 13771: CLOUDSTACK-4346 replace URI getHost() and create(String) calls

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13771/#review25816 --- Commit d9c06e538be96c347acc9055c267efda0b7bb559 in branch refs/heads

Re: Review Request 13771: CLOUDSTACK-4346 replace URI getHost() and create(String) calls

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13771/#review26002 --- Commit 25c8cee01a450ee924fe108cafe54b046485ab2b in branch refs/heads