Re: Review Request 15021: Fixed Bug: 4899 : Added Configuration Support to Marvin.

2013-11-08 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15021/#review28512 --- 4.2: e7b6ee10eda85a90c594c9de5d36cc062e069576 - Girish Shilamkar

Re: Review Request 15021: Fixed Bug: 4899 : Added Configuration Support to Marvin.

2013-10-31 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15021/#review27887 --- Ship it! 0b617a1 - Prasanna Santhanam On Oct. 31, 2013, 11:57 a.

Re: Review Request 15021: Fixed Bug: 4899 : Added Configuration Support to Marvin.

2013-10-31 Thread Santhosh Edukulla
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15021/ --- (Updated Oct. 31, 2013, 11:57 a.m.) Review request for cloudstack, Girish Shila

Re: Review Request 15021: Fixed Bug: 4899 : Added Configuration Support to Marvin.

2013-10-31 Thread Santhosh Edukulla
> On Oct. 30, 2013, 10:22 a.m., Santhosh Edukulla wrote: > > tools/marvin/marvin/configGenerator.py, line 337 > > > > > > Nopes, its right, user by default no need to mention any path while > > creating the object ins

Re: Review Request 15021: Fixed Bug: 4899 : Added Configuration Support to Marvin.

2013-10-30 Thread Prasanna Santhanam
> From: Prasanna Santhanam [mailto:t...@apache.org] > Sent: Wednesday, October 30, 2013 3:42 PM > To: Santhosh Edukulla > Cc: Prasanna Santhanam; cloudstack > Subject: Re: Review Request 15021: Fixed Bug: 4899 : Added Configuration > Support to Marvin. > > I've

Re: Review Request 15021: Fixed Bug: 4899 : Added Configuration Support to Marvin.

2013-10-30 Thread Prasanna Santhanam
> On Oct. 30, 2013, 10:22 a.m., Santhosh Edukulla wrote: > > tools/marvin/marvin/configGenerator.py, line 303 > > > > > > The reason is simple. We already have a module configGenerator and is > > used as configuration

Re: Review Request 15021: Fixed Bug: 4899 : Added Configuration Support to Marvin.

2013-10-30 Thread Santhosh Edukulla
> On Oct. 30, 2013, 10:22 a.m., Santhosh Edukulla wrote: > > tools/marvin/marvin/cloudstackTestClient.py, line 22 > > > > > > It came from merge, i didnt used them in modules required. This i will change to remove unus

Re: Review Request 15021: Fixed Bug: 4899 : Added Configuration Support to Marvin.

2013-10-30 Thread Santhosh Edukulla
> On Oct. 30, 2013, 10:12 a.m., Prasanna Santhanam wrote: > > tools/marvin/marvin/configGenerator.py, line 338 > > > > > > Can we have this driven by a cmd line switch to nose? Yes,the facility is now added, the curre

RE: Review Request 15021: Fixed Bug: 4899 : Added Configuration Support to Marvin.

2013-10-30 Thread Santhosh Edukulla
: Prasanna Santhanam; cloudstack Subject: Re: Review Request 15021: Fixed Bug: 4899 : Added Configuration Support to Marvin. I've given some inline comments in the patch. The ConfigManager looks too simple perhaps because it's a WIP? At least the goals as you've written in your doc

Re: Review Request 15021: Fixed Bug: 4899 : Added Configuration Support to Marvin.

2013-10-30 Thread Santhosh Edukulla
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15021/#review27765 --- tools/marvin/marvin/cloudstackTestClient.py

Re: Review Request 15021: Fixed Bug: 4899 : Added Configuration Support to Marvin.

2013-10-30 Thread Prasanna Santhanam
I've given some inline comments in the patch. The ConfigManager looks too simple perhaps because it's a WIP? At least the goals as you've written in your docstring seem to talk about more than what's provided in the module. On Tue, Oct 29, 2013 at 06:00:14PM -, Santhosh Edukulla wrote: > -

Re: Review Request 15021: Fixed Bug: 4899 : Added Configuration Support to Marvin.

2013-10-30 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15021/ --- (Updated Oct. 30, 2013, 10:12 a.m.) Review request for cloudstack, Girish Shila

Re: Review Request 15021: Fixed Bug: 4899 : Added Configuration Support to Marvin.

2013-10-30 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15021/#review27764 --- tools/marvin/marvin/cloudstackTestClient.py

Re: Review Request 15021: Fixed Bug: 4899 : Added Configuration Support to Marvin.

2013-10-29 Thread Santhosh Edukulla
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15021/ --- (Updated Oct. 29, 2013, 6 p.m.) Review request for cloudstack and Prasanna Sant