Re: Review Request 13680: CLOUDSTACK-3927, CLOUDSTACK-3928 Fix to add/remove NS devices in setupClass/tearDownClass

2013-08-19 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13680/ --- (Updated Aug. 20, 2013, 6:18 a.m.) Review request for cloudstack, venkata swamy

Re: Review Request 13680: CLOUDSTACK-3927, CLOUDSTACK-3928 Fix to add/remove NS devices in setupClass/tearDownClass

2013-08-19 Thread venkata swamy babu budumuru
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13680/#review25340 --- test/integration/component/test_netscaler_lb.py

Re: Review Request 13680: CLOUDSTACK-3927, CLOUDSTACK-3928 Fix to add/remove NS devices in setupClass/tearDownClass

2013-08-20 Thread Sowmya Krishnan
> On Aug. 20, 2013, 6:30 a.m., venkata swamy babu budumuru wrote: > > test/integration/component/test_netscaler_lb.py, line 166 > > > > > > Since you have multiple test suites trying to add the same netscaler > > dev

Re: Review Request 13680: CLOUDSTACK-3927, CLOUDSTACK-3928 Fix to add/remove NS devices in setupClass/tearDownClass

2013-08-20 Thread venkata swamy babu budumuru
> On Aug. 20, 2013, 6:30 a.m., venkata swamy babu budumuru wrote: > > tools/marvin/marvin/integration/lib/common.py, line 62 > > > > > > IMO, we don't have to go for an additional library call for > > add_netscaler ra

Re: Review Request 13680: CLOUDSTACK-3927, CLOUDSTACK-3928 Fix to add/remove NS devices in setupClass/tearDownClass

2013-08-21 Thread Sowmya Krishnan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13680/ --- (Updated Aug. 21, 2013, 10:47 a.m.) Review request for cloudstack, venkata swam

Re: Review Request 13680: CLOUDSTACK-3927, CLOUDSTACK-3928 Fix to add/remove NS devices in setupClass/tearDownClass

2013-08-21 Thread Rayees Namathponnan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13680/#review25378 --- There are hard coded IPs for netscaler devices; its very hard to man

RE: Review Request 13680: CLOUDSTACK-3927, CLOUDSTACK-3928 Fix to add/remove NS devices in setupClass/tearDownClass

2013-08-21 Thread Sowmya Krishnan
nkata SwamyBabu Budumuru > Cc: Rayees Namathponnan; Sowmya Krishnan; cloudstack > Subject: Re: Review Request 13680: CLOUDSTACK-3927, CLOUDSTACK-3928 Fix > to add/remove NS devices in setupClass/tearDownClass > > > --- >

Re: Review Request 13680: CLOUDSTACK-3927, CLOUDSTACK-3928 Fix to add/remove NS devices in setupClass/tearDownClass

2013-08-21 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13680/#review25398 --- Commit 1c31ee22d40d77c10593d87b8237cd0489d192cc in branch refs/head

Re: Review Request 13680: CLOUDSTACK-3927, CLOUDSTACK-3928 Fix to add/remove NS devices in setupClass/tearDownClass

2013-08-21 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13680/#review25397 --- Commit 1c31ee22d40d77c10593d87b8237cd0489d192cc in branch refs/head

Re: Review Request 13680: CLOUDSTACK-3927, CLOUDSTACK-3928 Fix to add/remove NS devices in setupClass/tearDownClass

2013-08-21 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13680/#review25399 --- Commit e4b5d4d62e0e3c90407f426f3de1bd300b9c0359 in branch refs/heads

Re: Review Request 13680: CLOUDSTACK-3927, CLOUDSTACK-3928 Fix to add/remove NS devices in setupClass/tearDownClass

2013-08-21 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13680/#review25400 --- Commit e4b5d4d62e0e3c90407f426f3de1bd300b9c0359 in branch refs/heads

Re: Review Request 13680: CLOUDSTACK-3927, CLOUDSTACK-3928 Fix to add/remove NS devices in setupClass/tearDownClass

2013-08-21 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13680/#review25403 --- Ship it! Ship It! - Prasanna Santhanam On Aug. 21, 2013, 10:47 a