Re: Review Request 12623: CLOUDSTACK-2328: Linux native VXLAN support on KVM hypervisor

2013-08-24 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12623/#review25501 --- Commit 914e7c4542cf59bdf0e53d21fee8a2c36024cadb in branch

Re: Review Request 12623: CLOUDSTACK-2328: Linux native VXLAN support on KVM hypervisor

2013-08-24 Thread Marcus Sorensen
What's going on here? Was there a problem with the patch? On Aug 24, 2013 1:18 AM, ASF Subversion and Git Services asf...@urd.zones.apache.org wrote: --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 12623: CLOUDSTACK-2328: Linux native VXLAN support on KVM hypervisor

2013-08-23 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12623/#review25492 --- Commit 34ae32e0c24777f9ac9cf265447688a3e21680c7 in branch

Re: Review Request 12623: CLOUDSTACK-2328: Linux native VXLAN support on KVM hypervisor

2013-08-12 Thread Hugo Trippaers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12623/#review24992 --- Ship it! I'm also OK with this patch. Documentation is pending,

Re: Review Request 12623: CLOUDSTACK-2328: Linux native VXLAN support on KVM hypervisor

2013-08-12 Thread Chiradeep Vittal
On Aug. 12, 2013, 11:38 a.m., Hugo Trippaers wrote: I'm also OK with this patch. Documentation is pending, but i'm fine with committing this to master. It needs a rebase to the latest state of master, but after that we should commit this. OK Chiradeep? OK. - Chiradeep

Re: Review Request 12623: CLOUDSTACK-2328: Linux native VXLAN support on KVM hypervisor

2013-07-25 Thread Toshiaki Hatano
On July 19, 2013, 4:56 p.m., Chiradeep Vittal wrote: scripts/vm/network/vnet/modifyvxlan.sh, line 28 https://reviews.apache.org/r/12623/diff/2/?file=323001#file323001line28 I think there is a need to prevent the guest vm from spoofing the multicast? Toshiaki Hatano wrote:

Re: Review Request 12623: CLOUDSTACK-2328: Linux native VXLAN support on KVM hypervisor

2013-07-23 Thread Toshiaki Hatano
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12623/ --- (Updated July 23, 2013, 6:45 a.m.) Review request for cloudstack, Alena

Re: Review Request 12623: CLOUDSTACK-2328: Linux native VXLAN support on KVM hypervisor

2013-07-23 Thread Chiradeep Vittal
On July 19, 2013, 4:56 p.m., Chiradeep Vittal wrote: scripts/vm/network/vnet/modifyvxlan.sh, line 28 https://reviews.apache.org/r/12623/diff/2/?file=323001#file323001line28 I think there is a need to prevent the guest vm from spoofing the multicast? Toshiaki Hatano wrote:

Re: Review Request 12623: CLOUDSTACK-2328: Linux native VXLAN support on KVM hypervisor

2013-07-19 Thread Chiradeep Vittal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12623/#review23523 --- scripts/vm/network/vnet/modifyvxlan.sh

Re: Review Request 12623: CLOUDSTACK-2328: Linux native VXLAN support on KVM hypervisor

2013-07-17 Thread Chiradeep Vittal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12623/#review23257 ---

Re: Review Request 12623: CLOUDSTACK-2328: Linux native VXLAN support on KVM hypervisor

2013-07-17 Thread Toshiaki Hatano
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12623/ --- (Updated July 17, 2013, 11:54 p.m.) Review request for cloudstack, Alena

Re: Review Request 12623: CLOUDSTACK-2328: Linux native VXLAN support on KVM hypervisor

2013-07-17 Thread Toshiaki Hatano
On July 17, 2013, 8:07 a.m., Chiradeep Vittal wrote: Hi Chiradeep, Thanks for the review! I've revised patch. On July 17, 2013, 8:07 a.m., Chiradeep Vittal wrote: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java, line 229

Review Request 12623: CLOUDSTACK-2328: Linux native VXLAN support on KVM hypervisor

2013-07-16 Thread Toshiaki Hatano
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12623/ --- Review request for cloudstack, Alena Prokharchyk, Chiradeep Vittal, Murali