Re: Review Request 12968: CLOUDSTACK-3686: Registering a template does not generate a usage event.

2013-07-30 Thread Saksham Srivastava
On July 28, 2013, 3:59 a.m., Min Chen wrote: server/src/com/cloud/template/HypervisorTemplateAdapter.java, line 249 https://reviews.apache.org/r/12968/diff/2/?file=329846#file329846line249 This is not right. For cross-zone template, in

Re: Review Request 12968: CLOUDSTACK-3686: Registering a template does not generate a usage event.

2013-07-30 Thread Min Chen
On July 28, 2013, 3:59 a.m., Min Chen wrote: server/src/com/cloud/template/HypervisorTemplateAdapter.java, line 249 https://reviews.apache.org/r/12968/diff/2/?file=329846#file329846line249 This is not right. For cross-zone template, in

Re: Review Request 12968: CLOUDSTACK-3686: Registering a template does not generate a usage event.

2013-07-30 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12968/#review24305 --- Commit 20831d00fb56d0553860bcb5efe47ce45bd1e74c in branch

Re: Review Request 12968: CLOUDSTACK-3686: Registering a template does not generate a usage event.

2013-07-30 Thread Min Chen
On July 28, 2013, 3:59 a.m., Min Chen wrote: server/src/com/cloud/template/HypervisorTemplateAdapter.java, line 249 https://reviews.apache.org/r/12968/diff/2/?file=329846#file329846line249 This is not right. For cross-zone template, in

Re: Review Request 12968: CLOUDSTACK-3686: Registering a template does not generate a usage event.

2013-07-30 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12968/#review24307 --- Commit c2192808aa5f7a391a79fb6c84592819c032fa45 in branch

Re: Review Request 12968: CLOUDSTACK-3686: Registering a template does not generate a usage event.

2013-07-30 Thread Saksham Srivastava
On July 28, 2013, 3:59 a.m., Min Chen wrote: server/src/com/cloud/template/HypervisorTemplateAdapter.java, line 249 https://reviews.apache.org/r/12968/diff/2/?file=329846#file329846line249 This is not right. For cross-zone template, in

Re: Review Request 12968: CLOUDSTACK-3686: Registering a template does not generate a usage event.

2013-07-27 Thread Saksham Srivastava
On July 26, 2013, 5:38 p.m., Min Chen wrote: server/src/com/cloud/template/HypervisorTemplateAdapter.java, line 230 https://reviews.apache.org/r/12968/diff/1/?file=328266#file328266line230 I don't understand why you need to do a bunch of search here. This method is invoked when a

Re: Review Request 12968: CLOUDSTACK-3686: Registering a template does not generate a usage event.

2013-07-27 Thread Min Chen
On July 26, 2013, 5:38 p.m., Min Chen wrote: server/src/com/cloud/template/HypervisorTemplateAdapter.java, line 230 https://reviews.apache.org/r/12968/diff/1/?file=328266#file328266line230 I don't understand why you need to do a bunch of search here. This method is invoked when a

Re: Review Request 12968: CLOUDSTACK-3686: Registering a template does not generate a usage event.

2013-07-27 Thread Saksham Srivastava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12968/#review24036 --- server/src/com/cloud/template/HypervisorTemplateAdapter.java

Re: Review Request 12968: CLOUDSTACK-3686: Registering a template does not generate a usage event.

2013-07-27 Thread Saksham Srivastava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12968/ --- (Updated July 27, 2013, 6:58 p.m.) Review request for cloudstack and Min Chen.

Re: Review Request 12968: CLOUDSTACK-3686: Registering a template does not generate a usage event.

2013-07-27 Thread Min Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12968/#review24049 --- server/src/com/cloud/template/HypervisorTemplateAdapter.java

Review Request 12968: CLOUDSTACK-3686: Registering a template does not generate a usage event.

2013-07-26 Thread Saksham Srivastava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12968/ --- Review request for cloudstack and Min Chen. Bugs: 3686 Repository:

Re: Review Request 12968: CLOUDSTACK-3686: Registering a template does not generate a usage event.

2013-07-26 Thread Jenkins Cloudstack.org
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12968/#review23948 --- Review 12968 PASSED the build test The url of build

Re: Review Request 12968: CLOUDSTACK-3686: Registering a template does not generate a usage event.

2013-07-26 Thread Min Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12968/#review23955 --- server/src/com/cloud/template/HypervisorTemplateAdapter.java