---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14124/
---
Review request for cloudstack and Sateesh Chodapuneedi.
Bugs: CLOUDSTACK-4622
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14124/
---
(Updated March 12, 2014, 2:23 p.m.)
Review request for cloudstack, Jayapal Redd
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14124/
---
(Updated March 12, 2014, 2:25 p.m.)
Review request for cloudstack, Jayapal Redd
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14124/
---
(Updated Dec. 9, 2013, 11:30 a.m.)
Review request for cloudstack and Sateesh Ch
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14124/
---
(Updated Dec. 24, 2013, 9:18 a.m.)
Review request for cloudstack and Sateesh Ch
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14124/
---
(Updated Dec. 24, 2013, 9:20 a.m.)
Review request for cloudstack, Jayapal Reddy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14124/#review30864
---
Commit d825b3dd141c76c0af8d02bac2147378a3506e96 in branch refs/heads
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14124/#review30865
---
Ship it!
Ship It!
- Jayapal Reddy
On Dec. 24, 2013, 9:20 a.m., S
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14124/#review30866
---
Commit ab4f095c68d4a4b4fb354b3d95096b193706987d in branch refs/heads
Could this be causing CLOUDSTACK-5652? I just see that it touches the
isNetworkAWithinNetworkB, which now seems to return true for
everything I try when deploying two networks in a vpc.
On Thu, Dec 26, 2013 at 4:51 AM, ASF Subversion and Git Services
wrote:
>
> ---
This is definitely the cause of the regression.
Sateesh/Jaypal, please revert your change. It doesn¹t do the correct cidd
validation.
+ if((startIpFirst >= startIpSecond) && (endIpFirst <= endIpSecond))
+ return true;
You can¹t just compare CIDRs ip ranges as they may never cross. For
example,
Yes, I verified that reverting the change on my local copy fixed the issue.
On Thu, Dec 26, 2013 at 2:55 PM, Alena Prokharchyk
wrote:
> This is definitely the cause of the regression.
>
> Sateesh/Jaypal, please revert your change. It doesn¹t do the correct cidd
> validation.
>
>
> + if((startIpFi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14124/#review30903
---
Commit 0478aee78fe481e81eb4820cf181e4beb42ae22a in branch refs/heads
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14124/#review30904
---
Commit 07de75191c487de980be795b202b0a8d8bbda4d6 in branch refs/heads
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14124/
---
(Updated Dec. 30, 2013, 3:22 p.m.)
Review request for cloudstack, Jayapal Reddy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14124/
---
(Updated Jan. 7, 2014, 11:58 a.m.)
Review request for cloudstack, Jayapal Reddy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14124/#review32472
---
Can you please run marvin test cases of VPC with this patch and upda
17 matches
Mail list logo