Re: Review Request 14451: Some test for NetUtils

2013-11-07 Thread Amogh Vasekar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14451/#review28417 --- Reminder- Hi, The review has been pending for long. Please update th

Re: Review Request 14451: Some test for NetUtils

2013-10-04 Thread Darren Shepherd
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14451/#review26684 --- It seems this patch includes a lot of line length based reformatting

Re: Review Request 14451: Some test for NetUtils

2013-10-04 Thread Laszlo Hornyak
> On Oct. 4, 2013, 6:43 a.m., Saksham Srivastava wrote: > > utils/test/com/cloud/utils/net/NetUtilsTest.java, line 225 > > > > > > What I am suggesting is that add a method something like > > boolean isEqual(var1,

Re: Review Request 14451: Some test for NetUtils

2013-10-04 Thread Saksham Srivastava
> On Oct. 4, 2013, 6:43 a.m., Saksham Srivastava wrote: > > utils/test/com/cloud/utils/net/NetUtilsTest.java, line 225 > > > > > > What I am suggesting is that add a method something like > > boolean isEqual(var1,

Re: Review Request 14451: Some test for NetUtils

2013-10-04 Thread Laszlo Hornyak
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14451/ --- (Updated Oct. 4, 2013, 11:12 a.m.) Review request for cloudstack. Bugs: CLOUD

Re: Review Request 14451: Some test for NetUtils

2013-10-04 Thread Laszlo Hornyak
> On Oct. 4, 2013, 6:43 a.m., Saksham Srivastava wrote: > > utils/src/com/cloud/utils/net/NetUtils.java, line 149 > > > > > > I have created https://issues.apache.org/jira/browse/CLOUDSTACK-4807. > > You could assign

Re: Review Request 14451: Some test for NetUtils

2013-10-03 Thread Saksham Srivastava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14451/#review26660 --- utils/src/com/cloud/utils/net/NetUtils.java

Re: Review Request 14451: Some test for NetUtils

2013-10-03 Thread Laszlo Hornyak
> On Oct. 3, 2013, 10:10 a.m., Saksham Srivastava wrote: > > utils/src/com/cloud/utils/net/NetUtils.java, line 366 > > > > > > Any particular reason for making dot as private static ? Making it > > local to ip2Long co

Re: Review Request 14451: Some test for NetUtils

2013-10-03 Thread Saksham Srivastava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14451/#review26645 --- utils/src/com/cloud/utils/net/NetUtils.java

Review Request 14451: Some test for NetUtils

2013-10-02 Thread Laszlo Hornyak
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14451/ --- Review request for cloudstack. Repository: cloudstack-git Description ---