Re: Review Request 15763: Changed 'MigrateCommand' to use the global setting value of 'execute.in.sequence.hypervisor.commands'

2013-12-05 Thread Alex Ough
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15763/ --- (Updated Dec. 5, 2013, 3:28 p.m.) Review request for cloudstack. Changes

Re: Review Request 15763: Changed 'MigrateCommand' to use the global setting value of 'execute.in.sequence.hypervisor.commands'

2013-12-05 Thread Alex Ough
Hi Koushik, I followed your instructions and this is the merged commit. https://reviews.apache.org/r/15763/diff/ Let me know if there is anything missing/incorrect. Thanks Alex Ough On Wed, Dec 4, 2013 at 11:44 PM, Koushik Das koushik@citrix.com wrote: Alex, This is what you need

Re: Review Request 15763: Changed 'MigrateCommand' to use the global setting value of 'execute.in.sequence.hypervisor.commands'

2013-12-05 Thread Koushik Das
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15763/#review29870 --- Ship it! Ship It! - Koushik Das On Dec. 5, 2013, 3:28 p.m.,

Re: Review Request 15763: Changed 'MigrateCommand' to use the global setting value of 'execute.in.sequence.hypervisor.commands'

2013-12-05 Thread Koushik Das
On Dec. 6, 2013, 4:19 a.m., Koushik Das wrote: Ship It! master - 88f64b2b93a3898e7868e9e55c1feca57b2ed48e - Koushik --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15763/#review29870

Re: Review Request 15763: Changed 'MigrateCommand' to use the global setting value of 'execute.in.sequence.hypervisor.commands'

2013-12-05 Thread Alex Ough
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15763/#review29872 --- Ship it! Ship It! - Alex Ough On Dec. 5, 2013, 3:28 p.m., Alex

Re: Review Request 15763: Changed 'MigrateCommand' to use the global setting value of 'execute.in.sequence.hypervisor.commands'

2013-12-04 Thread Alex Ough
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15763/ --- (Updated Dec. 4, 2013, 3:16 p.m.) Review request for cloudstack. Changes

Re: Review Request 15763: Changed 'MigrateCommand' to use the global setting value of 'execute.in.sequence.hypervisor.commands'

2013-12-04 Thread Alex Ough
Hi Koushik, This time I reloaded only the 2 changes. To make it clean, I tried to remove the previous incorrect one, but I couldn't find how. So let me know if it is better to discard this review and create a new one. Thanks Alex Ough On Wed, Dec 4, 2013 at 12:04 AM, Koushik Das

Re: Review Request 15763: Changed 'MigrateCommand' to use the global setting value of 'execute.in.sequence.hypervisor.commands'

2013-12-03 Thread Koushik Das
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15763/#review29649 --- core/src/com/cloud/agent/api/MigrateCommand.java

Re: Review Request 15763: Changed 'MigrateCommand' to use the global setting value of 'execute.in.sequence.hypervisor.commands'

2013-12-03 Thread Koushik Das
On Dec. 3, 2013, 8:44 a.m., Koushik Das wrote: core/src/com/cloud/agent/api/MigrateCommand.java, line 32 https://reviews.apache.org/r/15763/diff/1/?file=389559#file389559line32 I see that you have tested for XS. In the mail thread people have mentioned that it should work on

Re: Review Request 15763: Changed 'MigrateCommand' to use the global setting value of 'execute.in.sequence.hypervisor.commands'

2013-12-03 Thread Alex Ough
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15763/ --- (Updated Dec. 3, 2013, 5:07 p.m.) Review request for cloudstack. Changes

Re: Review Request 15763: Changed 'MigrateCommand' to use the global setting value of 'execute.in.sequence.hypervisor.commands'

2013-12-03 Thread Koushik Das
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15763/#review29716 --- Looks like the latest patch has some issues, the diff is not

Review Request 15763: Changed 'MigrateCommand' to use the global setting value of 'execute.in.sequence.hypervisor.commands'

2013-11-21 Thread Alex Ough
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15763/ --- Review request for cloudstack. Repository: cloudstack-git Description