Re: Review Request 17736: CLOUDSTACK-5999: Virtual Router does not start if Guest VM is rebooted from CloudStack

2014-07-23 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17736/#review48626 --- Commit 0f85e649b64b38cf80bc1e86ac15b206bef65117 in cloudstack's

Re: Review Request 17736: CLOUDSTACK-5999: Virtual Router does not start if Guest VM is rebooted from CloudStack

2014-03-14 Thread Saksham Srivastava
On March 13, 2014, 4:46 p.m., John Burwell wrote: server/src/com/cloud/vm/UserVmManagerImpl.java, line 756 https://reviews.apache.org/r/17736/diff/3/?file=518208#file518208line756 Two queries are executed in this for loop which puts stress on the database and slows down the

Re: Review Request 17736: CLOUDSTACK-5999: Virtual Router does not start if Guest VM is rebooted from CloudStack

2014-03-14 Thread Saksham Srivastava
On March 13, 2014, 4:55 p.m., Alena Prokharchyk wrote: Also why don't start routers in parallel? First, get all the router nics in one query like John suggested, then span start process for routers in separate threads, check the status of each job using Future. Sure I will do that. -

Re: Review Request 17736: CLOUDSTACK-5999: Virtual Router does not start if Guest VM is rebooted from CloudStack

2014-03-13 Thread Saksham Srivastava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17736/ --- (Updated March 13, 2014, 7:02 a.m.) Review request for cloudstack, John

Re: Review Request 17736: CLOUDSTACK-5999: Virtual Router does not start if Guest VM is rebooted from CloudStack

2014-03-13 Thread Saksham Srivastava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17736/ --- (Updated March 13, 2014, 7:31 a.m.) Review request for cloudstack, John

Re: Review Request 17736: CLOUDSTACK-5999: Virtual Router does not start if Guest VM is rebooted from CloudStack

2014-03-13 Thread John Burwell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17736/#review37061 --- server/src/com/cloud/vm/UserVmManagerImpl.java

Re: Review Request 17736: CLOUDSTACK-5999: Virtual Router does not start if Guest VM is rebooted from CloudStack

2014-03-13 Thread Alena Prokharchyk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17736/#review37064 --- Also why don't start routers in parallel? First, get all the router

Re: Review Request 17736: CLOUDSTACK-5999: Virtual Router does not start if Guest VM is rebooted from CloudStack

2014-03-13 Thread Alena Prokharchyk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17736/#review37066 --- Also why don't start routers in parallel? First, get all the router

Re: Review Request 17736: CLOUDSTACK-5999: Virtual Router does not start if Guest VM is rebooted from CloudStack

2014-02-07 Thread Saksham Srivastava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17736/#review33921 --- server/src/com/cloud/vm/UserVmManagerImpl.java

Re: Review Request 17736: CLOUDSTACK-5999: Virtual Router does not start if Guest VM is rebooted from CloudStack

2014-02-07 Thread Saksham Srivastava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17736/ --- (Updated Feb. 7, 2014, 9:26 a.m.) Review request for cloudstack, John Burwell

Re: Review Request 17736: CLOUDSTACK-5999: Virtual Router does not start if Guest VM is rebooted from CloudStack

2014-02-06 Thread John Burwell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17736/#review33792 --- server/src/com/cloud/vm/UserVmManagerImpl.java

Review Request 17736: CLOUDSTACK-5999: Virtual Router does not start if Guest VM is rebooted from CloudStack

2014-02-05 Thread Saksham Srivastava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17736/ --- Review request for cloudstack and Murali Reddy. Bugs: CLOUDSTACK-5999