Re: Review Request 17747: CLOUDSTACK-6023:Non windows instances are created on XenServer with a vcpu-max above supported xenserver limits

2015-04-06 Thread Sebastien Goasguen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17747/#review78995 --- Thank you for submitting your CloudStack contribution through

Re: Review Request 17747: CLOUDSTACK-6023:Non windows instances are created on XenServer with a vcpu-max above supported xenserver limits

2014-12-05 Thread Rohit Yadav
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17747/#review64041 --- Hari, your fix is already on 4.3; but not on 4.4, 4.5 or master.

Re: Review Request 17747: CLOUDSTACK-6023:Non windows instances are created on XenServer with a vcpu-max above supported xenserver limits

2014-10-09 Thread Harikrishna Patnala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17747/ --- (Updated Oct. 9, 2014, 9:27 a.m.) Review request for cloudstack, Abhinandan

Re: Review Request 17747: CLOUDSTACK-6023:Non windows instances are created on XenServer with a vcpu-max above supported xenserver limits

2014-02-10 Thread Joris van Lieshout
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17747/#review34062 --- On high instance count cluster hosts (in clusters based on XS6.2) a

Re: Review Request 17747: CLOUDSTACK-6023:Non windows instances are created on XenServer with a vcpu-max above supported xenserver limits

2014-02-10 Thread Harikrishna Patnala
On Feb. 10, 2014, 8:41 a.m., Joris van Lieshout wrote: On high instance count cluster hosts (in clusters based on XS6.2) a max of 16 would reduce the allowed instances on such a host. I would like to suggest, in addition to the current proposition, make dynamic scaling configurable

Re: Review Request 17747: CLOUDSTACK-6023:Non windows instances are created on XenServer with a vcpu-max above supported xenserver limits

2014-02-10 Thread Nitin Mehta
On Feb. 10, 2014, 8:41 a.m., Joris van Lieshout wrote: On high instance count cluster hosts (in clusters based on XS6.2) a max of 16 would reduce the allowed instances on such a host. I would like to suggest, in addition to the current proposition, make dynamic scaling configurable

Re: Review Request 17747: CLOUDSTACK-6023:Non windows instances are created on XenServer with a vcpu-max above supported xenserver limits

2014-02-07 Thread Harikrishna Patnala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17747/ --- (Updated Feb. 7, 2014, 11:19 a.m.) Review request for cloudstack, Abhinandan

Re: Review Request 17747: CLOUDSTACK-6023:Non windows instances are created on XenServer with a vcpu-max above supported xenserver limits

2014-02-07 Thread Kishan Kavala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17747/#review33924 --- Ship it! Ship It! - Kishan Kavala On Feb. 7, 2014, 4:49 p.m.,

Re: Review Request 17747: CLOUDSTACK-6023:Non windows instances are created on XenServer with a vcpu-max above supported xenserver limits

2014-02-07 Thread Nitin Mehta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17747/#review33928 ---

Re: Review Request 17747: CLOUDSTACK-6023:Non windows instances are created on XenServer with a vcpu-max above supported xenserver limits

2014-02-07 Thread Nitin Mehta
Hey Daan, I guess you are talking about your fix submitted in master [1]. You might want to see Hari's latest patch [2] as well. It solves the following two things which I guess your fix misses. 1. It sets the vcpu max to a hardcoded value (say 16) only when dynamic scaling is enabled. Do note

RE: Review Request 17747: CLOUDSTACK-6023:Non windows instances are created on XenServer with a vcpu-max above supported xenserver limits

2014-02-07 Thread Animesh Chaturvedi
Can I have the patch applied in 4.3-forward? -Original Message- From: Nitin Mehta [mailto:nitin.me...@citrix.com] Sent: Friday, February 07, 2014 11:33 AM To: dev@cloudstack.apache.org Cc: Harikrishna Patnala; Anthony Xu Subject: Re: Review Request 17747: CLOUDSTACK-6023:Non windows

RE: Review Request 17747: CLOUDSTACK-6023:Non windows instances are created on XenServer with a vcpu-max above supported xenserver limits

2014-02-07 Thread Animesh Chaturvedi
-Original Message- From: Nitin Mehta [mailto:nitin.me...@citrix.com] Sent: Friday, February 07, 2014 11:33 AM To: dev@cloudstack.apache.org Cc: Harikrishna Patnala; Anthony Xu Subject: Re: Review Request 17747: CLOUDSTACK-6023:Non windows instances are created on XenServer with a

Re: Review Request 17747: CLOUDSTACK-6023:Non windows instances are created on XenServer with a vcpu-max above supported xenserver limits

2014-02-07 Thread Harikrishna Patnala
On Feb. 7, 2014, 3:57 p.m., Nitin Mehta wrote: plugins/hypervisors/xen/src/com/cloud/hypervisor/XenServerGuru.java, line 70 https://reviews.apache.org/r/17747/diff/2/?file=480018#file480018line70 Will the upgrade path get this config ?? Yes Nitin, after upgrade or fresh 4.3 setup

Re: Review Request 17747: CLOUDSTACK-6023:Non windows instances are created on XenServer with a vcpu-max above supported xenserver limits

2014-02-07 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17747/#review33959 --- Commit 95e41fdf0da50c165a9317847058fce4efeddbcf in branch

Re: Review Request 17747: CLOUDSTACK-6023:Non windows instances are created on XenServer with a vcpu-max above supported xenserver limits

2014-02-07 Thread Nitin Mehta
Animesh - done. Please cherry pick to 4.3 Daan - for pushing this to master I will have to revert your fix in master. On 07/02/14 11:48 AM, Animesh Chaturvedi animesh.chaturv...@citrix.com wrote: Can I have the patch applied in 4.3-forward? -Original Message- From: Nitin Mehta

RE: Review Request 17747: CLOUDSTACK-6023:Non windows instances are created on XenServer with a vcpu-max above supported xenserver limits

2014-02-07 Thread Harikrishna Patnala
Here is the commit id on 4.3-forward commit 95e41fdf0da50c165a9317847058fce4efeddbcf -Harikrishna From: Nitin Mehta Sent: Saturday, February 08, 2014 2:46 AM To: dev@cloudstack.apache.org Cc: Harikrishna Patnala; Anthony Xu Subject: Re: Review Request

RE: Review Request 17747: CLOUDSTACK-6023:Non windows instances are created on XenServer with a vcpu-max above supported xenserver limits

2014-02-07 Thread Animesh Chaturvedi
Done applied to 4.3 -Original Message- From: Harikrishna Patnala Sent: Friday, February 07, 2014 1:31 PM To: Nitin Mehta; dev@cloudstack.apache.org Cc: Anthony Xu; Animesh Chaturvedi Subject: RE: Review Request 17747: CLOUDSTACK-6023:Non windows instances are created on XenServer

Re: Review Request 17747: CLOUDSTACK-6023:Non windows instances are created on XenServer with a vcpu-max above supported xenserver limits

2014-02-07 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17747/#review33967 --- Commit 01289b1647db2b08d42c883452aae6ca7dda in branch

Re: Review Request 17747: CLOUDSTACK-6023:Non windows instances are created on XenServer with a vcpu-max above supported xenserver limits

2014-02-06 Thread daan Hoogland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17747/#review33778 --- Harikrishna, I would like to see the intermediate option of scale

Re: Review Request 17747: CLOUDSTACK-6023:Non windows instances are created on XenServer with a vcpu-max above supported xenserver limits

2014-02-06 Thread Harikrishna Patnala
On Feb. 6, 2014, 8:41 a.m., daan Hoogland wrote: Harikrishna, I would like to see the intermediate option of scale up to double the amount as well. Did you revert it? Is there a problem with this approach? Otherwise your submission is fine, of course. Hi Daan, I did not revert

Re: Review Request 17747: CLOUDSTACK-6023:Non windows instances are created on XenServer with a vcpu-max above supported xenserver limits

2014-02-06 Thread Daan Hoogland
we have hosts with 80 vms. 80*16 160 , which is spedcified in the xenserver docs Joris came up with. That last part is not important to me but I am still worried about the size of the statistics post by the members to the pool-master. If we can make sure we don't cross this boundary I am fine

RE: Review Request 17747: CLOUDSTACK-6023:Non windows instances are created on XenServer with a vcpu-max above supported xenserver limits

2014-02-06 Thread Animesh Chaturvedi
-Original Message- From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] Sent: Thursday, February 06, 2014 6:33 AM To: Harikrishna Patnala Cc: Nitin Mehta; cloudstack Subject: Re: Review Request 17747: CLOUDSTACK-6023:Non windows instances are created on XenServer with a vcpu-max

RE: Review Request 17747: CLOUDSTACK-6023:Non windows instances are created on XenServer with a vcpu-max above supported xenserver limits

2014-02-06 Thread Animesh Chaturvedi
-Original Message- From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] Sent: Thursday, February 06, 2014 6:33 AM To: Harikrishna Patnala Cc: Nitin Mehta; cloudstack Subject: Re: Review Request 17747: CLOUDSTACK-6023:Non windows instances are created on XenServer with a vcpu-max

Re: Review Request 17747: CLOUDSTACK-6023:Non windows instances are created on XenServer with a vcpu-max above supported xenserver limits

2014-02-06 Thread Daan Hoogland
Animesh, I put in a patch that makes it double the number of assigned vcpu or 16 whichever is smaller. it is on 4.3-forward On Fri, Feb 7, 2014 at 6:28 AM, Animesh Chaturvedi animesh.chaturv...@citrix.com wrote: -Original Message- From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]

Review Request 17747: CLOUDSTACK-6023:Non windows instances are created on XenServer with a vcpu-max above supported xenserver limits

2014-02-05 Thread Harikrishna Patnala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17747/ --- Review request for cloudstack and Nitin Mehta. Bugs: CLOUDSTACK-6023