Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions (New Plugin)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17790/#review78992 --- Thank you for submitting your CloudStack contribution through review

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions (New Plugin)

" > Date: Friday, December 5, 2014 at 2:15 PM > To: Alena Prokharchyk > Cc: "dev@cloudstack.apache.org" , Alex Ough > , John Burwell > Subject: Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple > Regions (New Plugin) > > On Sat, Dec 6, 2014 a

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions (New Plugin)

.org>>, Alex Ough mailto:alex.o...@sungard.com>>, John Burwell mailto:jburw...@basho.com>> Subject: Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions (New Plugin) On Sat, Dec 6, 2014 at 3:39 AM, Alena Prokharchyk < alena.prokharc...@citrix.com<mailto:

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions (New Plugin)

y, December 5, 2014 at 10:41 AM > To: cloudstack , Alex Ough < > alex.o...@sungard.com>, Rohit Yadav > Subject: Re: Review Request 17790: Domain-Account-User Sync Up Among > Multiple Regions (New Plugin) > > > ---

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions (New Plugin)

k.apache.org>>, Rohit Yadav mailto:bhais...@apache.org>> Date: Friday, December 5, 2014 at 10:41 AM To: cloudstack mailto:dev@cloudstack.apache.org>>, Alex Ough mailto:alex.o...@sungard.com>>, Rohit Yadav mailto:bhais...@apache.org>> Subject: Re: Review Request 17790: Domain

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions (New Plugin)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17790/#review64047 --- ping. any update on this? - Rohit Yadav On June 27, 2014, 5:04 p.

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions (New Plugin)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17790/ --- (Updated June 27, 2014, 5:04 p.m.) Review request for cloudstack. Repository:

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions (New Plugin)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17790/ --- (Updated June 24, 2014, 3:52 p.m.) Review request for cloudstack. Changes ---

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions (New Plugin)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17790/ --- (Updated June 20, 2014, 3:49 p.m.) Review request for cloudstack. Changes ---

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions (New Plugin)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17790/ --- (Updated June 15, 2014, 9:48 p.m.) Review request for cloudstack. Changes ---

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions (New Plugin)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17790/#review42512 --- Looks good to me, Alex. Lets wait for the resolution on https://rev

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions (New Plugin)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17790/ --- (Updated May 7, 2014, 10:46 p.m.) Review request for cloudstack. Repository:

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions (New Plugin)

> On May 5, 2014, 6:28 p.m., Alena Prokharchyk wrote: > > Alex, > > > > Move all new API commands/responses you've added > > (ListSyncAccountsCmdByAdmin.java, SyncAccountResponse.java), to your > > plugin's "multiregion" folder. Look how its done for other CS plugins - > > internallb for exam

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions (New Plugin)

> On May 5, 2014, 6:28 p.m., Alena Prokharchyk wrote: > > Alex, > > > > Move all new API commands/responses you've added > > (ListSyncAccountsCmdByAdmin.java, SyncAccountResponse.java), to your > > plugin's "multiregion" folder. Look how its done for other CS plugins - > > internallb for exam

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions (New Plugin)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17790/#review42177 --- Alex, Move all new API commands/responses you've added (ListSyncAc

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions (New Plugin)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17790/ --- (Updated May 4, 2014, 9:18 p.m.) Review request for cloudstack. Repository: c

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions (New Plugin)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17790/ --- (Updated April 16, 2014, 7:07 p.m.) Review request for cloudstack. Changes --

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions (New Plugin)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17790/ --- (Updated April 7, 2014, 7:17 p.m.) Review request for cloudstack. Changes ---

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions (New Plugin)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17790/ --- (Updated April 7, 2014, 7:15 p.m.) Review request for cloudstack. Changes ---

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions (New Plugin)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17790/ --- (Updated April 7, 2014, 7:14 p.m.) Review request for cloudstack. Changes ---

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17790/#review39701 --- Alex, can you please 1) split your fix into 2 patches: Patch #1 –

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions

e: Saturday, April 5, 2014 at 8:32 PM To: daan Hoogland mailto:daan.hoogl...@gmail.com>>, Alex Ough mailto:alex.o...@sungard.com>>, Alena Prokharchyk mailto:alena.prokharc...@citrix.com>>, cloudstack mailto:dev@cloudstack.apache.org>> Subject: Re: Review Request 17790:

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17790/ --- (Updated April 6, 2014, 3:32 a.m.) Review request for cloudstack. Changes ---

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17790/ --- (Updated April 5, 2014, 9:31 p.m.) Review request for cloudstack. Changes ---

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17790/#review39482 --- Alex, all the fixes from the previous review, were done, thank you.

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17790/ --- (Updated April 3, 2014, 3:54 p.m.) Review request for cloudstack. Changes ---

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17790/ --- (Updated April 3, 2014, 3:52 p.m.) Review request for cloudstack. Changes ---

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17790/#review38761 --- 1) You are breaking API compatiblity with introducing new required p

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17790/ --- (Updated March 26, 2014, 1:32 p.m.) Review request for cloudstack. Changes --

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17790/#review37097 --- Patch B. * You shouldn’t make your service a part of cloud-mom-rabb

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17790/ --- (Updated March 12, 2014, 3:57 p.m.) Review request for cloudstack. Changes --

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17790/ --- (Updated March 12, 2014, 3:14 p.m.) Review request for cloudstack. Changes --

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17790/ --- (Updated March 9, 2014, 10:50 p.m.) Review request for cloudstack. Changes --

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17790/ --- (Updated March 8, 2014, 7:06 p.m.) Review request for cloudstack. Changes ---

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions

H Alex, I will have a test go at this. Did you monkey test it yourself and did you build and run it with -Dnoredist? On Sat, Mar 8, 2014 at 7:30 PM, Alex Ough wrote: >This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17790/ > Review request for clo

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17790/ --- (Updated March 8, 2014, 6:29 p.m.) Review request for cloudstack. Changes ---

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions

master, before the 14th. If we get it in in time we will have to make fixes on both 4.4-forward and master. On Wed, Mar 5, 2014 at 10:33 PM, Alex Ough wrote: > What branch needs to be based to create a review request of this > implementation that will be included in 4.4 release? > 4.3 or 4.3-forw

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions

What branch needs to be based to create a review request of this implementation that will be included in 4.4 release? 4.3 or 4.3-forward? Thanks Alex Ough On Tue, Mar 4, 2014 at 1:25 PM, Alex Ough wrote: > Yes, by 3/7. > > Thanks > Alex Ough > > > On Tue, Mar 4, 2014 at 12:30 PM, Daan Hoogland

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions

Yes, by 3/7. Thanks Alex Ough On Tue, Mar 4, 2014 at 12:30 PM, Daan Hoogland wrote: > This week? should be ok. end of next week is too late! > > On Tue, Mar 4, 2014 at 6:17 PM, Alex Ough wrote: > > Do you think it is ok to wrap up the implementation until the end of this > > week to make this

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions

Do you think it is ok to wrap up the implementation until the end of this week to make this included in 4.4 release? Thanks Alex Ough On Sun, Mar 2, 2014 at 2:10 PM, Daan Hoogland wrote: > two weeks from now, but under debate. Let's go with that, though. > > On Sun, Mar 2, 2014 at 1:17 AM, Alex

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions

This week? should be ok. end of next week is too late! On Tue, Mar 4, 2014 at 6:17 PM, Alex Ough wrote: > Do you think it is ok to wrap up the implementation until the end of this > week to make this included in 4.4 release? > > Thanks > Alex Ough > > > On Sun, Mar 2, 2014 at 2:10 PM, Daan Hoogla

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions

two weeks from now, but under debate. Let's go with that, though. On Sun, Mar 2, 2014 at 1:17 AM, Alex Ough wrote: > Can you tell me when the deadline for 4.4 is? > > Thanks > Alex Ough > > > On Sat, Mar 1, 2014 at 2:26 PM, Daan Hoogland > wrote: >> >> Ha Alex, >> >> branch 4.3 is going to be a

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions

Can you tell me when the deadline for 4.4 is? Thanks Alex Ough On Sat, Mar 1, 2014 at 2:26 PM, Daan Hoogland wrote: > Ha Alex, > > branch 4.3 is going to be a problem. We will be able to release this > with 4.4 if we hurry. > > On Fri, Feb 28, 2014 at 4:01 PM, Alex Ough wrote: > > Hi Daan, > >

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions

Ha Alex, branch 4.3 is going to be a problem. We will be able to release this with 4.4 if we hurry. On Fri, Feb 28, 2014 at 4:01 PM, Alex Ough wrote: > Hi Daan, > > 1. Yes, we'll update the request once all the unit tests are completed. > 2. And yes, it is a branch from 4.3 > 3. I'm using the gl

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions

Hi Daan, 1. Yes, we'll update the request once all the unit tests are completed. 2. And yes, it is a branch from 4.3 3. I'm using the global parameter, called 'region.auto.generation.interval' and the value is 0 (millisec) by default. If you set the value more than 0, it will automatically cre

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions

I see, great. I will find a moment to apply it and test. It looks good at first sight. Don't forget adding the license header to the new files. Are you updating the review request with these tests? You are using a local branch to implement this on, 'alexoughsg/Albatross' is a fork of cloudstack

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions

Hi Daan, We started to work on implementing unit tests and checked in some of them, so please review them and let us know if there is any comments/suggestions. https://github.com/alexoughsg/Albatross/commit/fca94db36054ee35f5da85c69c2471430e0eebfe Thanks Alex Ough On Thu, Feb 13, 2014 at 3:15

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions

We're just about to add unit tests, so I'll add them once completed. Thanks Alex Ough On Thu, Feb 13, 2014 at 3:12 PM, Daan Hoogland wrote: > h Alex, > > looks alright (i did mean with newlines but I don't know if this is > actually caught by our checkstyle run) I was wondering if you have any

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions

h Alex, looks alright (i did mean with newlines but I don't know if this is actually caught by our checkstyle run) I was wondering if you have any unit tests for your code. I can see you did take testing seriously and I would like to see this formalized for future reference and repetition on upda

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions

Hi Daan, Does it look good to you? Thanks Alex Ough On Mon, Feb 10, 2014 at 1:07 PM, Alex Ough wrote: >This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17790/ > Review request for cloudstack. > By Alex Ough. > > *Updated Feb. 10, 2014, 7:06 p.m.*

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17790/ --- (Updated Feb. 10, 2014, 7:06 p.m.) Review request for cloudstack. Changes ---

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17790/#review33801 --- engine/schema/src/com/cloud/domain/DomainVO.java

Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17790/ --- Review request for cloudstack. Repository: cloudstack-git Description ---