Re: Review Request 18759: HTTP support for console proxy and making it default

2014-04-01 Thread Amogh Vasekar
> On March 9, 2014, 9:08 p.m., John Kinsella wrote: > > Ship It! John, I noticed the ConsoleProxyInfo file is missing from the commit in 4.3 branch. Can you please add the file, so that it makes it to the maintenance release? Thanks! - Amogh ---

Re: Review Request 18759: HTTP support for console proxy and making it default

2014-03-10 Thread Amogh Vasekar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18759/ --- (Updated March 10, 2014, 7:17 p.m.) Review request for cloudstack, Demetrius Ts

Re: Review Request 18759: HTTP support for console proxy and making it default

2014-03-09 Thread John Kinsella
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18759/#review36614 --- Ship it! Ship It! - John Kinsella On March 7, 2014, 12:32 a.m.,

Re: Review Request 18759: HTTP support for console proxy and making it default

2014-03-06 Thread Amogh Vasekar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18759/ --- (Updated March 7, 2014, 12:32 a.m.) Review request for cloudstack, Demetrius Ts

Re: Review Request 18759: HTTP support for console proxy and making it default

2014-03-06 Thread Amogh Vasekar
> On March 6, 2014, 6:31 p.m., John Kinsella wrote: > > setup/db/db/schema-421to430.sql, line 126 > > > > > > 1) Why 2 subqueries on these 2 updates? Shouldn't just... > > > > UPDATE `cloud`.`configuration` >

Re: Review Request 18759: HTTP support for console proxy and making it default

2014-03-06 Thread John Kinsella
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18759/#review36376 --- core/src/com/cloud/info/ConsoleProxyInfo.java

Re: Review Request 18759: HTTP support for console proxy and making it default

2014-03-05 Thread Animesh Chaturvedi
John can you review and close out this review. Thanks Animesh On Mar 5, 2014, at 12:47 PM, "Amogh Vasekar" wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18759/ > -

Re: Review Request 18759: HTTP support for console proxy and making it default

2014-03-05 Thread Amogh Vasekar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18759/ --- (Updated March 5, 2014, 8:47 p.m.) Review request for cloudstack, Demetrius Tsi

Re: Review Request 18759: HTTP support for console proxy and making it default

2014-03-05 Thread Amogh Vasekar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18759/ --- (Updated March 5, 2014, 8:33 p.m.) Review request for cloudstack, Demetrius Tsi

Re: Review Request 18759: HTTP support for console proxy and making it default

2014-03-05 Thread Amogh Vasekar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18759/ --- (Updated March 5, 2014, 7:26 p.m.) Review request for cloudstack, Demetrius Tsi

Re: Review Request 18759: HTTP support for console proxy and making it default

2014-03-05 Thread Amogh Vasekar
> On March 5, 2014, 7:43 a.m., John Kinsella wrote: > > server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java, line 1719 > > > > > > This doesn't seem relevant to the issue at hand. Ditto - Amogh ---

Re: Review Request 18759: HTTP support for console proxy and making it default

2014-03-05 Thread Amogh Vasekar
> On March 5, 2014, 7:43 a.m., John Kinsella wrote: > > core/src/com/cloud/info/ConsoleProxyInfo.java, line 45 > > > > > > Can you clean up trailing whitespace added in lines like this? Will do. IDE issues :( > On Ma

Re: Review Request 18759: HTTP support for console proxy and making it default

2014-03-04 Thread John Kinsella
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18759/#review36212 --- Amogh - thanks for the patch. Some small issues on this patch. I've

Re: Review Request 18759: HTTP support for console proxy and making it default

2014-03-04 Thread Amogh Vasekar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18759/ --- (Updated March 5, 2014, 1:42 a.m.) Review request for cloudstack, Demetrius Tsi

Review Request 18759: HTTP support for console proxy and making it default

2014-03-04 Thread Amogh Vasekar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18759/ --- Review request for cloudstack, Demetrius Tsitrelis and John Kinsella. Repositor