Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18964/ --- (Updated April 16, 2014, 9:52 a.m.) Review request for cloudstack, Abhinandan P

Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18964/#review38273 --- Ship it! Ship It! - Abhinandan Prateek On March 20, 2014, 5:47 p

Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18964/ --- (Updated March 20, 2014, 5:47 p.m.) Review request for cloudstack, Abhinandan P

Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

> On March 19, 2014, 11:09 a.m., daan Hoogland wrote: > > Damoder, > > > > You introduced some trailing whitespace in this version of the diff. > > As far as I can judge it it looks alright. > > One remark I have: scripts/installer/windows/client.wxs looks like it is > > generated by some tool

Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

> On March 19, 2014, 11:09 a.m., daan Hoogland wrote: > > Damoder, > > > > You introduced some trailing whitespace in this version of the diff. > > As far as I can judge it it looks alright. > > One remark I have: scripts/installer/windows/client.wxs looks like it is > > generated by some tool

Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

> On March 14, 2014, 12:14 p.m., Damodar Reddy Talakanti wrote: > > Hi Daan > > > > I have updated the FS in wiki regarding how to build and install using this > > code. The link to FS is > > > > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Cloudstack+Windowsfication#CloudstackWindow

Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18964/#review37703 --- Damoder, You introduced some trailing whitespace in this version of

Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18964/#review37701 --- This feature is going as a tech preview. There are parts that will r

Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

> On March 14, 2014, 12:14 p.m., Damodar Reddy Talakanti wrote: > > Hi Daan > > > > I have updated the FS in wiki regarding how to build and install using this > > code. The link to FS is > > > > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Cloudstack+Windowsfication#CloudstackWindow

Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18964/ --- (Updated March 18, 2014, 1:46 p.m.) Review request for cloudstack, Abhinandan P

Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

> On March 14, 2014, 12:14 p.m., Damodar Reddy Talakanti wrote: > > Hi Daan > > > > I have updated the FS in wiki regarding how to build and install using this > > code. The link to FS is > > > > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Cloudstack+Windowsfication#CloudstackWindow

Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18964/#review37198 --- server/src/com/cloud/server/ConfigurationServerImpl.java

Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18964/#review37192 --- Hi Daan I have updated the FS in wiki regarding how to build and in

Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18964/#review37191 --- Hi Daan I have updated the FS in wiki regarding how to build and in

Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

> On March 14, 2014, 9:58 a.m., daan Hoogland wrote: > > server/src/com/cloud/server/ConfigurationServerImpl.java, line 881 > > > > > > why is this condition needed if both the if and the else branch take > > the same

Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18964/ --- (Updated March 14, 2014, 12:10 p.m.) Review request for cloudstack, Abhinandan

Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18964/#review37186 --- Can you add some doc or ref to doc that explains how to test this on

Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18964/ --- (Updated March 14, 2014, 9:42 a.m.) Review request for cloudstack, Abhinandan P

Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18964/#review37185 --- The exe which was a major issue for this patch has been removed. Th

Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

> On March 11, 2014, 12:28 p.m., Donal Lafferty wrote: > > 1. How do you guarantee that 'sudo' is never added to scripts created by > > the Script class? See (utils/src/com/cloud/utils/script/Script.java) > > > > 2. How do you version control the .exe? > > > > 3. WiX can be run on Linux in

Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18964/ --- (Updated March 14, 2014, 9:16 a.m.) Review request for cloudstack, Abhinandan P

Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

> On March 11, 2014, 12:28 p.m., Donal Lafferty wrote: > > 1. How do you guarantee that 'sudo' is never added to scripts created by > > the Script class? See (utils/src/com/cloud/utils/script/Script.java) > > > > 2. How do you version control the .exe? > > > > 3. WiX can be run on Linux in

Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

> On March 11, 2014, 12:28 p.m., Donal Lafferty wrote: > > 1. How do you guarantee that 'sudo' is never added to scripts created by > > the Script class? See (utils/src/com/cloud/utils/script/Script.java) > > > > 2. How do you version control the .exe? > > > > 3. WiX can be run on Linux in

Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

> On March 11, 2014, 12:28 p.m., Donal Lafferty wrote: > > 1. How do you guarantee that 'sudo' is never added to scripts created by > > the Script class? See (utils/src/com/cloud/utils/script/Script.java) > > > > 2. How do you version control the .exe? > > > > 3. WiX can be run on Linux in

Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

> On March 11, 2014, 12:28 p.m., Donal Lafferty wrote: > > 1. How do you guarantee that 'sudo' is never added to scripts created by > > the Script class? See (utils/src/com/cloud/utils/script/Script.java) > > > > 2. How do you version control the .exe? > > > > 3. WiX can be run on Linux in

Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18964/ --- (Updated March 11, 2014, 12:45 p.m.) Review request for cloudstack, Abhinandan

Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

> On March 11, 2014, 12:28 p.m., Donal Lafferty wrote: > > 1. How do you guarantee that 'sudo' is never added to scripts created by > > the Script class? See (utils/src/com/cloud/utils/script/Script.java) > > > > 2. How do you version control the .exe? > > > > 3. WiX can be run on Linux in

Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18964/#review36773 --- 1. How do you guarantee that 'sudo' is never added to scripts creat

Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18964/ --- (Updated March 11, 2014, 12:26 p.m.) Review request for cloudstack and Chiradee

Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18964/ --- (Updated March 11, 2014, 12:26 p.m.) Review request for cloudstack, Abhinandan

Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18964/ --- (Updated March 11, 2014, 12:25 p.m.) Review request for cloudstack and Chiradee

Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

> On March 10, 2014, 4:53 p.m., daan Hoogland wrote: > > quite frankly I hate to see a binary file committed to the repo. start.exe > > does not apeal to me and is not descibed in the comments. I don't have a > > windows dev env and wouldn't be able to build but anyone planning to use > > this

Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18964/#review36661 --- quite frankly I hate to see a binary file committed to the repo. sta

Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18964/ --- Review request for cloudstack and Abhinandan Prateek. Bugs: https://issues.apac