Re: Review Request 23617: Add Nic UUID to the context so that we can read the same in event bus after create a nic

2014-07-22 Thread Damodar Reddy Talakanti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23617/ --- (Updated July 22, 2014, 9:15 a.m.) Review request for cloudstack and Nitin

Re: Review Request 23617: Add Nic UUID to the context so that we can read the same in event bus after create a nic

2014-07-22 Thread Damodar Reddy Talakanti
On July 17, 2014, 4:55 p.m., Nitin Mehta wrote: server/src/com/cloud/vm/UserVmManagerImpl.java, line 960 https://reviews.apache.org/r/23617/diff/1/?file=634289#file634289line960 Why is it made create=true when it is not a BaseAyncCreate cmd ? create=true should be added only when

Re: Review Request 23617: Add Nic UUID to the context so that we can read the same in event bus after create a nic

2014-07-22 Thread Damodar Reddy Talakanti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23617/ --- (Updated July 22, 2014, 9:16 a.m.) Review request for cloudstack, Kishan

Re: Review Request 23617: Add Nic UUID to the context so that we can read the same in event bus after create a nic

2014-07-22 Thread Damodar Reddy Talakanti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23617/ --- (Updated July 22, 2014, 12:35 p.m.) Review request for cloudstack, Kishan

Re: Review Request 23617: Add Nic UUID to the context so that we can read the same in event bus after create a nic

2014-07-22 Thread Kishan Kavala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23617/#review48472 --- Ship it! - Kishan Kavala On July 22, 2014, 6:05 p.m., Damodar

Re: Review Request 23617: Add Nic UUID to the context so that we can read the same in event bus after create a nic

2014-07-21 Thread Nitin Mehta
On July 17, 2014, 4:55 p.m., Nitin Mehta wrote: server/src/com/cloud/vm/UserVmManagerImpl.java, line 960 https://reviews.apache.org/r/23617/diff/1/?file=634289#file634289line960 Why is it made create=true when it is not a BaseAyncCreate cmd ? create=true should be added only when

Re: Review Request 23617: Add Nic UUID to the context so that we can read the same in event bus after create a nic

2014-07-19 Thread Damodar Reddy Talakanti
On July 17, 2014, 4:55 p.m., Nitin Mehta wrote: server/src/com/cloud/vm/UserVmManagerImpl.java, line 960 https://reviews.apache.org/r/23617/diff/1/?file=634289#file634289line960 Why is it made create=true when it is not a BaseAyncCreate cmd ? create=true should be added only when

Re: Review Request 23617: Add Nic UUID to the context so that we can read the same in event bus after create a nic

2014-07-18 Thread Damodar Reddy Talakanti
On July 17, 2014, 4:55 p.m., Nitin Mehta wrote: server/src/com/cloud/vm/UserVmManagerImpl.java, line 960 https://reviews.apache.org/r/23617/diff/1/?file=634289#file634289line960 Why is it made create=true when it is not a BaseAyncCreate cmd ? create=true should be added only when

Re: Review Request 23617: Add Nic UUID to the context so that we can read the same in event bus after create a nic

2014-07-18 Thread Nitin Mehta
On July 17, 2014, 4:55 p.m., Nitin Mehta wrote: server/src/com/cloud/vm/UserVmManagerImpl.java, line 960 https://reviews.apache.org/r/23617/diff/1/?file=634289#file634289line960 Why is it made create=true when it is not a BaseAyncCreate cmd ? create=true should be added only when

Re: Review Request 23617: Add Nic UUID to the context so that we can read the same in event bus after create a nic

2014-07-17 Thread Nitin Mehta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23617/#review48016 --- server/src/com/cloud/vm/UserVmManagerImpl.java