[GitHub] cloudstack issue #2023: BUG-ID: CLOUDSTACK-9808 Added system Vm upgrade path...

Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/2023 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1951 Ping @karuturi --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cloudstack issue #2023: BUG-ID: CLOUDSTACK-9808 Added system Vm upgrade path...

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/2023 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack issue #2023: BUG-ID: CLOUDSTACK-9808 Added system Vm upgrade path...

Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/2023 @karuturi I think it is easiest to just reapply and not search for the cause of an 8 month old PR resulting in conflicts. (if the original code has the right URLS in it) --- If your

[GitHub] cloudstack issue #2023: BUG-ID: CLOUDSTACK-9808 Added system Vm upgrade path...

Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/2023 code LGTM. Need to check why xenserver and KVM still have wrong urls on PR https://github.com/apache/cloudstack/pull/1582#issuecomment-288310796 --- If your project is set up for it, you can

[GitHub] cloudstack issue #2023: BUG-ID: CLOUDSTACK-9808 Added system Vm upgrade path...

Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/2023 LGTM @kishankavala did you check what went wrong with the kvm template. @karuturi reported that and it was probably some auto-conflict-resolution. --- If your project is set up for

[GitHub] cloudstack issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1951 ping @karuturi let's merge this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1951 Thanks @rhtyd for confirming. LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1951 @syed yes there is no problem I see, with `INSERT IGNORE` we can have this db change in both paths resulting in same final state. --- If your project is set up for it, you can reply to this

[GitHub] cloudstack issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1951 @rhtyd If I understand correctly if we add the DB changes in 4.9.2->4.9.3 then after forward merging, upgrade from 4.9.2->4.10.0 should not have any problems with idempotency correct? --- If

[GitHub] cloudstack issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

with) or as a separate PR targeted only for 4.10. 4.9.x should not have unnecessary db changes, therefore 4.9.2->4.9.3 is not expected of any other db changes, with this assumption and that 4.9.3 should be worked upon in next few months this would add an upgrade path from both 4.9.2/4.9.3 to 4.1

[GitHub] cloudstack issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1951 I already see schema-4920to41000.sql and the corresponding cleanup file in master. So how will this fit in the overall scheme? Is there any plans for 4.9.3? --- If your project is set up

[GitHub] cloudstack issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1951 Requesting for review - @DaanHoogland @abhinandanprateek @karuturi @koushik-das @syed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

Re: [QUESTION] Upgrade path to JDK8

http://stackoverflow.com/questions/10895969/can-newer-jre-versions-run-java-programs-compiled-with-older-jdk-versions You can run code compiled by the java 1.7 or 1.6 or earlier SDKs on a Java 8 JVM. This gets you the improved speed of the Java 8 JVM even if you do not rebuild the code. If

Re: [QUESTION] Upgrade path to JDK8

No there isn't any issue except having the bugs & fixes of the JDK you're using. You can compile it with a JDK 1.8 as long as you don't change the target bytecode version for 1.7 On Tue, Feb 21, 2017 at 8:15 AM, Wei ZHOU wrote: > Marco, > > Good point. Is there any issue

[GitHub] cloudstack issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1951 Thanks @borisstoyanov @karuturi ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

Re: [QUESTION] Upgrade path to JDK8

Marco, Good point. Is there any issue if we compile code with jdk8 but run it on jdk7 (systemvm) ? -Wei 2017-02-21 7:43 GMT+01:00 Marc-Aurèle Brothier : > There's a list of compatibility issues between Java 7 & Java 8 here > http://www.oracle.com/technetwork/java/javase/8- >

Re: [QUESTION] Upgrade path to JDK8

There's a list of compatibility issues between Java 7 & Java 8 here http://www.oracle.com/technetwork/java/javase/8-compatibility-guide-2156366. html The main problem I would see in two system communicating while running different Java version is the way they handle serialization and

Re: [QUESTION] Upgrade path to JDK8

We tested 4.7.1+systemd patches as well, it also works fine. -Wei 2017-02-20 22:34 GMT+01:00 Wei ZHOU : > @Will and @Syed, I build the packages of 4.9.2+systemd patches on ubuntu > 16.04 (openjdk 8). > Then install the packages to management server and kvm hosts (all are

Re: [QUESTION] Upgrade path to JDK8

@Will and @Syed, I build the packages of 4.9.2+systemd patches on ubuntu 16.04 (openjdk 8). Then install the packages to management server and kvm hosts (all are ubuntu 16.04 with openjdk8). The systemvm template is 4.6 with openjdk7. cpvm and ssvm work fine. As there is no java process in VR,

Re: [QUESTION] Upgrade path to JDK8

That's quite interesting Chiradeep! so I could do something like this I guest: mvn clean install and then this one to build the systemvm.iso: mvn -Psystemvm -source 1.7 -target 1.7 install I'll give it a try! but for now, I'm worried about existing VR, they must continue to work while running

Re: [QUESTION] Upgrade path to JDK8

You can build the system vm with -source 1.7 -target 1.7 Also unless you are using Java8 features (lambda) the classfiles produced by javac 8 should work in a 1.7 JVM Sent from my iPhone > On Feb 20, 2017, at 11:51 AM, Will Stevens wrote: > > yes, that is what I was

Re: [QUESTION] Upgrade path to JDK8

yes, that is what I was expecting. which is why I was asking about Wei's setup because he seems to have worked around that problem. Or he has a custom SystemVM template running with both JDK7 and JDK8. *Will STEVENS* Lead Developer On Mon, Feb 20, 2017 at 2:20 PM, Syed

Re: [QUESTION] Upgrade path to JDK8

The problem is that systemvm.iso is built with java 8 whereas java on the VR is java 7 On Mon, Feb 20, 2017 at 13:20 Will Stevens wrote: > Did it work after resetting a VPC or when blowing away the SSVM or CPVM? I > would not expect the SSVM or the CPVM to come up if the

Re: [QUESTION] Upgrade path to JDK8

Did it work after resetting a VPC or when blowing away the SSVM or CPVM? I would not expect the SSVM or the CPVM to come up if the management server was built with JDK8 and the system vm template is only using JDK7. Can you confirm?​ *Will STEVENS* Lead Developer On

Re: [QUESTION] Upgrade path to JDK8

We've tested management server 4.7.1 with ubuntu 16.04/openjdk8 and systemvm 4.6 with debian7/openjdk7. The systemvms (ssvm, cpvm) work fine. I agree we need consider the openjdk upgrade in systemvm template. -Wei 2017-02-20 18:15 GMT+01:00 Will Stevens : > Regarding my

Re: [QUESTION] Upgrade path to JDK8

Regarding my question. Is it because of the version of Java that the systemvm.iso is built on? On Feb 20, 2017 11:58 AM, "Will Stevens" wrote: > A question that is hidden in here is: > - Why does the JDK version on the management server have to match the JDK > version of

Re: [QUESTION] Upgrade path to JDK8

Are any Java enhancements being added to common libraries that would force the Client side to have to run Java 8? Would running Java 7 cause any library to need to be available in 2 versions? Ron On 20/02/2017 11:58 AM, Will Stevens wrote: A question that is hidden in here is: - Why does the

Re: [QUESTION] Upgrade path to JDK8

A question that is hidden in here is: - Why does the JDK version on the management server have to match the JDK version of the System VM? *Will STEVENS* Lead Developer On Mon, Feb 20, 2017 at 11:50 AM, Pierre-Luc Dion wrote: > Hi, > > In the context

[QUESTION] Upgrade path to JDK8

Hi, In the context of deployment of CloudStack with VPCs, What will happen to a cloud when upgrading to 4.10 that now use jdk8? Does upgrading the management-server to 4.10 jdk8 and then keep the old VRs run for a while that run on JDK7 will still work ? Because If we upgrade the

[GitHub] cloudstack pull request #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1951#discussion_r101851324 --- Diff: setup/db/db/schema-4920to4930.sql --- @@ -0,0 +1,22 @@ +-- Licensed to the Apache Software Foundation (ASF) under one +-- or more

[GitHub] cloudstack issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1951 Just want to confirm it fresh installs and upgrades the DB to 4.9.3. will cancel the run after as I'm planning to do an upgrade scenario as well. Thanks @rhtyd --- If your project

[GitHub] cloudstack issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1951 @borisstoyanov an explicit integration test is not necessary if Travis passes, since all changes are around db upgrade/version. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1951 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1951 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1951 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-504 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1951 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1951 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

T IGNORE INTO `cloud`.`hypervisor_capabilities`(uuid, hypervisor_type, hypervisor_version, max_guests_limit, max_data_volumes_limit, storage_motion_supported) values (UUID(), 'XenServer', '7.0.0', 500, 13, 1); --- End diff -- Note: On fwd merging, this can be re-executed in 4.9.2

[GitHub] cloudstack pull request #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1951 CLOUDSTACK-9792: Add upgrade path for 4.9.3.0 This adds an upgrade path from 4.9.2.0 to 4.9.3.0, this also includes changes from PR https://github.com/apache/cloudstack/pull/1928 that adds

[GitHub] cloudstack pull request #1851: schema: Upgrade path from 4.9.1.0 to 4.9.2.0

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1851 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack issue #1851: schema: Upgrade path from 4.9.1.0 to 4.9.2.0

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1851 Tested this manually. Merging this on discretion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request #1851: schema: Upgrade path from 4.9.1.0 to 4.9.2.0

GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1851 schema: Upgrade path from 4.9.1.0 to 4.9.2.0 Upgrade paths added so PRs such as #1711 can use it. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cloudstack issue #1646: [4.9/LTS] Add upgrade path from 4.9.0 to 4.9.1, chan...

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1646 Fwd-merged this to master, with db version on master fixed during merge conflict to 4.10.0.0-SNAPSHOT, and db paths fixed as 4.9.0->4.9.1->4.10.0. --- If your project is set up for it, you can

[GitHub] cloudstack issue #1646: [4.9/LTS] Add upgrade path from 4.9.0 to 4.9.1, chan...

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1646 Packaging result: ✔centos6 ✔centos7 ✔debian repo: http://packages.shapeblue.com/cloudstack/pr/1646 Job ID-100 --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack issue #1646: [4.9/LTS] Add upgrade path from 4.9.0 to 4.9.1, chan...

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1646 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request #1646: [4.9/LTS] Add upgrade path from 4.9.0 to 4.9....

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1646 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack issue #1646: [4.9/LTS] Add upgrade path from 4.9.0 to 4.9.1, chan...

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1646 Given we've enough reviews and tests (Travis) passing, I'll go ahead merge this and merge this fwd to master. On master, I'll send another PR that changes code version to 4.10.0.0-SNAPSHOT. ---

[GitHub] cloudstack issue #1646: [4.9/LTS] Add upgrade path from 4.9.0 to 4.9.1, chan...

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1646 @jburwell yes that and we can also verify from packages that the version is reflected in the pkg names. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1646: [4.9/LTS] Add upgrade path from 4.9.0 to 4.9.1, chan...

Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1646 code LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cloudstack issue #1646: [4.9/LTS] Add upgrade path from 4.9.0 to 4.9.1, chan...

Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1646 @rhtyd I understand the reasoning for two commits, and it makes sense. Since you understand the process required for the forward merge, I think it makes sense for you to perform it.

[GitHub] cloudstack issue #1646: [4.9/LTS] Add upgrade path from 4.9.0 to 4.9.1, chan...

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1646 @jburwell I've kept the changes into two commits (1) for pom.xml related version changes and (2) for db upgrade path, as when doing fwd-merging this will cause conflict with other pom files so

[GitHub] cloudstack issue #1646: [4.9/LTS] Add upgrade path from 4.9.0 to 4.9.1, chan...

Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1646 @rhtyd could you please squash the commits? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1646: [4.9/LTS] Add upgrade path from 4.9.0 to 4.9.1, chan...

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1646 Packaging result: ✔centos6 ✔centos7 ✔debian repo: http://packages.shapeblue.com/cloudstack/pr/1646 Job ID-91 --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack issue #1646: [4.9/LTS] Add upgrade path from 4.9.0 to 4.9.1, chan...

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1646 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1646: [4.9/LTS] Add upgrade path from 4.9.0 to 4.9.1, chan...

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1646 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1646: [4.9/LTS] Add upgrade path from 4.9.0 to 4.9.1

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1646 @jburwell @karuturi fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1646: [4.9/LTS] Add upgrade path from 4.9.0 to 4.9.1

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1646 @jburwell this makes sense, I'll update the PR and also fix this on master. Regarding 4.8 branch, I'm not sure so I'll ask @swill -- Will can you run setnextversion.sh on 4.8 branch to say

[GitHub] cloudstack issue #1646: [4.9/LTS] Add upgrade path from 4.9.0 to 4.9.1

Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1646 @rhtyd we are moving to four position to version numbers to support our recent security release change where the fourth position is used to reflect security patch. Therefore, the (release

[GitHub] cloudstack issue #1646: [4.9/LTS] Add upgrade path from 4.9.0 to 4.9.1

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1646 Packaging result: ✔centos6 ✔centos7 ✔debian repo: http://packages.shapeblue.com/cloudstack/pr/1646 Job ID-90 --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack issue #1646: [4.9/LTS] Add upgrade path from 4.9.0 to 4.9.1

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1646 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request #1646: [4.9/LTS] Add upgrade path from 4.9.0 to 4.9....

GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1646 [4.9/LTS] Add upgrade path from 4.9.0 to 4.9.1 This adds db upgrade path from 4.9.0 to 4.9.1 and fixes a typo in default user role description (CLOUDSTACK-9449) /cc @karuturi @jburwell

[GitHub] cloudstack pull request: engine/schema: fix upgrade path to work w...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1517 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: engine/schema: fix upgrade path to work w...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1517#issuecomment-215077801 Thanks for the validation discussion. I think this is ready... --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: engine/schema: fix upgrade path to work w...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1517#issuecomment-215038164 @rhtyd Thats right, setup will anyway do the upgrades. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: engine/schema: fix upgrade path to work w...

the upgrade path as well. Travis deployed database and is green confirms upgrade path fix does not break with existing MySQL 5.6 or less version. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: engine/schema: fix upgrade path to work w...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1517#issuecomment-215017916 Code changes LGTM. @swill The change is in upgrade code and CI won't be able to test it. So I think this can be merged. --- If your project is set up for

[GitHub] cloudstack pull request: engine/schema: fix upgrade path to work w...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1517#issuecomment-214852970 Ah, yes, I see @rhtyd ! LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: engine/schema: fix upgrade path to work w...

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1517#discussion_r61145609 --- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java --- @@ -1297,7 +1297,7 @@ private void addHostDetailsIndex(Connection conn) {

[GitHub] cloudstack pull request: engine/schema: fix upgrade path to work w...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1517#issuecomment-214734875 So what happens if the Index already exists? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: engine/schema: fix upgrade path to work w...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1517#issuecomment-214617500 @jburwell I've not tested, but if it is using/enforcing SQL99 it should fail too (or it could be mysql 5.7.4+ issue); "As of MySQL 5.7.4, the IGNORE clause

[GitHub] cloudstack pull request: engine/schema: fix upgrade path to work w...

Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1517#issuecomment-214574233 Do these instructions apply to MariaDB as well? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: engine/schema: fix upgrade path to work w...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1517#issuecomment-214229683 I found this article by Oracle MySQL team useful: https://www.digitalocean.com/community/tutorials/how-to-prepare-for-your-mysql-5-7-upgrade --- If your project is

Re: [4.6.1/4.7.0] Database upgrade path issues/forks between 4.6.0/4.6.1 and 4.7.0/master

een 4.6.0 and 4.6.1 (DB) > versions; and there exists separate DB upgrade paths from 4.6.0 to 4.7.0 > and 4.6.1 to 4.7.0 on master branch which shares the same changes. The > issue is that the upgrade path from 4.6.0 to 4.7.0 does not include the db > view related changes that exists

[GitHub] cloudstack pull request: 4.6.0 upgrade path is to pass 4.6.1 to cr...

GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/1173 4.6.0 upgrade path is to pass 4.6.1 to create the extra view in there test build done only You can merge this pull request into a Git repository by running: $ git pull https

Re: [4.6.1/4.7.0] Database upgrade path issues/forks between 4.6.0/4.6.1 and 4.7.0/master

6.1 to 4.7.0 on master branch which shares the same changes. The > issue is that the upgrade path from 4.6.0 to 4.7.0 does not include the db > view related changes that exists in the 4.6.0 to 4.6.1 upgrade path. > > While unlikely, but please share if this was done on purpose (i.e. we >

Re: [4.6.1/4.7.0] Database upgrade path issues/forks between 4.6.0/4.6.1 and 4.7.0/master

w related change between 4.6.0 and 4.6.1 (DB) versions; and there exists separate DB upgrade paths from 4.6.0 to 4.7.0 and 4.6.1 to 4.7.0 on master branch which shares the same changes. The issue is that the upgrade path from 4.6.0 to 4.7.0 does not include the db view related changes that exists in th

[GitHub] cloudstack pull request: 4.6.0 upgrade path is to pass 4.6.1 to cr...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1173#issuecomment-161929046 LGTM, thanks @DaanHoogland for fixing this so fast --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: 4.6.0 upgrade path is to pass 4.6.1 to cr...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1173#issuecomment-161929234 once merged on master, I'll rebase quota-master branch (the quota PR) with latest master and then fix it's db upgrade paths. --- If your project is set up for

[GitHub] cloudstack pull request: 4.6.0 upgrade path is to pass 4.6.1 to cr...

Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1173#issuecomment-161987586 LGTM by code review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: 4.6.0 upgrade path is to pass 4.6.1 to cr...

Github user ustcweizhou commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1173#discussion_r46694480 --- Diff: setup/db/db/schema-460to470.sql --- @@ -1,32 +0,0 @@ --- Licensed to the Apache Software Foundation (ASF) under one --- or more

[GitHub] cloudstack pull request: 4.6.0 upgrade path is to pass 4.6.1 to cr...

Github user pdube commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1173#discussion_r46685020 --- Diff: setup/db/db/schema-460to470.sql --- @@ -1,32 +0,0 @@ --- Licensed to the Apache Software Foundation (ASF) under one --- or more

[GitHub] cloudstack pull request: 4.6.0 upgrade path is to pass 4.6.1 to cr...

Github user ustcweizhou commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1173#discussion_r46686423 --- Diff: setup/db/db/schema-460to470.sql --- @@ -1,32 +0,0 @@ --- Licensed to the Apache Software Foundation (ASF) under one --- or more

[GitHub] cloudstack pull request: 4.6.0 upgrade path is to pass 4.6.1 to cr...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1173#discussion_r46687151 --- Diff: setup/db/db/schema-460to470.sql --- @@ -1,32 +0,0 @@ --- Licensed to the Apache Software Foundation (ASF) under one --- or more

[GitHub] cloudstack pull request: 4.6.0 upgrade path is to pass 4.6.1 to cr...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1173#issuecomment-162030722 Merging now, that we've enough LGTMs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: 4.6.0 upgrade path is to pass 4.6.1 to cr...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1173 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: 4.6.0 upgrade path is to pass 4.6.1 to cr...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1173#discussion_r46698656 --- Diff: setup/db/db/schema-460to470.sql --- @@ -1,32 +0,0 @@ --- Licensed to the Apache Software Foundation (ASF) under one --- or more

[4.6.1/4.7.0] Database upgrade path issues/forks between 4.6.0/4.6.1 and 4.7.0/master

There seems to be a db view related change between 4.6.0 and 4.6.1 (DB) versions; and there exists separate DB upgrade paths from 4.6.0 to 4.7.0 and 4.6.1 to 4.7.0 on master branch which shares the same changes. The issue is that the upgrade path from 4.6.0 to 4.7.0 does not include the db view

[GitHub] cloudstack pull request: implemented upgrade path from 4.6.0 to 4....

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1067#issuecomment-156813885 merged with 4.6 branch and: ``` INFO [c.c.s.ManagementServerImpl] (main:ctx-1c73e37e) Startup CloudStack management server... INFO

[GitHub] cloudstack pull request: implemented upgrade path from 4.6.0 to 4....

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1067#issuecomment-156820839 This is an upgrade from 4.6.0 to 4.6.1: ``` INFO [o.a.c.s.l.CloudStackExtendedLifeCycle] (main:null) Running system integrity checker

[GitHub] cloudstack pull request: implemented upgrade path from 4.6.0 to 4....

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1067#issuecomment-156821756 so, you have my lgtm, need a second one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: implemented upgrade path from 4.6.0 to 4....

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1067#issuecomment-156812719 @DaanHoogland I rebased it, as it needs the `checkstyle` fix in 4.6. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: implemented upgrade path from 4.6.0 to 4....

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1067#issuecomment-156821894 Yes, let's stick to the rules :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: implemented upgrade path from 4.6.0 to 4....

GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1067 implemented upgrade path from 4.6.0 to 4.6.1 The 4.6 branch needs an upgrade path to 4.6.1. I looked at how this was done before and think this will do. Can you give it a second pair

[GitHub] cloudstack pull request: implemented upgrade path from 4.6.0 to 4....

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1067#issuecomment-156810107 looks good, let's run a test anyway. the jenkins should run it but it it's running on a INFRA-10703 host so it will most likely fail. --- If your project is

[GitHub] cloudstack pull request: implement upgrade path from 4.6.0 to 4.6....

Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/1067#issuecomment-156846865 LGTM Works on my test deployment. 2015-11-15 19:52:41,711 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) Cleanup script

[GitHub] cloudstack pull request: implement upgrade path from 4.6.0 to 4.6....

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1067 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-9046 - Fix upgrade path from 4...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1050#discussion_r44281597 --- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade452to460.java --- @@ -165,4 +171,173 @@ private void addIndexForVMInstance(Connection conn)

[GitHub] cloudstack pull request: CLOUDSTACK-9046 - Fix upgrade path from 4...

Github user wilderrodrigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1050#discussion_r44281769 --- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade452to460.java --- @@ -165,4 +171,173 @@ private void addIndexForVMInstance(Connection

[GitHub] cloudstack pull request: CLOUDSTACK-9046 - Fix upgrade path from 4...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1050#discussion_r44281795 --- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade452to460.java --- @@ -165,4 +171,173 @@ private void addIndexForVMInstance(Connection conn)

  1   2   >