Re: Set Number of queues for Virtio NIC driver to vCPU count?

2021-12-09 Thread Greg Goodrich
the network performance of our KVM/QEMU VMs running in CloudStack. One thing we noticed is that the Virtio NICs are not configured to use multiple queues. A couple of years ago someone created a PR to increase the Virtio SCSI queue count to match the number of vCPUs: https://github.com/apache/cloudstack/pull/3101

RE: Set Number of queues for Virtio NIC driver to vCPU count?

2021-03-24 Thread Sean Lair
Thanks for the reply guys. We'll start looking more into this! Sean -Original Message- From: Rohit Yadav Sent: Wednesday, March 24, 2021 7:28 AM To: dev@cloudstack.apache.org Cc: Sean Lair Subject: [DKIM Fail] Re: Set Number of queues for Virtio NIC driver to vCPU count? Hi Sean

Re: Set Number of queues for Virtio NIC driver to vCPU count?

2021-03-24 Thread Rohit Yadav
Subject: Re: Set Number of queues for Virtio NIC driver to vCPU count? +1 It's a great idea which is implemented already on some of the other platforms. It can make a big difference when pushing a lot of traffic, such as VoIP etc. Hope it gets implemented. Lucian On 2021-03-23 23:08, Sean Lair

Re: Set Number of queues for Virtio NIC driver to vCPU count?

2021-03-24 Thread nux
of our KVM/QEMU VMs running in CloudStack. One thing we noticed is that the Virtio NICs are not configured to use multiple queues. A couple of years ago someone created a PR to increase the Virtio SCSI queue count to match the number of vCPUs: https://github.com/apache/cloudstack/pull/3101

Set Number of queues for Virtio NIC driver to vCPU count?

2021-03-23 Thread Sean Lair
Hi all, We are looking to improve the network performance of our KVM/QEMU VMs running in CloudStack. One thing we noticed is that the Virtio NICs are not configured to use multiple queues. A couple of years ago someone created a PR to increase the Virtio SCSI queue count to match the number

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-03-27 Thread wido
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1955 Yes, we are indeed ready for a merge. Shall we do that? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-03-13 Thread kiwiflyer
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1955 @karuturi 3 x LGTM, testing successful. Ready for Merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-03-12 Thread wido
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1955 LGTM from the code --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-03-11 Thread nathanejohnson
Github user nathanejohnson commented on the issue: https://github.com/apache/cloudstack/pull/1955 I just re-depoyed and re-ran the test: Test that libvirt properly created domain with scsi controller ... === TestName: test_01_verify_libvirt | Status : SUCCESS ===

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-03-11 Thread wido
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1955 @nathanejohnson: Good! I would like to see that being enums. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-03-11 Thread nathanejohnson
Github user nathanejohnson commented on the issue: https://github.com/apache/cloudstack/pull/1955 @wido Actually I was just about to push a commit that changed the string to enum, but builds are failing locally because of this test:

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-03-11 Thread wido
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1955 Do we want to pass the unmap not as a string? Shouldn't that be a enum? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-03-10 Thread nathanejohnson
Github user nathanejohnson commented on the issue: https://github.com/apache/cloudstack/pull/1955 @wido I have removed all of the debug logging statements that didn't exist before I touched the code, I have also added the discard option to the disks. --- If your project is set up

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-03-10 Thread wido
. In addition, I would like to see discard/unmap enabled by default for Virtio-SCSI disks: https://blog.widodh.nl/2015/12/using-trimdiscard-with-ceph-rbd-and-libvirt/ This will also allow for QCOW2 and RBD trimming. --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-03-10 Thread kiwiflyer
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1955 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-03-09 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1955 Trillian test result (tid-938) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 34569 seconds Marvin logs:

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-03-09 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1955 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-03-09 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1955 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-03-09 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1955 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-577 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-03-09 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1955 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-03-09 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1955 @nathanejohnson sure, sorry I've missed your comment about the test fix earlier. @blueorangutan package --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-03-08 Thread nathanejohnson
Github user nathanejohnson commented on the issue: https://github.com/apache/cloudstack/pull/1955 @borisstoyanov Whenever you get a second could you kick off a blue orangutan smoke test? I believe I have fixed the issue with ssh'ing into the KVM hosts, I sue the IP now instead of

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-03-06 Thread nathanejohnson
, and there was even some code that inspected this in the kvm plugin. With this latest commit, it will actually honor either OS type "Other PV Virtio-SCSI" or rootDiskController passed in via details, with details overriding OS type. I also made a minor tweak to the UI to allow setting the root di

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-03-06 Thread nathanejohnson
Github user nathanejohnson commented on the issue: https://github.com/apache/cloudstack/pull/1955 @borisstoyanov I have reworked the test so that it should now use the host IP versus the hostname. Could you please re-run the blue orangutan test? Thank you! --- If your project is

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-03-04 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1955 I think that's the issue at our environment, it's trying to ssh via hostname instead of IP. Can you change that to IP please @nathanejohnson ? `Trying SSH Connection:

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-03-02 Thread remibergsma
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1955 Tested it manually, works great. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-03-02 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1955 Thanks @nathanejohnson I will have a look --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-03-01 Thread nathanejohnson
Github user nathanejohnson commented on the issue: https://github.com/apache/cloudstack/pull/1955 @borisstoyanov so the good news is it didn't skip the test. the bad news is it didn't seem to have proper credentials for ssh'ing into your hosts. It did pass the test where it ssh'ed

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-03-01 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1955 Trillian test result (tid-921) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 36820 seconds Marvin logs:

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-03-01 Thread nathanejohnson
Github user nathanejohnson commented on the issue: https://github.com/apache/cloudstack/pull/1955 @borisstoyanov Quick questions, what tags need to be present to get picked up by BO? I'm worried my smoke test might get skipped. --- If your project is set up for it, you can reply to

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-03-01 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1955 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-03-01 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1955 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-03-01 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1955 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-552 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-03-01 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1955 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-03-01 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1955 Thanks @nathanejohnson, lets run that with BO @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-03-01 Thread nathanejohnson
Github user nathanejohnson commented on the issue: https://github.com/apache/cloudstack/pull/1955 @wido I have removed the extraneous log messages. @boris I have added a smoke test for this that tests both virsh output from the host and lspci / lsblk output from the guest.

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-02-24 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1955 @nathanejohnson thank you, let me know when you're done with the changes so I could kick in smoke tests. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-02-23 Thread nathanejohnson
Github user nathanejohnson commented on the issue: https://github.com/apache/cloudstack/pull/1955 As an update, I'm working on a Marvin test, and I'm also planning to address wido's concerns. Today had many distractions unfortunately. --- If your project is set up for it, you can

[GitHub] cloudstack pull request #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for K...

2017-02-23 Thread wido
() returns null we fall back to getSpeed(). final InputDef input = new InputDef("tablet", "usb"); devices.addDevice(input); + // If we're using virtio scsi, then we need to add a virtual scsi controller +if (getGuestDiskModel(vmTO

[GitHub] cloudstack pull request #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for K...

2017-02-23 Thread wido
Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1955#discussion_r102687113 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java --- @@ -2158,6 +2166,7 @@ public int compare(final

[GitHub] cloudstack pull request #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for K...

2017-02-23 Thread wido
Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1955#discussion_r102687170 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java --- @@ -2216,6 +2225,8 @@ public int compare(final

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-02-23 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1955 @nathanejohnson Thanks, for this good enhancement. Can we have a marvin tests that covers the new functionality? --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-02-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1955 Trillian test result (tid-878) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 32944 seconds Marvin logs:

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-02-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1955 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-02-22 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1955 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-02-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1955 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-522 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-02-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1955 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-02-22 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1955 Thanks for this PR @nathanejohnson, I will build it and run smoketests agains it. @blueorangutan package --- If your project is set up for it, you can reply to this email and have

Re: Adding VirtIO SCSI to KVM hypervisors

2017-02-21 Thread Nathan Johnson
;: >>>> >>>> >>>> Maybe this is a good opportunity to discuss modernizing the OS >>>> selections so that drivers (and other features) could be selectable per >>>> OS. >>> >>> That seems like a good idea. If you select Ub

Re: Adding VirtIO SCSI to KVM hypervisors

2017-02-21 Thread Sergey Levitskiy
this is a good opportunity to discuss modernizing the OS >>> selections so that drivers (and other features) could be selectable per >>> OS. >> >> That seems like a good idea. If you select Ubuntu 16.04 or CentOS 7.3 >&g

Re: Adding VirtIO SCSI to KVM hypervisors

2017-02-21 Thread Nathan Johnson
ena.com> wrote: >> >> Wido den Hollander <w...@widodh.nl> wrote: >> >>>> Op 25 januari 2017 om 4:44 schreef Simon Weller <swel...@ena.com>: >>>> >>>> >>>> Maybe this is a good opportunity to discuss modernizing th

Re: Adding VirtIO SCSI to KVM hypervisors

2017-02-21 Thread Sergey Levitskiy
;> >>> Maybe this is a good opportunity to discuss modernizing the OS >>> selections so that drivers (and other features) could be selectable per >>> OS. >> >> That seems like a good idea. If you select Ubuntu 16.04 or C

Re: Adding VirtIO SCSI to KVM hypervisors

2017-02-21 Thread Nathan Johnson
gt; Maybe this is a good opportunity to discuss modernizing the OS >>> selections so that drivers (and other features) could be selectable per >>> OS. >> >> That seems like a good idea. If you select Ubuntu 16.04 or CentOS 7.3 >> then for example it will give you a VirtIO SC

Re: Adding VirtIO SCSI to KVM hypervisors

2017-02-21 Thread Sergey Levitskiy
Maybe this is a good opportunity to discuss modernizing the OS >> selections so that drivers (and other features) could be selectable per >> OS. > > That seems like a good idea. If you select Ubuntu 16.04 or CentOS 7.3 > then for example it will give you a Vi

Re: Adding VirtIO SCSI to KVM hypervisors

2017-02-21 Thread Nathan Johnson
e selectable per >> OS. > > That seems like a good idea. If you select Ubuntu 16.04 or CentOS 7.3 > then for example it will give you a VirtIO SCSI disk on KVM, anything > previous to that will get VirtIO-blk. So one thing I noticed, there is a possibility of a rootDiskCon

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-02-21 Thread dmabry
Github user dmabry commented on the issue: https://github.com/apache/cloudstack/pull/1955 We are deploying this to our QA environment right now and hope to have it tested in a few days. Great work @kiwiflyer and @nathanejohnson. --- If your project is set up for it, you can reply

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-02-21 Thread wido
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1955 Very nice indeed! I will take a look asap. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-02-20 Thread remibergsma
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1955 Nice work @kiwiflyer @dmabry, thanks! Will give it a go soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-02-20 Thread kiwiflyer
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1955 @remibergsma @ustcweizhou This might be of interest to you guys as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for K...

2017-02-20 Thread nathanejohnson
GitHub user nathanejohnson opened a pull request: https://github.com/apache/cloudstack/pull/1955 CLOUDSTACK-8239 Add VirtIO SCSI support for KVM hosts This is an initial implementation that we have working in the lab. ![devmanagerscreenshot](https

Re: Adding VirtIO SCSI to KVM hypervisors

2017-01-24 Thread Wido den Hollander
untu 16.04 or CentOS 7.3 then for example it will give you a VirtIO SCSI disk on KVM, anything previous to that will get VirtIO-blk. Wido > > Thoughts? > > > > From: Syed Ahmed <sah...@cloudops.com> > Sent: Tuesday, January 24, 2017 1

Re: Adding VirtIO SCSI to KVM hypervisors

2017-01-24 Thread Simon Weller
he.org Cc: Simon Weller Subject: Re: Adding VirtIO SCSI to KVM hypervisors To maintain backward compatibility we would have to add a config option here unfortunately. I do like the idea however. We can make the default VirtIO ISCSI and keep the VirtIO-blk as an alternative for existing install

Re: Adding VirtIO SCSI to KVM hypervisors

2017-01-24 Thread Syed Ahmed
To maintain backward compatibility we would have to add a config option here unfortunately. I do like the idea however. We can make the default VirtIO ISCSI and keep the VirtIO-blk as an alternative for existing installations. On Mon, Jan 23, 2017 at 8:05 AM, Wido den Hollander <w...@widodh

Re: Adding VirtIO SCSI to KVM hypervisors

2017-01-23 Thread Wido den Hollander
ut it can definitely be added as > > a cluster-wide or a global setting in my opinion. By enabling that, all the > > instances would be using VirtIO SCSI. Is there a reason you'd want some > > instances to use VirtIIO and others to use VirtIO SCSI? > > > > Even a global setti

Re: Adding VirtIO SCSI to KVM hypervisors

2017-01-21 Thread Wido den Hollander
> Op 21 jan. 2017 om 22:59 heeft Syed Ahmed <sah...@cloudops.com> het volgende > geschreven: > > Exposing this via an API would be tricky but it can definitely be added as > a cluster-wide or a global setting in my opinion. By enabling that, all the > instances wo

RE: Adding VirtIO SCSI to KVM hypervisors

2017-01-21 Thread Simon Weller
@cloudstack.apache.org] Subject: Re: Adding VirtIO SCSI to KVM hypervisors Exposing this via an API would be tricky but it can definitely be added as a cluster-wide or a global setting in my opinion. By enabling that, all the instances would be using VirtIO SCSI. Is there a reason you'd want some instances to use

Re: Adding VirtIO SCSI to KVM hypervisors

2017-01-21 Thread Syed Ahmed
Exposing this via an API would be tricky but it can definitely be added as a cluster-wide or a global setting in my opinion. By enabling that, all the instances would be using VirtIO SCSI. Is there a reason you'd want some instances to use VirtIIO and others to use VirtIO SCSI? On Sat, Jan 21

RE: Adding VirtIO SCSI to KVM hypervisors

2017-01-21 Thread Simon Weller
For the record, we've been looking into this as well. Has anyone tried it with Windows VMs before? The standard virtio driver doesn't support spanned disks and that's something we'd really like to enable for our customers. Simon Weller/615-312-6068 -Original Message- From: Wido den

Re: Adding VirtIO SCSI to KVM hypervisors

2017-01-21 Thread Wido den Hollander
y. We don't have any structure for this in place right now to define what type of driver/disk we present to a guest. See my answer below. > Thanks, > -Syed > On Sat, Jan 21, 2017 at 04:46 Laszlo Hornyak <laszlo.horn...@gmail.com> > wrote: > > > Hi Wido, > > > > If I

Re: Adding VirtIO SCSI to KVM hypervisors

2017-01-21 Thread Syed Ahmed
correctly from the documentation and your examples, virtio > provides virtio interface to the guest while virtio-scsi provides scsi > interface, therefore an IaaS service should not replace it without user > request / approval. It would be probably better to let the user set what > kind o

Re: Adding VirtIO SCSI to KVM hypervisors

2017-01-21 Thread Laszlo Hornyak
Hi Wido, If I understand correctly from the documentation and your examples, virtio provides virtio interface to the guest while virtio-scsi provides scsi interface, therefore an IaaS service should not replace it without user request / approval. It would be probably better to let the user set

Adding VirtIO SCSI to KVM hypervisors

2017-01-20 Thread Wido den Hollander
Hi, VirtIO SCSI [0] has been supported a while now by Linux and all kernels, but inside CloudStack we are not using it. There is a issue for this [1]. It would bring more (theoretical) performance to VMs, but one of the motivators (for me) is that we can support TRIM/DISCARD [2]. This would

[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...

2016-10-19 Thread wido
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1572 @mlsorensen We can indeed do that, but the good thing for now is that the RNG is disabled by default. You also need a very ancient libvirt for it not to support RNG and that will get less

[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...

2016-10-19 Thread mlsorensen
Github user mlsorensen commented on the issue: https://github.com/apache/cloudstack/pull/1572 I realize I'm late to the party on this, but I'd like to suggest that we change from the agent.properties "vm.rng.enable=true" to simply using the libvirt version detection like we do for

[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...

2016-10-13 Thread karuturi
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1572 @rhtyd my point is that, even if its run on KVM, this functionality wont be covered with existing tests. I agree to your point. It was just that I had xen tests available and another run on

[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...

2016-10-13 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1572 @karuturi I think it beats the purpose of smoke tests if we don't run them against the hypervisor(s) the PR/change is most likely related to. Without valid test results it is hard to validate a

[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...

2016-10-13 Thread karuturi
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1572 1. the current set of integration tests doesnt test the new functionality added in this PR. Its merely a check to see nothing else is broken. 2. when did we freeze? I skimmed through the

[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...

2016-10-13 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1572 @karuturi am I missing the test results on this PR for the enhancements? All I see are tests against XenServer which have no bearing on this change. Why was this PR merged without a full

[GitHub] cloudstack pull request #1572: CLOUDSTACK-9395: Add Virtio RNG device to Ins...

2016-10-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1572 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...

2016-10-13 Thread karuturi
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1572 code LGTM 👍 from @ustcweizhou and there are test runs I am merging this now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...

2016-09-07 Thread wido
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1572 Can I get a review on this one so it can be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

Re: Virtio vs IDE emulation, per OS - where is this info ?

2016-08-25 Thread Andrija Panic
Hi Simon, thanks a lot for this info - but I'm not sure if this is complete list ? For example: "Windows PV" is present in DB etc, but it's not here in the code you sent (Windows PV = virtio hardware, other Windows X = ide/intel) Do I miss something - I tried to crosscheck D

Re: Virtio vs IDE emulation, per OS - where is this info ?

2016-08-24 Thread Simon Weller
From: Andrija Panic <andrija.pa...@gmail.com> Sent: Wednesday, August 24, 2016 9:39 AM To: dev@cloudstack.apache.org Subject: Virtio vs IDE emulation, per OS - where is this info ? Hi all, Im trying to build the simple table for our support guys, which O

Virtio vs IDE emulation, per OS - where is this info ?

2016-08-24 Thread Andrija Panic
Hi all, Im trying to build the simple table for our support guys, which OS type (as seen in ACS) is virtio emualted, and which is IDE/Intel emulation. I dont seem to find this in DB, except the list of OS types, families etc. Can someone give some info, where should I find if OS is supposed

[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...

2016-07-12 Thread wido
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1572 No LGTM on this one yet. Are we good @ustcweizhou and @remibergsma ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...

2016-06-20 Thread bvbharatk
Github user bvbharatk commented on the issue: https://github.com/apache/cloudstack/pull/1572 ### ACS CI BVT Run **Sumarry:** Build Number 203 Hypervisor xenserver NetworkType Advanced Passed=71 Failed=2 Skipped=3 _Link to logs Folder (search

[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...

2016-06-08 Thread wido
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1572 Did you get a chance to take a look @remibergsma ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...

2016-06-06 Thread remibergsma
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1572 Thanks @wido will have a look --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...

2016-06-06 Thread wido
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1572 Ok, thanks @ustcweizhou . Could you take a technical look and see if you LGTM? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...

2016-06-06 Thread ustcweizhou
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1572 @wido thanks. it sound fine to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...

2016-06-06 Thread wido
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1572 @remibergsma: Could you check again? You can now set the rate with period and bytes to prevent exhaustion. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...

2016-06-06 Thread wido
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1572 @ustcweizhou Using 'vm.rng.enable=true' you can enable or disable the RNG. This controls if the XML is generated or not. This is set to false by default, so it will work on Ubuntu 12.04

[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...

2016-06-06 Thread ustcweizhou
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1572 @wido , thanks for your reply. As I know, there are still many people using Ubuntu 12.04. Especially for one starting using CloudStack/Ubuntu 2-3 years ago ( before Ubuntu 14.04 release),

[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...

2016-06-06 Thread wido
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1572 Yes, valid point @remibergsma , see: https://libvirt.org/formatdomain.html#elementsRng I'll add support so that you can configure: `` `` That way you can prevent

[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...

2016-06-04 Thread wido
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1572 @wido Thanks for the feature, I like it! Although I'm a bit worried that many VMs could potentially exhaust the hypervisor's `/dev/random`? How do you handle that? --- If your project is set up

[GitHub] cloudstack pull request: CLOUDSTACK-9395: Add Virtio RNG device to...

2016-05-31 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1572#issuecomment-222612848 @ustcweizhou: You need at least libvirt 1.0.3. Ubuntu 14.04 contains Libvirt 1.2.2, so with that hypervisor you are fine. --- If your project is set up for it, you

[GitHub] cloudstack pull request: CLOUDSTACK-9395: Add Virtio RNG device to...

2016-05-31 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/1572#issuecomment-222611860 @wido what is the minimum of qemu/libvirt version this require? maybe better to add some version check ? --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: CLOUDSTACK-9395: Add Virtio RNG device to...

2016-05-30 Thread wido
GitHub user wido opened a pull request: https://github.com/apache/cloudstack/pull/1572 CLOUDSTACK-9395: Add Virtio RNG device to Instances when configured By adding a Random Number Generator device to Instances we can prevent entropy starvation inside guest. The default

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

2016-05-13 Thread wido
Github user wido closed the pull request at: https://github.com/apache/cloudstack/pull/985 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

2016-05-13 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-218998186 Closing this one in favor of #1545 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

  1   2   >