Jenkins build is back to normal : build-4.5 #508

See

Jenkins build is back to normal : build-master-jdk18 #274

See

[GitHub] cloudstack pull request: CLOUDSTACK-8725 RVR functionality is brok...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/692#discussion_r37056270 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsRedundant.py --- @@ -96,7 +96,7 @@ def _redundant_on(self): d = s.rep

Re: [DISCUSS] CloudStack 4.5.2 RC and CloudMonkey 5.3.2 RC

Hi all, Just to update, all major pending important/security patches from my side have been applied, I’ll shortly start with a RC just to kickstart the testing process after triaging bugs on JIRA and given that there are no blockers reported on 4.5.x. I’m sure we may discover more bugs so we m

Build failed in Jenkins: build-4.5 #509

See Changes: [Rohit Yadav] CLOUDSTACK-8696: Port Rajani's regions fix to 451to452 sql upgrade path [Rohit Yadav] BUG-ID:CLOUDSTACK-7472: kvmclock fix for LXC is not required after fixing CLOUDSTACK-8177 ---

[GitHub] cloudstack pull request: Fix site-to-site VPN feature

GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/693 Fix site-to-site VPN feature This is work done together with @Jayapal on fixing the site2site VPN. The first part was done in PR #690 by @Jayapal. On top of that, some other fixes were need

[VOTE] Apache Cloudstack 4.5.2

Hi All, I've created a 4.5.2 release, with the following artifacts up for a vote: Git Branch and Commit SH: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.5-RC20150814T1334 Commit: caa411305a76bb9aac66600853a8193294874a1b Tag: 4.5.2-rc1 List of changes: https:

Re: [DISCUSS] CloudStack 4.5.2 RC and CloudMonkey 5.3.2 RC

Hello, If anyone can be check for the second LGTM on theses PR before the next 4.5 RC: https://github.com/apache/cloudstack/pull/687 (missing localization on CS45 web ui) https://github.com/apache/cloudstack/pull/676 (just change a debug message for more informative scheduler when its prep

[GitHub] cloudstack pull request: CLOUDSTACK-8710: Fixed applying iptables ...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/690#issuecomment-131016340 @jayapalu Please see PR #693, I went ahead and included your work there. Please let me know if this is OK with you. I included the exact same commit from this PR

[GitHub] cloudstack pull request: Fix site-to-site VPN feature

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/693#issuecomment-131019303 no furhter comments, LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] cloudstack pull request: Fix site-to-site VPN feature

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/693#discussion_r37057824 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsFile.py --- @@ -114,7 +114,10 @@ def greplace(self, search, replace): def s

Re: [DISCUSS] CloudStack 4.5.2 RC and CloudMonkey 5.3.2 RC

Too late... On 14/08/2015 09:19, Milamber wrote: Hello, If anyone can be check for the second LGTM on theses PR before the next 4.5 RC: https://github.com/apache/cloudstack/pull/687 (missing localization on CS45 web ui) https://github.com/apache/cloudstack/pull/676 (just change a debug

[GitHub] cloudstack pull request: CLOUDSTACK-8687: Prepare template only on...

Github user devdeep commented on the pull request: https://github.com/apache/cloudstack/pull/635#issuecomment-131020409 Added another test to validate the prepareTemplate function. Looked into if it was possible to mock the threadpool executor service in templatemanagerimpl. However,

[GitHub] cloudstack pull request: Fix site-to-site VPN feature

Github user jayapal commented on the pull request: https://github.com/apache/cloudstack/pull/693#issuecomment-131026551 Guys wrong tag. Myuser name is jayapal and actual commiter was jayapalu On Fri, Aug 14, 2015 at 1:47 PM, Remi Bergsma wrote: > This is

Re: [DISCUSS] CloudStack 4.5.2 RC and CloudMonkey 5.3.2 RC

Hi Milamber, Your effort is not wasted, we’ll merge them on 4.5. The first RC (4.5.2-rc1) was created just to get the release process started. Historically we never done any ACS release with the first RC itself. I’m guessing we’ll see some bug reports pretty soon and we’ll need to do rc2, rc3 e

[GitHub] cloudstack pull request: Fix site-to-site VPN feature

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/693#issuecomment-131027193 @jayapal Sorry for bothering you, just updated the tag. Thanks for letting me know! --- If your project is set up for it, you can reply to this email and have y

[GitHub] cloudstack pull request: [CS45] Add missing localization for some ...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/687#issuecomment-131028291 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cloudstack pull request: [CS45] Add missing localization for some ...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/687#issuecomment-131028521 @milamberspace thanks, merged on 4.5; since this is a non-master branch you'll have to close the PR manually. Also, do we want to port this to master? --- If your

[GitHub] cloudstack pull request: Improve debug message when the scheduler ...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/676#issuecomment-131028549 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] cloudstack pull request: Improve debug message when the scheduler ...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/676 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: [CS45] Add missing localization for some ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/687#issuecomment-131029374 @bhaisaab if you merge, preserving the commit-ids github will close this PR regardless of the branch it was merged to. --- If your project is set up for it, yo

Re: [SHARE] VM migrations failing with Ubuntu 14.04.3

On 13-08-15 14:06, Rohit Yadav wrote: > Hi all, > > I’ve been testing a bug on KVM which involves VM migration, and in that > process I found that VM migrations failed in my environment twice even > with clean setups of Ubuntu 14.04.3 (lastest and updated packages) based > KVM hosts against Clou

[GitHub] cloudstack pull request: [CS45] Add missing localization for some ...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/687#issuecomment-131030116 @DaanHoogland cool, will try that in future --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: Interface changes related to CLOUDSTACK-8...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/680#issuecomment-131030262 Code looks good to me, but I see there are still some outstanding comments? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: CLOUDSTACK-8677: Call-home functionality ...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/625#issuecomment-131030515 I have create a issue regarding the new Gson version: https://issues.apache.org/jira/browse/CLOUDSTACK-8708 --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: get rid of useless out-of-band alerts

GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/694 get rid of useless out-of-band alerts These alerts are generating a lot of false positives. Try spinning a new router, or migrate one using the API (not out-of-band) and you'll get al

[GitHub] cloudstack pull request: get rid of useless out-of-band alerts

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/694#issuecomment-131031689 I'd rather see some stricter selection on what is alerted then removal of the alerts altogether. --- If your project is set up for it, you can reply to this em

[GitHub] cloudstack pull request: get rid of useless out-of-band alerts

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/694#issuecomment-131031819 @remibergsma As per discussion in dev list, based on the persistent VR changes, reboot/alert is no longer required in case of out of band VR migration. So the en

[GitHub] cloudstack pull request: get rid of useless out-of-band alerts

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/694#issuecomment-131032242 @koushik-das Check. Can you please help doing that? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] cloudstack pull request: Interface changes related to CLOUDSTACK-8...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/680#issuecomment-131032218 @wido my comments we're on outdated code. I will have another look --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: Interface changes related to CLOUDSTACK-8...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/680#discussion_r37060382 --- Diff: server/src/com/cloud/server/ManagementServerImpl.java --- @@ -3378,6 +3379,10 @@ private String signRequest(final String request, final Str

[GitHub] cloudstack pull request: Interface changes related to CLOUDSTACK-8...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/680#discussion_r37060434 --- Diff: ui/scripts/cloudStack.js --- @@ -143,8 +143,11 @@ if (json.listcapabilitiesresponse.capability.userpublictempl

[GitHub] cloudstack pull request: Interface changes related to CLOUDSTACK-8...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/680#issuecomment-131033140 code LGTM, less comment is better in this case but I'll settle. --- If your project is set up for it, you can reply to this email and have your reply appear on

[VOTE] Release Apache CloudStack CloudMonkey 5.3.2

Hi All, I've created a 5.3.2 release of CloudMonkey, with the following artifacts up for a vote: Git Branch and Commit SH: https://git-wip-us.apache.org/repos/asf?p=cloudstack-cloudmonkey.git;a=shortlog;h=refs/heads/master Commit: 1bc53d20349b6bae4ae4432e7cb6c6261c1dd290 List of changes: https:/

Re: [SHARE] VM migrations failing with Ubuntu 14.04.3

Hi, On 14-Aug-2015, at 2:19 pm, Wido den Hollander mailto:[email protected]>> wrote: Have you disabled AppArmor on that machine? We've seen many machines with random weird issues when AppArmor was enabled. I remember disabling apparmor before the upgrade, but did not check if the upgrade re-enabl

[GitHub] cloudstack pull request: Interface changes related to CLOUDSTACK-8...

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/680#issuecomment-131036175 @wido @DaanHoogland Removed last comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] cloudstack pull request: tool to aid db comaprision for upgrade te...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/188#issuecomment-131039138 Was this merge on master? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] cloudstack pull request: CLOUDSTACK-8669: create volume failed due...

GitHub user karuturi opened a pull request: https://github.com/apache/cloudstack/pull/695 CLOUDSTACK-8669: create volume failed due to null charset Added a new private method getCharSetFromConnection() which checks if the connection charset is null and if it is null, returns

enabling SAML2 plugin Cloudstack 4.5.1

Hello! How SAML plugin can be configured to SSO to the Cloudstack Instance. I've set up my Demo stand, according to this article: http://cloudstack-administration.readthedocs.org/en/latest/accounts.html#using-a-saml-2-0-identity-provider-for-user-authentication The issue is that Identity provid

[GitHub] cloudstack pull request: get rid of useless out-of-band alerts

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/694#issuecomment-131040736 @remibergsma In the middle of another thing, can help with it possibly by next week. Let me know if that is ok? Basically all code in postStateTransitionEvent()

Build failed in Jenkins: build-4.5 #510

See Changes: [Rohit Yadav] tools: fix build_asf.sh release script to remove -SNAPSHOT from bunch of files [Rohit Yadav] Add missing localization for some labels in Web UI - on the zone configuration wizard for the "Next" button - on te

Build failed in Jenkins: simulator-4.5-singlerun #259

See -- Started by upstream project "build-4.5-simulator" build number 314 originally caused by: Started by upstream project "build-4.5" build number 508 originally caused by: Started by an

[GitHub] cloudstack pull request: [CS45] Add missing localization for some ...

Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/687#issuecomment-131043213 @bhaisaab Thanks for LGTM (Daan too) The PR for fix the master is here: (#686) https://github.com/apache/cloudstack/pull/686 Need a second

[GitHub] cloudstack pull request: get rid of useless out-of-band alerts

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/694#issuecomment-131044568 @koushik-das Sure, this is not urgent. We'll have a look next week :-) Closing this PR. --- If your project is set up for it, you can reply to this emai

[GitHub] cloudstack pull request: get rid of useless out-of-band alerts

Github user remibergsma closed the pull request at: https://github.com/apache/cloudstack/pull/694 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

Re: [VOTE] Apache Cloudstack 4.5.2

For convenience here is a repository built out of this RC: http://packages.shapeblue.com/cloudstack/testing/4.5.2-rc1/ And, the new systemvm templates: http://packages.shapeblue.com/systemvmtemplate/4.5/4.5.2/ On 14-Aug-2015, at 1:49 pm, Rohit Yadav mailto:[email protected]>> wrote: Hi All,

[GitHub] cloudstack pull request: Interface changes related to CLOUDSTACK-8...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/680#issuecomment-131050116 @borisroman Great, looks like we're ready to go. I'll wait for Travis to turn green and then merge. --- If your project is set up for it, you can reply to this

Re: enabling SAML2 plugin Cloudstack 4.5.1

On 14-Aug-2015, at 2:51 pm, Artjoms Petrovs mailto:[email protected]>> wrote: I’ve set up my Demo stand, according to this article: http://cloudstack-administration.readthedocs.org/en/latest/accounts.html#using-a-saml-2-0-identity-provider-for-user-authentication The issue is that Iden

[GitHub] cloudstack pull request: Interface changes related to CLOUDSTACK-8...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/680 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: [VOTE] Apache Cloudstack 4.5.2

+1 Based on our own production cloud which runs 4.5.2 already build from Git. Wido On 14-08-15 10:19, Rohit Yadav wrote: > Hi All, > > I've created a 4.5.2 release, with the following artifacts up for a vote: > > Git Branch and Commit SH: > https://git-wip-us.apache.org/repos/asf?p=cloudstack.

Re: [VOTE] Release Apache CloudStack CloudMonkey 5.3.2

+1 (binding) Compiled, installed and did some basic testing. Then run some dev/test scripts to deploy test infra with cloudmonkey and that all works fine. > On 14 Aug 2015, at 11:08, Rohit Yadav wrote: > > Hi All, > > I've created a 5.3.2 release of CloudMonkey, with the following > artifacts

[GitHub] cloudstack pull request: Fix site-to-site VPN feature

Github user jayapalu commented on the pull request: https://github.com/apache/cloudstack/pull/693#issuecomment-131078443 The iptables rules and vpn config changes are looking good. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-8710: Fixed applying iptables ...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/690 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Fix site-to-site VPN feature

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/693 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: [VOTE] Release Apache CloudStack CloudMonkey 5.3.2

+1 (binding) Tested by deploying a KVM zone using a cloudmonkey/bash automation script, worked for me. On 14-Aug-2015, at 4:25 pm, Remi Bergsma mailto:[email protected]>> wrote: +1 (binding) Compiled, installed and did some basic testing. Then run some dev/test scripts to deploy te

[GitHub] cloudstack pull request: Default to notify only script to handle n...

GitHub user insom opened a pull request: https://github.com/apache/cloudstack/pull/696 Default to notify only script to handle non-CLVM/QCOW cases. This relates to [CLOUDSTACK-8732](https://issues.apache.org/jira/browse/CLOUDSTACK-8732) Before this commit the call to `getRe

Re: [SHARE] VM migrations failing with Ubuntu 14.04.3

Hello Rohit, No issue for migration in my test environment (KVM over KVM) with the 4.5.2 RC1 on Ubuntu 10.04.3 (up to date) AppArmor is disabled for libvirtd and virt-aa-helper (see my ansible script: https://github.com/milamberspace/ansible-cloudstack-ubuntu-aio/blob/master/roles/cloudstac

Re: [VOTE] Release Apache CloudStack CloudMonkey 5.3.2

+1(binding) installed latest from master, did some basic testing. Everything working as expected. ~Rajani On Fri, Aug 14, 2015 at 4:44 PM, Rohit Yadav wrote: > +1 (binding) > > Tested by deploying a KVM zone using a cloudmonkey/bash automation script, > worked for me. > > On 14-Aug-2015, at 4:2

[GitHub] cloudstack pull request: Update L10N resource files on 4.5 branch ...

GitHub user milamberspace opened a pull request: https://github.com/apache/cloudstack/pull/697 Update L10N resource files on 4.5 branch with 4.5 translation strings… … from Transifex (20150814) You can merge this pull request into a Git repository by running: $ git pull

Re: [DISCUSS] CloudStack 4.5.2 RC and CloudMonkey 5.3.2 RC

On 14/08/2015 09:38, Rohit Yadav wrote: Hi Milamber, Your effort is not wasted, we’ll merge them on 4.5. The first RC (4.5.2-rc1) was created just to get the release process started. Historically we never done any ACS release with the first RC itself. I’m guessing we’ll see some bug reports

[GitHub] cloudstack pull request: CLOUDSTACK-8733: Host stuck in rebalancin...

GitHub user koushik-das opened a pull request: https://github.com/apache/cloudstack/pull/698 CLOUDSTACK-8733: Host stuck in rebalancing state during agent LB This is happening as ClusterServiceServletAdapter is started after ClusteredAgentManagerImpl. Fix is to start ClusterServ

Re: [SHARE] VM migrations failing with Ubuntu 14.04.3

Hi Wido, On 14-Aug-2015, at 2:41 pm, Rohit Yadav mailto:[email protected]>> wrote: Have you disabled AppArmor on that machine? We've seen many machines with random weird issues when AppArmor was enabled. I remember disabling apparmor before the upgrade, but did not check if the upgrad

Re: [SHARE] VM migrations failing with Ubuntu 14.04.3

Hi Bruno, Thanks for checking, while it could be an environment related issue - the VM migration finally started working for me after I downgraded the libvirt-bin and libvirt0 package on my KVM hosts. On 14-Aug-2015, at 4:59 pm, Milamber mailto:[email protected]>> wrote: Hello Rohit, No is

[GitHub] cloudstack pull request: CLOUDSTACK-8669: create volume failed due...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/695#issuecomment-131086429 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

Domain admins should be able to create/edit domains within the domain they are assigned to.

Hi all, A domain admin should be able to create, edit and remove domains within the domain they are assigned to. Currently only root admins can do this. Any objections to why this should not be implemented? https://issues.apache.org/jira/browse/CLOUDSTACK-8734 Best regards, Boris Schrijver TE

[PROPOSE] IPv4 renaming effort.

Dear all, I'll give a try at implementing IPv6 in basic zones in the next couple of weeks. So that's what got the next thing started: I did some looking through the code and noticed the difference between IPv6 and IPv4 naming conventions in methods, variables and classes. IPv6 is always clearly m

[GitHub] cloudstack pull request: Update L10N resource files on 4.5 branch ...

Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/697#issuecomment-131095612 label.local.storage.enabled is removed from multiple languages, but added to one. Is that right? --- If your project is set up for it, you can reply to this email

Re: Domain admins should be able to create/edit domains within the domain they are assigned to.

On Fri, Aug 14, 2015 at 2:14 PM, Boris Schrijver wrote: > Hi all, > > A domain admin should be able to create, edit and remove domains within the > domain they are assigned to. Currently only root admins can do this. > > Any objections to why this should not be implemented? > > https://issues.apa

Re: Domain admins should be able to create/edit domains within the domain they are assigned to.

On 14-08-15 14:47, Erik Weber wrote: > On Fri, Aug 14, 2015 at 2:14 PM, Boris Schrijver wrote: > >> Hi all, >> >> A domain admin should be able to create, edit and remove domains within the >> domain they are assigned to. Currently only root admins can do this. >> >> Any objections to why this

[GitHub] cloudstack pull request: Fix site-to-site VPN feature

Github user snuf commented on the pull request: https://github.com/apache/cloudstack/pull/693#issuecomment-131097876 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

Re: Domain admins should be able to create/edit domains within the domain they are assigned to.

Updated Jira ticket based on input. Daan Hoogland mentioned this feature would complement uncontrolled growth. But adding an option to make it configurable will counteract this. Right Daan? Best regards, Boris Schrijver TEL: +31633784542 MAIL: [email protected] > > On August 14, 2015 at

Re: Domain admins should be able to create/edit domains within the domain they are assigned to.

Yes, it would at least make root admin aware of what risk he will take in this area, seems like a sensible addition to the feature. On Fri, Aug 14, 2015 at 3:05 PM, Boris Schrijver wrote: > Updated Jira ticket based on input. > > Daan Hoogland mentioned this feature would complement uncontrolled

[GitHub] cloudstack pull request: Fix site-to-site VPN feature

Github user jayapal commented on the pull request: https://github.com/apache/cloudstack/pull/693#issuecomment-131106594 No problem Best, Jayapal Mobile, xcuse typoerror. On 14 Aug 2015 18:29, "Funs" wrote: > LGTM > > — > Reply to this email d

Re: [PROPOSE] IPv4 renaming effort.

On 14-08-15 14:42, Boris Schrijver wrote: > Dear all, > > I'll give a try at implementing IPv6 in basic zones in the next couple of > weeks. > So that's what got the next thing started: > > I did some looking through the code and noticed the difference between IPv6 > and > IPv4 naming convent

marvin

Getting following errors on building marvin, although the target is successful, there is no tools/marvin/dist/Marvin-*.tar.gz created !: (mvn -P developer -pl :cloud-marvin) [INFO] --- maven-install-plugin:2.3.1:install (default-install) @ cloud-marvin --- [INFO] Installing /mnt/hgfs/cloudst

[GitHub] cloudstack pull request: Update L10N resource files on 4.5 branch ...

Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/697#issuecomment-131126574 Yes it's right, the original string has been changed, so the (old) translation has been removed on Transifer. Long version: * Cloudstack has now 2

Re: marvin

1, If you have run cloudstack build with required profile, post that go to tools/marvin directory and run "python setup.py install", this should install marvin on your machine. 2, If we want to create tar.gz file and copy it on to another machine, just run python setup.py sdist, under tools/marvi

review needed

H, I've concluded filling empty catch blocks. Can y'all +1 https://github.com/apache/cloudstack/pull/654 ? ​thanks,​ -- Daan

[GitHub] cloudstack pull request: CLOUDSTACK-8726 : Automation for Quickly ...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/683#issuecomment-131158312 @pavanb018 Can you please squash the commits? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: Cloudstack 8656: do away with more silent...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/654#issuecomment-131164822 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request: Cloudstack 8656: do away with more silent...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/654#issuecomment-131175032 look alright, but could it introduce any regressions in the upgrade path? Also, I would love to see a single squashed patched with the changes given ~30 patches for

[GitHub] cloudstack pull request: Cloudstack 8656: do away with more silent...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/654#issuecomment-131178239 All kinds of regressions may be introduced. This is (one of the reasons) why I will not squash. for a single regression we only have to revert a single commit,

[GitHub] cloudstack pull request: Cloudstack 8656: do away with more silent...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/654#issuecomment-131179496 Another way of fixing a regression could be to simply fix the issue, instead of reverting at all. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: Cloudstack 8656: do away with more silent...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/654#issuecomment-131181130 You know I am a great advocate of not squashing, right. All commits are atomic. Yes there is a lot because the work has also been scattered and a lot. --- If y

[GitHub] cloudstack pull request: CLOUDSTACK-8605: KVM: Config Drive and ge...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/577#issuecomment-131209754 @kishankavala Any update on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: Fixed Coverity issue "Dereference null re...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/630#issuecomment-131210799 @manuiiit Could you squash the commits as they have no value as separate commits. @mike-tutkowski @DaanHoogland Let me double check.. you both say LGTM h

[GitHub] cloudstack pull request: Cloudstack 8656: do away with more silent...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/654#issuecomment-131212079 @DaanHoogland I agree, we should only squash if there is no value to have the commits separated. I usually ask for squashing when feedback was processed in a sep

[GitHub] cloudstack pull request: CLOUDSTACK-8716: Verify creation of snaps...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/665#issuecomment-131213094 @pritisarap12 Please squash the commits, they have the same titles which is confusing. If you need multiple commits, make sure they have a descriptive first line

[GitHub] cloudstack pull request: CLOUDSTACK-8717: Failed to start instance...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/667#issuecomment-131213451 @pritisarap12 Same here, please squash the commits as they have the same titles. Also, please @nitt10prashant asks for tests results. Can you please post

[GitHub] cloudstack pull request: Cloudstack 8656: do away with more silent...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/654#issuecomment-131214770 @bhaisaab Indeed, let's fix forward when needed :-) There's always a risk, but I'm happy to see this work being done :+1: --- If your project is set up for it,

[GitHub] cloudstack pull request: Cloudstack 8656: do away with more silent...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/654 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Fixed Coverity issue "Dereference null re...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/630#issuecomment-131220146 I am alright with this. I was curious if @mike-tutkowski is. --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] cloudstack pull request: [CS45] Add missing localization for some ...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/687#issuecomment-131221363 @bhaisaab Wrote a script to handle the merge and made it compatible with your 'git pr' workflow. See https://github.com/schubergphilis/cloudstack-git-t

[GitHub] cloudstack pull request: [CS45] Add missing localization for some ...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/687#issuecomment-131221933 @milamberspace Could you please close this PR as @bhaisaab applied the patch to 4.5. Thanks! --- If your project is set up for it, you can reply to this email a

[GitHub] cloudstack pull request: [CLOUDSTACK-8427] Add missing localizatio...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/686#issuecomment-131227147 As this is in 4.5 now, I'll add my LGTM and merge it to master. --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] cloudstack pull request: [CLOUDSTACK-8427] Add missing localizatio...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/686 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8669: create volume failed due...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/695#discussion_r37114980 --- Diff: vmware-base/test/com/cloud/hypervisor/vmware/util/VmwareContextTest.java --- @@ -0,0 +1,46 @@ +package com.cloud.hypervisor.vmware.util

[GitHub] cloudstack pull request: CLOUDSTACK-8669: create volume failed due...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/695#discussion_r37115023 --- Diff: vmware-base/test/com/cloud/hypervisor/vmware/util/VmwareContextTest.java --- @@ -0,0 +1,46 @@ +package com.cloud.hypervisor.vmware.util

[GitHub] cloudstack pull request: CLOUDSTACK-8669: create volume failed due...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/695#discussion_r37115172 --- Diff: utils/src/com/cloud/utils/StringUtils.java --- @@ -52,7 +52,7 @@ public static boolean isUtf8Supported() { return Charset.isSup

[GitHub] cloudstack pull request: CLOUDSTACK-8669: create volume failed due...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/695#discussion_r37115247 --- Diff: vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareContext.java --- @@ -375,6 +377,18 @@ public void uploadFile(String urlString, File

  1   2   >