[GitHub] cloudstack pull request: CLOUDSTACK-8860: improve error messages i...

2015-11-02 Thread wido
Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/864#discussion_r43605651 --- Diff: engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java --- @@ -1090,8 +1091,8 @@ public void orchestrateStart(final String vmUuid, f

[GitHub] cloudstack pull request: findbugs: ! equals instead of !=

2015-11-02 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1019#discussion_r43605823 --- Diff: plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/BigSwitchBcfApi.java --- @@ -296,7 +296,7 @@ private void setHttpHeader(fi

[GitHub] cloudstack pull request: CLOUDSTACK-9016 Fail to create VM instanc...

2015-11-02 Thread bvbharatk
GitHub user bvbharatk opened a pull request: https://github.com/apache/cloudstack/pull/1020 CLOUDSTACK-9016 Fail to create VM instance within VPC bug link https://issues.apache.org/jira/browse/CLOUDSTACK-9016. CS doe not allocate the ip of the form x.x.x.1 to a guest VM. We

[GitHub] cloudstack pull request: CLOUDSTACK-9016 Fail to create VM instanc...

2015-11-02 Thread bvbharatk
Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/1020#issuecomment-152963507 Hi, Adding Sanjeev's commit which tests this change. --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] cloudstack pull request: CLOUDSTACK-9016 Fail to create VM instanc...

2015-11-02 Thread sanju1010
Github user sanju1010 commented on the pull request: https://github.com/apache/cloudstack/pull/1020#issuecomment-152963577 Test Results: test_21_deploy_vm_with_gateway_ip (integration.component.test_vpc.TestVPC) ... === TestName: test_21_deploy_vm_with_gateway_ip | Status : SUCCESS

[GitHub] cloudstack pull request: CLOUDSTACK-9013: Virtual router failed to...

2015-11-02 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1014#issuecomment-152964107 test passed, only one hypervisor used so migration was skipped: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_ha

[GitHub] cloudstack pull request: CLOUDSTACK-8751 minimise downtime of netw...

2015-11-02 Thread bvbharatk
Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/866#issuecomment-152969714 Hi, rebased with master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: findbugs: ! equals instead of !=

2015-11-02 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1019#discussion_r43609915 --- Diff: plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/BigSwitchBcfApi.java --- @@ -296,7 +296,7 @@ private void setHttpHeade

[GitHub] cloudstack pull request: CLOUDSTACK-9016 Fail to create VM instanc...

2015-11-02 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1020#issuecomment-152970832 Thanks, guys... and also thanks for the tests! Will test it as well. Cheers, Wilder --- If your project is set up for it, you can repl

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

2015-11-02 Thread koushik-das
GitHub user koushik-das opened a pull request: https://github.com/apache/cloudstack/pull/1021 CLOUDSTACK-8485: listAPIs are taking too long to return results - Removed regex. based search/replace of sensitive data on API response introduced as part of commit b0c6d4734724358df97b6fa4

[GitHub] cloudstack pull request: CLOUDSTACK-8961: Changes related to the U...

2015-11-02 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/941#issuecomment-152971271 @kansal Can you address the localization concerns? Also, if possible could you provide screenshots of the change? --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

2015-11-02 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1021#issuecomment-152971700 I have tried to look for the existing API response objects based on some keyword search for sensitive fields. Please let me know if some response objects are le

[GitHub] cloudstack pull request: CLOUDSTACK-8852 Database shows that manag...

2015-11-02 Thread bvbharatk
Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/840#issuecomment-152974654 @bhaisaab fixed the double indent. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

Re: Nexus repository dependencies

2015-11-02 Thread Frank Maximus
HI, If you take a look into plugins/network-elements/junipercontrail/pom.xml, you will see that a repository is defined there: juniper-contrail http://juniper.github.io/contrail-maven/snapshots If you use maven mirror for all repositories, you will need to define the j

[GitHub] cloudstack pull request: findbugs: ! equals instead of !=

2015-11-02 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1019#discussion_r43612367 --- Diff: plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/BigSwitchBcfApi.java --- @@ -296,7 +296,7 @@ private void setHttpHeader(fi

[GitHub] cloudstack pull request: CLOUDSTACK-8647 : LDAP: Auto Import and T...

2015-11-02 Thread sarathkouk
Github user sarathkouk commented on the pull request: https://github.com/apache/cloudstack/pull/919#issuecomment-152976137 @remibergsma : Yes, it is. I made all the changes you suggested. Please go through and let me know if it looks good. --- If your project is set up for it, y

[GitHub] cloudstack pull request: findbugs: ! equals instead of !=

2015-11-02 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/1019#issuecomment-152976291 though its beyond what this PR want to fix, maybe we could fix L403(hash == HASH_CONFLICT) and L406(hash != HASH_IGNORE) as well. --- If your project is set u

[GitHub] cloudstack pull request: findbugs: ! equals instead of !=

2015-11-02 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1019#discussion_r43614066 --- Diff: plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/BigSwitchBcfApi.java --- @@ -296,7 +296,7 @@ private void setHttpHeade

[GitHub] cloudstack pull request:

2015-11-02 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/commit/2783cf540b15323b9fc1e0ced0ad850f694ed479#commitcomment-14123311 In server/src/com/cloud/vm/UserVmManagerImpl.java: In server/src/com/cloud/vm/UserVmManagerImpl.java on line 1367: Why

[GitHub] cloudstack pull request: findbugs: ! equals instead of !=

2015-11-02 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1019#issuecomment-152982076 @karuturi at your service --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

Re: Redundant VPC Virtual Router's state is BACKUP & BACKUP

2015-11-02 Thread Wilder Rodrigues
Looking into it already. Thanks for the note. Cheers, Wilder > On 01 Nov 2015, at 14:08, Remi Bergsma wrote: > > Thanks, we will look into this tomorrow! > > Regards, Remi > > Sent from my iPhone > >> On 01 Nov 2015, at 03:48, giraffeg forestg wrote: >> >> Hi all. >> >> My environment:

[GitHub] cloudstack pull request:

2015-11-02 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/commit/2a2d4364e14903d51cdc3d3a7b4e2eb979a60445#commitcomment-14123387 In services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java: In ser

Re: CloudStack-8933 changes regressed HyperV and VMware BVTs - 8 tests in test_ssvm.py

2015-11-02 Thread Wilder Rodrigues
Hi Raja, We don't have vmware/hyperv test environment. Could you please print the whole error message? I'm missing the bit that says: Current ==> %s; Cached ==> %s Without the full message I cannot look further into it. Cheers, Wilder > On 30 Oct 2015, at 17:03, Raja Pullela wrote: > > H

Re: Nexus repository dependencies

2015-11-02 Thread Ramzi Youssefi
Hi Frank, thanks for your response! I have tried that already but it doesn't seem to work. At the beginning I thought it's a juniper-contrail repository problem. Then I tried another project with another repository (midonet) but it doesn't work either. Nexus won't even show me the remote files. Pr

[GitHub] cloudstack pull request: CLOUDSTACK-9013: Virtual router failed to...

2015-11-02 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1014#issuecomment-152984837 Hi @DaanHoogland @remibergsma @ustcweizhou, the change LGTM! :+1: The tests I have use an isolated network with default egress as "allow", so that

[GitHub] cloudstack pull request: CLOUDSTACK-9016 Fail to create VM instanc...

2015-11-02 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1020#issuecomment-152985217 @sanju1010 , What test did you run? I did a search for "test_21_deploy_vm_with_gateway_ip" in all *py files and could not find anything. C

[GitHub] cloudstack pull request: CLOUDSTACK-9013: Virtual router failed to...

2015-11-02 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1014#issuecomment-152987503 @wilderrodrigues warrants a new marvin config, right? or just a test? --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] cloudstack pull request: CLOUDSTACK-9013: Virtual router failed to...

2015-11-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1014 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Discuss & Vote for invitation to become Commiter ou PMC

2015-11-02 Thread Milamber
Hello, Perhaps, we need let open at least 72h the discuss for promote a contributor to Commiter level or an Committer to PMC level, to allow all PMCs to discuss on this ? I would like say too, the Discuss thread is not a vote thread, the "+1" must be avoided, and some comments are better in

[GitHub] cloudstack pull request: CLOUDSTACK-8825, CLOUDSTACK-8824 : Fixed ...

2015-11-02 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/787#issuecomment-152988729 LGTM, based on a set of tests that I run on this branch (which I rebased myself first): ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -

Re: Discuss & Vote for invitation to become Commiter ou PMC

2015-11-02 Thread Milamber
Ignore. Bad list. Sorry. On 02/11/2015 11:00, Milamber wrote: Hello, Perhaps, we need let open at least 72h the discuss for promote a contributor to Commiter level or an Committer to PMC level, to allow all PMCs to discuss on this ? I would like say too, the Discuss thread is not a vote th

[GitHub] cloudstack pull request: CLOUDSTACK-8825, CLOUDSTACK-8824 : Fixed ...

2015-11-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/787 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8919: Slow UI response while l...

2015-11-02 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/897#issuecomment-152993596 manually verified the fix. Before the fix: on list networks page, I see three api calls 1. list zones 2. list networks with SG groups 3. list netw

[GitHub] cloudstack pull request: CLOUDSTACK-8928: While adding VMs to LB r...

2015-11-02 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/903#issuecomment-152994809 great find @nitin-maharana manually tested the fix In my setup, I had a vm with two nics isolated1 - 10.1.1.14 - default isolated 2 -

[GitHub] cloudstack pull request: CLOUDSTACK-8919: Slow UI response while l...

2015-11-02 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/897#issuecomment-152995832 @remibergsma 2 LGTM's so it can be merged at your discretion. --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] cloudstack pull request: CLOUDSTACK-9016 Fail to create VM instanc...

2015-11-02 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1020#issuecomment-152996320 @bvbharatk Could you sqaush the commits, as they fix a single failure! --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

2015-11-02 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1021#issuecomment-152996985 registerUserKeys log based on this change 2015-11-02 17:15:19,061 INFO [a.c.c.a.ApiServer] (2001334745@qtp-678426242-0:ctx-608cad64 ctx-6e00b6fc) (logi

[GitHub] cloudstack pull request: Use java.io.tmpdir instead of hardcoded /...

2015-11-02 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1012#issuecomment-152997882 for the record and again. LGTM I do not run a windows environment but since Rafael has tested and we have some contributors needing this to proceed; let's merg

[GitHub] cloudstack pull request: findbugs: ! equals instead of !=

2015-11-02 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1019#issuecomment-152998269 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Ovm3HypervisorGuru answe...

2015-11-02 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1015#issuecomment-153000467 LGTM, based on a set of tests that I run on this branch (which I rebased myself first): ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s

[GitHub] cloudstack pull request: CLOUDSTACK-9016 Fail to create VM instanc...

2015-11-02 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1020#issuecomment-153000625 @wilderrodrigues test_21_deploy_vm_with_gateway_ip is part of this PR, what else are your looking for and where are you ooking for it? --- If your project is

[GitHub] cloudstack pull request: CLOUDSTACK-9008 - Pass hypervisor snapsho...

2015-11-02 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1016#issuecomment-153000915 LGTM, based on a set of tests that I run on this branch (which I rebased myself first): ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s

[GitHub] cloudstack pull request: kvm: Add UnitTests for LibvirtUtilitiesHe...

2015-11-02 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1005#issuecomment-153001413 LGTM, based on a set of tests that I run on this branch (which I rebased myself first): ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s

[GitHub] cloudstack pull request: kvm: Add UnitTests for LibvirtUtilitiesHe...

2015-11-02 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1005#issuecomment-153001491 @DaanHoogland Can you please update your review, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

2015-11-02 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1021#issuecomment-153001614 Jenkins build failed with the following error. I saw some other PRs with the same failure. So looks like some random issue. [ERROR] SLF4J: Class path co

[GitHub] cloudstack pull request: kvm: Add UnitTests for LibvirtUtilitiesHe...

2015-11-02 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1005#issuecomment-153001898 still good looking, let's get this merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] cloudstack pull request: CLOUDSTACK-8847: ListServiceOfferings is ...

2015-11-02 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/823#issuecomment-153002143 LGTM, based on a set of tests that I run on this branch (which I rebased myself first): ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -

[GitHub] cloudstack pull request: CLOUDSTACK-9008 - Pass hypervisor snapsho...

2015-11-02 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1016#issuecomment-153002626 LGTM based on code inspection (Why the move of the customizediops bits? harmless but senseless) --- If your project is set up for it, you can reply to this em

Re: test_vpc_vpn.py failing 2 BVTs on all Advnetworking config

2015-11-02 Thread Sanjeev N
The reason for these two failures is VPC creation itself is failing. Reason being "SSH access to VR on 3922 port using its management ip address" is failing. Hence failure in VR start. This looks like product bug to me. -Sanjeev On Fri, Oct 30, 2015 at 10:36 PM, Raja Pullela wrote: > Super, tha

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Ovm3HypervisorGuru answe...

2015-11-02 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/1015#issuecomment-153003386 LGTM (code review. no tests executed) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] cloudstack pull request: kvm: Add UnitTests for LibvirtUtilitiesHe...

2015-11-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1005 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

2015-11-02 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1021#issuecomment-153003710 @koushik-das I've seen it before and the actual error message is ``` # # A fatal error has been detected by the Java Runtime Environment: # S

[GitHub] cloudstack pull request: Update L10N Web UI resource files before ...

2015-11-02 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/1001#issuecomment-153004732 tested that all the english strings are loading fine and there are no JS/UI issues observed. :+1: LGTM --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Ovm3HypervisorGuru answe...

2015-11-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1015 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Ovm3HypervisorGuru wrong...

2015-11-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/975 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9008 - Pass hypervisor snapsho...

2015-11-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1016 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Update L10N Web UI resource files before ...

2015-11-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1001 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8919: Slow UI response while l...

2015-11-02 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/897#issuecomment-153008102 This PR has a conflict now, can someone resolve it? ``` From https://github.com/apache/cloudstack * [new ref] refs/pull/987/head -> pr/98

[GitHub] cloudstack pull request: CLOUDSTACK-8928: While adding VMs to LB r...

2015-11-02 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/903#issuecomment-153009144 Nice small fix, LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] cloudstack pull request: CLOUDSTACK-8928: While adding VMs to LB r...

2015-11-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/903 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACk-9002: VM deployment is success...

2015-11-02 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/995#issuecomment-153010146 LGTM I agree with @wido that unit tests are desirable but I will not block this for them. It will automatically block on regression. --- If your project is set

Re: CloudStack-8933 changes regressed HyperV and VMware BVTs - 8 tests in test_ssvm.py

2015-11-02 Thread Raja Pullela
Hi wilder, missed your earlier email.. sorry, here are the details. Let me know if you need any further details. I believe for Hyperv/Vmware the ips come from the pod cidr and the validation should be skipped. Raja Error Message The cached Link Local should be the same as the current Link Lo

[GitHub] cloudstack pull request: CLOUDSTACk-9002: VM deployment is success...

2015-11-02 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/995#issuecomment-153012986 LGTM :+1: based on the 40 tests I execute + the 71 tests @remibergsma executed! Cheers, Wilder --- If your project is set up for it, you can r

[GitHub] cloudstack pull request: CLOUDSTACK-8940: Wrong value is inserted ...

2015-11-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/916 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8940: Wrong value is inserted ...

2015-11-02 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/916#issuecomment-153012703 LGTM :+1: Please proceed with merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack pull request: CLOUDSTACK-9016 Fail to create VM instanc...

2015-11-02 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1020#issuecomment-153013812 FYI: Running tests on this now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] cloudstack pull request: CLOUDSTACk-9002: VM deployment is success...

2015-11-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/995 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9008 - Pass hypervisor snapsho...

2015-11-02 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/1016#issuecomment-153027106 I liked that ordering better...seems more logical: 1) customized IOPS (true/false), 2) Min IOPS, and 3) Max IOPS (2 and 3 are ignored by the backend if

[GitHub] cloudstack pull request: CLOUDSTACK-9008 - Pass hypervisor snapsho...

2015-11-02 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1016#issuecomment-153027488 so in English: for readability. makes sense ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-11-02 Thread KrisSterckx
Github user KrisSterckx commented on the pull request: https://github.com/apache/cloudstack/pull/801#issuecomment-153036347 Hi @jburwell can you pls approve if the PR looks good to you now ? @remibergsma, can you pls suggest how we can continue ? Thanks Kris

Compiling master - build error

2015-11-02 Thread cs user
Hi Folks, I'm trying to compile master, but I'm getting the following errors: Check, is this api part of another build profile? Null value for key: listCiscoAsa1000vResources preProcessedCommand=1 Traceback (most recent call last): File "/home/acldstkusr/git/cloudstack/tools/apidoc/gen_toc.py",

Re: Compiling master - build error

2015-11-02 Thread Daan Hoogland
hey some guy, Our jenkins apidoc builders have been failing regularly in such a way coming back after a while. Have a look to see if it is the same issue. and if it is; Try just building anew it might just work. if you find the root cause please submit a PR. regards, On Mon, Nov 2, 2015 at 4:01

[GitHub] cloudstack pull request: CLOUDSTACK-8647 : LDAP: Auto Import and T...

2015-11-02 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/919#issuecomment-153049778 @sarathkouk Thanks, will look into it. Can you squash the commits? --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-11-02 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/801#issuecomment-153051079 Hi @KrisSterckx please ping me if all required changes are in and I will do another test run. Once that looks good, we can merge it. --- If your project is set

[GitHub] cloudstack pull request: CLOUDSTACK-8906: /var/log/cloud/ doesn't ...

2015-11-02 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/883#issuecomment-153051565 Hi @SudharmaJain can you please fix the conflict? I'll then run some tests and we're ready to merge. --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-11-02 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/801#issuecomment-153051926 @KrisSterckx I will re-review late today or early tomorrow. Also, please bear in mind that master is current frozen. Therefore, approval of this PR will simply pe

[GitHub] cloudstack pull request: CLOUDSTACK-9016 Fail to create VM instanc...

2015-11-02 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1020#issuecomment-153074432 FYI: Also running tests in this now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] cloudstack pull request: CLOUDSTACK-9016 Fail to create VM instanc...

2015-11-02 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1020#issuecomment-153076688 @remibergsma LGTM :+1:, see results below. ``` nosetests --with-marvin --marvin-config=/data/shared/marvin/mct-zone1-kvm1.cfg -s -a tags=advanced,re

[GitHub] cloudstack pull request: CLOUDSTACK-8958: add dedicated ips to dom...

2015-11-02 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1007#issuecomment-153077340 FYI: Running tests on this now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] cloudstack pull request: CLOUDSTACK-9016: Fail to create VM instan...

2015-11-02 Thread borisroman
GitHub user borisroman opened a pull request: https://github.com/apache/cloudstack/pull/1022 CLOUDSTACK-9016: Fail to create VM instance within VPC CLOUDSTACK-9016: Fail to create VM instance within VPC CLOUDSTACK-9016: Deploy vm with gateway ip address in VPC Signed-off

[GitHub] cloudstack pull request: Add Unit Tests for Libvirt/KVM storage co...

2015-11-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/986 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9016: Fail to create VM instan...

2015-11-02 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1022#issuecomment-153082646 -1 the commits in 1020 don't need squshing. this is senseless. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-8928: While adding VMs to LB r...

2015-11-02 Thread nitin-maharana
Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/903#issuecomment-153083572 Thanks @karuturi @remibergsma. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: CLOUDSTACK-8919: Slow UI response while l...

2015-11-02 Thread nitin-maharana
Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/897#issuecomment-153093925 Hi @remibergsma, I tried rebasing with current master. There is no conflict as such. I think you were trying to merge the PR #987, But this PR is #897

Xen security issue

2015-11-02 Thread John Kinsella
Folks running paravirtualized VMs on Xen (3.4 and newer) hosts need to patch to protect against a new vulnerability that allows an admin in a VM to escape up to the host: http://xenbits.xen.org/xsa/advisory-148.html John Stratosec - Secure Finance and Heathcare Clouds http://stratosec.co o: 41

[GitHub] cloudstack pull request: CLOUDSTACK-9016 Fail to create VM instanc...

2015-11-02 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1020#issuecomment-153125197 LGTM, based on a set of tests that I run on this branch (which I rebased myself first): ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s

[GitHub] cloudstack pull request: CLOUDSTACK-8919: Slow UI response while l...

2015-11-02 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/897#issuecomment-153125931 Hi @nitin-maharana hmm all those numbers ;-) sorry dude! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] cloudstack pull request: CLOUDSTACK-8919: Slow UI response while l...

2015-11-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/897 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9016 Fail to create VM instanc...

2015-11-02 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1020#issuecomment-153126593 ran the same tests as Remi and they are past the vpc bit so it LGTM. There is some discussion on the quality of the messages on the commits @bvbharatk . Do you

[GitHub] cloudstack pull request: CLOUDSTACK-8913: Search box in Templates ...

2015-11-02 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/891#issuecomment-153130023 Ping @bhaisaab to backport to 4.5 as it is now merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-8913: Search box in Templates ...

2015-11-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/891 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Use java.io.tmpdir instead of hardcoded /...

2015-11-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1012 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9008 - Pass hypervisor snapsho...

2015-11-02 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/1016#issuecomment-153133444 Thanks! I went ahead and closed https://issues.apache.org/jira/browse/CLOUDSTACK-9008. --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: CLOUDSTACK-9016: Fail to create VM instan...

2015-11-02 Thread borisroman
Github user borisroman closed the pull request at: https://github.com/apache/cloudstack/pull/1022 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cloudstack pull request: CLOUDSTACK-9016 Fail to create VM instanc...

2015-11-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1020 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: extending macchinina image

2015-11-02 Thread Michael Andersen
Thanks Lucian. Do you mind including the strong swan, or some other ipsec client to your openvm macchinina image? I want to improve the remote access vpn testing as it does actually test setting up the vpn connection. Pretty please.. :) On 30/10/15 17:19, "Nux!" wrote: >Hello, > >Macchin

Re: extending macchinina image

2015-11-02 Thread Michael Andersen
Oh and what’s the default user/password combination of the debian 8.10 images on openvm.eu? http://dl.openvm.eu/cloudstack/debian/vanilla/8.1.0/x86_64/ On 02/11/15 21:01, "Michael Andersen" wrote: >Thanks Lucian. > >Do you mind including the strong swan, or some other ipsec client to your

[GitHub] cloudstack pull request: CLOUDSTACK-8308: Adding automation testca...

2015-11-02 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/720#issuecomment-153150870 @karuturi Could you run this on your Xen-setup? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: CLOUDSTACK-8958: add dedicated ips to dom...

2015-11-02 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1007#issuecomment-153157118 @remibergsma LGMT :+1: Reviewed the code and run the vm_lifecycle_test. ``` nosetests --with-marvin --marvin-config=/data/shared/marvin/mct-zone1-kvm

[GitHub] cloudstack-docs-admin pull request: Clarified GPU description.

2015-11-02 Thread ronatartifact
GitHub user ronatartifact opened a pull request: https://github.com/apache/cloudstack-docs-admin/pull/31 Clarified GPU description. Added link to design docs for creating new GPU type. You can merge this pull request into a Git repository by running: $ git pull https://github.

  1   2   >