[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

2016-05-13 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r63140242 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -361,59 +600,205 @@ privat

[GitHub] cloudstack pull request: CLOUDSTACK-8867: Added retry logic to rec...

2016-05-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1269#issuecomment-218976339 tag:needsreview --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] cloudstack pull request: CLOUDSTACK-9379: Support nested virtualiz...

2016-05-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1542#issuecomment-218977461 @nvazquez I like the functional description and will probably run through the code over the weekend but one thing struck me. A lot of this should apply equally

[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...

2016-05-13 Thread abhinandanprateek
Github user abhinandanprateek commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-218978117 @SudharmaJain it is a unit test failure triggered by an assert. cc @rhtyd It is being generated by ProcessRunner. --- If your project is set up for it, yo

[GitHub] cloudstack pull request: Systemd packaging for Ubuntu 16.04

2016-05-13 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1541#issuecomment-218978125 @rhtyd Forgot to mention, I didn't fix the MGMT server yet. Tomcat is a bit scary to me. I only worked on the Agent mainly. I think that is the highest prio fo

[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...

2016-05-13 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-218978559 My bad, it is fixed here: https://github.com/apache/cloudstack/pull/1543 --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] cloudstack pull request: Fix Nio/CPU issue and CI failures

2016-05-13 Thread abhinandanprateek
Github user abhinandanprateek commented on the pull request: https://github.com/apache/cloudstack/pull/1543#issuecomment-218978811 LGTM based on code review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: Systemd packaging for Ubuntu 16.04

2016-05-13 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1541#issuecomment-218980050 @wido alright, but while we're at it let's see if we can fix the mgmt server as well. I tested agent and was able to perform setup: ``` root@antr

[GitHub] cloudstack pull request: Systemd packaging for Ubuntu 16.04

2016-05-13 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1541#issuecomment-218980350 Tested installation and started cloudstack-usage that seems to be working as well: ``` root@antrix:/var/log/cloudstack/agent# systemctl status cloudstack-

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2016-05-13 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/669#issuecomment-218980649 @swill Its showing lot of conflicts currently and will take some time to resolve those. Will update PR once I will get some time. --- If your project is set up

[GitHub] cloudstack pull request: Fix Nio/CPU issue and CI failures

2016-05-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1543#issuecomment-218980870 code LGTM. trusting @kiwiflyer I will probably test later but am a bit stuck today. --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: Systemd packaging for Ubuntu 16.04

2016-05-13 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1541#discussion_r63148448 --- Diff: debian/cloudstack-agent.install --- @@ -18,12 +18,11 @@ /etc/cloudstack/agent/agent.properties /etc/cloudstack/agent/environment.propert

[GitHub] cloudstack pull request: Systemd packaging for Ubuntu 16.04

2016-05-13 Thread wido
Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1541#discussion_r63150289 --- Diff: debian/cloudstack-agent.install --- @@ -18,12 +18,11 @@ /etc/cloudstack/agent/agent.properties /etc/cloudstack/agent/environment.properti

[GitHub] cloudstack pull request: Fix Nio/CPU issue and CI failures

2016-05-13 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1543#issuecomment-218987023 I've also fixed a integration/component test that has failed on Travis several time for various PRs due to cleanup order (tearDown issue): ``` Marvin

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

2016-05-13 Thread abhinandanprateek
Github user abhinandanprateek commented on the pull request: https://github.com/apache/cloudstack/pull/1371#issuecomment-218997501 @jburwell briefly moving to java 8 made me realise that it has lot more ipv6 primitives then there are in 7. --- If your project is set up for it, you ca

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add channel to Instances...

2016-05-13 Thread wido
GitHub user wido opened a pull request: https://github.com/apache/cloudstack/pull/1545 CLOUDSTACK-8715: Add channel to Instances for Qemu Guest Agent This commit adds a additional VirtIO channel with the name 'org.qemu.guest_agent.0' to all Instances. With the Qemu Guest

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

2016-05-13 Thread wido
Github user wido closed the pull request at: https://github.com/apache/cloudstack/pull/985 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

2016-05-13 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-218998186 Closing this one in favor of #1545 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add channel to Instances...

2016-05-13 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1545#issuecomment-218998413 This PR follows up on #985, but this one does not have a libvirt-java dependency. It only adds the channel in the XML for all Instances and it installs the Qe

[GitHub] cloudstack pull request: Add perl-modules as install dependency fo...

2016-05-13 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1495#issuecomment-219001342 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request: Make the generated json files unique to p...

2016-05-13 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1470#issuecomment-219005330 @swill @kiwiflyer I run the integration tests over night and they look much better now. I only see some test fail in `smoke/test_network.py` that seem to have t

[GitHub] cloudstack-docs-admin pull request: CLOUDSTACK-9299: doc for out-o...

2016-05-13 Thread abhinandanprateek
Github user abhinandanprateek commented on the pull request: https://github.com/apache/cloudstack-docs-admin/pull/38#issuecomment-219009712 read the document LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: DAO: Hit the cache for entity flagged as ...

2016-05-13 Thread marcaurele
Github user marcaurele commented on the pull request: https://github.com/apache/cloudstack/pull/1532#issuecomment-219010730 checks are finally ok... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: [4.10+/long-term] Moving towards Java8 an...

2016-05-13 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1546 [4.10+/long-term] Moving towards Java8 and Spring4 This is a long term fix aiming to do following: - Use Java8 for both building and running CloudStack - Use Spring-framework 4.2.x - U

[GitHub] cloudstack pull request: Systemd packaging for Ubuntu 16.04

2016-05-13 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1541#issuecomment-219012402 ok @rhtyd ! Let's look at the Agent and Usage first. When they work as they should I'll look at the MGMT server. The packages work fine on my Ubuntu 14.04 and

[GitHub] cloudstack pull request: [WIP][4.10+/long-term] Moving towards Jav...

2016-05-13 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1546#issuecomment-219013061 So, this means we will drop Ubuntu 14.04 support. There is no Java 8 available in those repositories --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: [WIP][4.10+/long-term] Moving towards Jav...

2016-05-13 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1546#issuecomment-219012985 Request for comments - @jburwell @DaanHoogland @wido @DaanHoogland @abhinandanprateek @imduffy15 @kiwiflyer @terbolous and others --- If your project is set up for i

[GitHub] cloudstack pull request: [WIP][4.10+/long-term] Moving towards Jav...

2016-05-13 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1546#issuecomment-219014328 @wido it's true that the package is not in the default, but Java8 is available through few popular ppa(s). We need to migrate to Java8 since Java7 has EOL-ed for so l

[GitHub] cloudstack pull request: Systemd packaging for Ubuntu 16.04

2016-05-13 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1541#issuecomment-219015333 @wido I'm LGTM on agent and usage package, it's a good first steps. Though, I also want to see mgmt server as well. For enabling the services, we can have some sort o

[GitHub] cloudstack-docs-admin pull request: CLOUDSTACK-9299: doc for out-o...

2016-05-13 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack-docs-admin/pull/38#issuecomment-219015461 Thanks Abhi, since the feature PR is merged. I'm merging the doc PR as well. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack-docs-admin pull request: CLOUDSTACK-9299: doc for out-o...

2016-05-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack-docs-admin/pull/38 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] cloudstack pull request: Remove extraneous log directory and add c...

2016-05-13 Thread PaulAngus
GitHub user PaulAngus reopened a pull request: https://github.com/apache/cloudstack/pull/1537 Remove extraneous log directory and add catalina.out log rotation rebased and squashed replacement for PR: https://github.com/apache/cloudstack/pull/1087 Remove extraneous log d

[GitHub] cloudstack pull request: Remove extraneous log directory and add c...

2016-05-13 Thread PaulAngus
Github user PaulAngus closed the pull request at: https://github.com/apache/cloudstack/pull/1537 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CPU socket count reporting correction

2016-05-13 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1520#issuecomment-219027354 LGTM, running this in prod for about a month now. See link above for screenshots. --- If your project is set up for it, you can reply to this email and have yo

[GitHub] cloudstack pull request: Lower the time we wait for interfaces to ...

2016-05-13 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1471#issuecomment-219029943 @jburwell Had a look at the `wait_until` method and I don't think it will work well here. The problem is that when the router restarts, it has the full config i

[GitHub] cloudstack pull request: Reimplement router.redundant.vrrp.interva...

2016-05-13 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1486#issuecomment-219031280 Resolved conflict --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: CLOUDSTACK-6928: fix issue disk I/O throt...

2016-05-13 Thread kiwiflyer
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1410#issuecomment-219033178 We're working on getting this tested as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] cloudstack pull request: CPU socket count reporting correction

2016-05-13 Thread kiwiflyer
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1520#issuecomment-219033610 @swill This one is green now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add channel to Instances...

2016-05-13 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1545#issuecomment-219034798 @swill and @rhtyd could you take a look at this one? Once we fork libvirt-java (which I want to do when we switch to new repos) we can implement the actual com

[GitHub] cloudstack pull request: Remove extraneous log directory and add c...

2016-05-13 Thread PaulAngus
GitHub user PaulAngus reopened a pull request: https://github.com/apache/cloudstack/pull/1537 Remove extraneous log directory and add catalina.out log rotation rebased and squashed replacement for PR: https://github.com/apache/cloudstack/pull/1087 Remove extraneous log d

[GitHub] cloudstack pull request: Remove extraneous log directory and add c...

2016-05-13 Thread PaulAngus
Github user PaulAngus closed the pull request at: https://github.com/apache/cloudstack/pull/1537 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-9317: Enable/disable static NA...

2016-05-13 Thread ProjectMoon
Github user ProjectMoon commented on the pull request: https://github.com/apache/cloudstack/pull/1450#issuecomment-219037058 It would be useful for someone knowledgeable in the network internals to elaborate on @jayapalu's comment. We currently do not use the feature he's talking abou

[GitHub] cloudstack pull request: Make the generated json files unique to p...

2016-05-13 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1470#issuecomment-219037267 Pushed the fix and the tests now pass: ``` [root@cs2 cloudstack]# cat /tmp//MarvinLogs/test_network_7VU0DJ/results.txt Test for port forwarding

[GitHub] cloudstack pull request: [WIP][4.10+/long-term] Moving towards Jav...

2016-05-13 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1546#issuecomment-219047291 @rhtyd I think it would be a good idea to this PR up a bit. I see three distinct pieces: 1. **Spring 4 Upgrade**: Spring 4 supports both Java7 and Java8.

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

2016-05-13 Thread DaanHoogland
Github user DaanHoogland closed the pull request at: https://github.com/apache/cloudstack/pull/1297 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

2016-05-13 Thread DaanHoogland
GitHub user DaanHoogland reopened a pull request: https://github.com/apache/cloudstack/pull/1297 CLOUDSTACK-9203 Implement security group move on updateVM API call cherry-picked from a exoscale internal fix Conflicts: api/src/org/apache/cloudstack/api/command/user/

[GitHub] cloudstack pull request: Kvm plugin restructure

2016-05-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1521#issuecomment-219049934 @rhtyd @jburwell @wido @swill Are we not doing this? I see no :-1: but also no LGTM --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...

2016-05-13 Thread The-Loeki
GitHub user The-Loeki opened a pull request: https://github.com/apache/cloudstack/pull/1547 Fixes for VirtualRouters in Basic Networking, especially with mutliple ranges in VLANs During the last few modifications on the SystemVM scripts, it turns out quite a lot of stuff broke in o

[GitHub] cloudstack pull request: CLOUDSTACK-9379: Support nested virtualiz...

2016-05-13 Thread nvazquez
Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1542#issuecomment-219051673 Hi @DaanHoogland, unfortunately I really didn't examine it for other hypervisors. In our environment we only use VMware ESXi hypervisor, that's the main reason for

[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...

2016-05-13 Thread The-Loeki
Github user The-Loeki commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1547#discussion_r63188699 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsConfig.py --- @@ -66,8 +66,13 @@ def is_router(self): def get_domain(self):

[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...

2016-05-13 Thread The-Loeki
Github user The-Loeki commented on the pull request: https://github.com/apache/cloudstack/pull/1547#issuecomment-219054107 @DaanHoogland click on the (...) :dancers: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...

2016-05-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1547#issuecomment-219053999 @The-Loeki 6 commits with the same message is not helpful and indeed confusing. Can you change them to shortly describe the individual fixes, or if you must sq

[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...

2016-05-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1547#issuecomment-219054423 @The-Loeki those don't show in a short listing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: CLOUDSTACK-9379: Support nested virtualiz...

2016-05-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1542#issuecomment-219052329 :) no worries, just expect some review comments to this extend ;) --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...

2016-05-13 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1547#discussion_r63188515 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsConfig.py --- @@ -66,8 +66,13 @@ def is_router(self): def get_domain(self):

[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...

2016-05-13 Thread The-Loeki
Github user The-Loeki commented on the pull request: https://github.com/apache/cloudstack/pull/1547#issuecomment-219062321 @DaanHoogland like it better now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...

2016-05-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1547#issuecomment-219063444 :+1: maybe squash the conflict entries out? you can rebase -i HEAD^7 and then reorder the commits. If you put the last one at position 3 and change the pref

[GitHub] cloudstack pull request: CLOUDSTACK-8830 - [Vmware] VM snapshot fa...

2016-05-13 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/798#issuecomment-219067011 It would be nice if this is resolved. The issue still exists in 4.9 --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] cloudstack pull request: Fix Nio/CPU issue and CI failures

2016-05-13 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1543#issuecomment-219071379 Most of these things are fixes to Jenkins and travis issues, so those jobs being green is good validation of the fixes. The main functionality change has been valida

[GitHub] cloudstack pull request: Fix Nio/CPU issue and CI failures

2016-05-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1543 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-05-13 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-219073755 ### CI RESULTS ``` Tests Run: 85 Skipped: 0 Failed: 0 Errors: 0 Duration: 4h 18m 48s ``` **Associ

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-05-13 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-219074192 @syed can you force push or close and reopen the PR to kick off travis and jenkins? I think this one seems to be in a pretty good state now... --- If your project i

[GitHub] cloudstack pull request: Make the generated json files unique to p...

2016-05-13 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1470#issuecomment-219074669 I will rerun CI on this now. Thx... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] cloudstack pull request: Make the generated json files unique to p...

2016-05-13 Thread kiwiflyer
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1470#issuecomment-219076184 We have the fixes pulled in for testing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] cloudstack pull request: CLOUDSTACK-9378: Fix for #1497

2016-05-13 Thread nvazquez
Github user nvazquez closed the pull request at: https://github.com/apache/cloudstack/pull/1539 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-9378: Fix for #1497

2016-05-13 Thread nvazquez
Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1539#issuecomment-219077065 Thanks, closed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] cloudstack pull request: Make the generated json files unique to p...

2016-05-13 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1470#issuecomment-219077134 @kiwiflyer thanks, I will run CI against it as well. It is good to have CI posted as well as manual verification. that gives us the most confidence that everything

[GitHub] cloudstack pull request: Remove extraneous log directory and add c...

2016-05-13 Thread PaulAngus
Github user PaulAngus commented on the pull request: https://github.com/apache/cloudstack/pull/1537#issuecomment-219077622 Hurrah!! passed both this time @swill --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: Remove extraneous log directory and add c...

2016-05-13 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1537#issuecomment-219079650 Thank you for your patience sir. 👍 I will get this merged... --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] cloudstack pull request: CLOUDSTACK-6928: fix issue disk I/O throt...

2016-05-13 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1410#issuecomment-219081336 @ustcweizhou would you mind doing a force push or close and reopen this PR to kickoff jenkins so we are all green when @kiwiflyer posts his test results. This will h

[GitHub] cloudstack pull request: Reimplement router.redundant.vrrp.interva...

2016-05-13 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1486#issuecomment-219082129 This one is looking pretty good. Can we get some code review on it so we can move it forward. Thanks... --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: CLOUDSTACK-9358: StringIndexOutOfBoundsEx...

2016-05-13 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1503#issuecomment-219082695 ### CI RESULTS ``` Tests Run: 82 Skipped: 0 Failed: 0 Errors: 3 Duration: 8h 28m 52s ``` **Summary of the p

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

2016-05-13 Thread nvazquez
Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1518#issuecomment-219083470 @koushik-das I only use Vmware hypervisor so I couldn't test it for Xen or KVM. However, I reviewed code and found `copySnapshotToTemplateFromNfsToNfsXenserver` me

[GitHub] cloudstack pull request: CLOUDSTACK-9358: StringIndexOutOfBoundsEx...

2016-05-13 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1503#issuecomment-219083712 I have never seen these test failures before, so I believe they are somehow related to this change. @olivierlemasle can you review the CI results and post your feedb

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-05-13 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1513#issuecomment-219084090 ### CI RESULTS ``` Tests Run: 85 Skipped: 0 Failed: 1 Errors: 0 Duration: 9h 01m 07s ``` **Summary of the p

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-05-13 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1513#issuecomment-219084969 @insom, @dmabry and @kiwiflyer, the CI failure seems like it could be related to this change, but I can't be sure. Can you guys provide some guidance since all of yo

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-05-13 Thread insom
GitHub user insom reopened a pull request: https://github.com/apache/cloudstack/pull/1513 CLOUDSTACK-9362: Skip VXLANs when rewriting the bridge name for migrations (4.8-2) From the [JIRA issue](https://issues.apache.org/jira/browse/CLOUDSTACK-9362): > https://github.com/

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-05-13 Thread insom
Github user insom closed the pull request at: https://github.com/apache/cloudstack/pull/1513 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-05-13 Thread insom
Github user insom commented on the pull request: https://github.com/apache/cloudstack/pull/1513#issuecomment-219085734 @swill I've closed and re-opened. This change is to a shell script only and the failures are within Marvin, so I'm pretty confident that they are unrelated to my prop

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

2016-05-13 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1494#issuecomment-219086756 ### CI RESULTS ``` Tests Run: 85 Skipped: 0 Failed: 0 Errors: 0 Duration: 9h 17m 55s ``` **Associ

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

2016-05-13 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1494#issuecomment-219087700 The CI does not cover the actual code, but instead makes sure nothing else is broken by these changes. The test results provided by @nlivens show the tests for the a

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

2016-05-13 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1511#issuecomment-219088009 ### CI RESULTS ``` Tests Run: 85 Skipped: 0 Failed: 0 Errors: 0 Duration: 9h 21m 07s ``` **Associ

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

2016-05-13 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1511#issuecomment-219088252 This one is coming back with a clean bill of health. I think we are ready on this one. Can I get some code review? Thanks... --- If your project is set up for it,

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-05-13 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1513#issuecomment-219091474 @insom yes, I tend to agree with you. the main reason I highlighted it was because the error was network related and the code changed details related to an interface

[GitHub] cloudstack-docs-admin pull request: CLOUDSTACK-9299: doc for out-o...

2016-05-13 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack-docs-admin/pull/38#issuecomment-219092042 Thanks for taking care of this @rhtyd. 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack pull request: DAO: Hit the cache for entity flagged as ...

2016-05-13 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1532#issuecomment-219093207 I am counting my own code review on this one given the scope of the change and the fact that a review is the only thing holding this up. I will merge this one... -

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

2016-05-13 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1518#issuecomment-219093988 I will run this through my KVM CI right now... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...

2016-05-13 Thread The-Loeki
Github user The-Loeki commented on the pull request: https://github.com/apache/cloudstack/pull/1547#issuecomment-219094194 Like this then :dart: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] cloudstack pull request: Fix Nio/CPU issue and CI failures

2016-05-13 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1543#issuecomment-219095201 Thanks @swill --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] cloudstack pull request: Fix Nio/CPU issue and CI failures

2016-05-13 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1543#issuecomment-219095904 Thanks for the effort stabilizing Jenkins and Travis the last few days. This has been super helpful as we get close to the freeze. Very much appreciated. Most of t

[GitHub] cloudstack pull request: CLOUDSTACK-8830 - [Vmware] VM snapshot fa...

2016-05-13 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/798#issuecomment-219096839 @maneesha-p can you rebase and push so we can get this PR green? I would love some code review as well. Thx... --- If your project is set up for it, you can reply t

[GitHub] cloudstack pull request: Fix Nio/CPU issue and CI failures

2016-05-13 Thread swill
Github user swill commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1543#discussion_r63215404 --- Diff: test/integration/component/test_acl_listvolume.py --- @@ -357,9 +357,9 @@ def tearDownClass(cls): cls.apiclient = super(TestVolumeLis

[GitHub] cloudstack pull request: Fix Nio/CPU issue and CI failures

2016-05-13 Thread swill
Github user swill commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1543#discussion_r63215625 --- Diff: test/integration/component/test_acl_listvolume.py --- @@ -357,9 +357,9 @@ def tearDownClass(cls): cls.apiclient = super(TestVolumeLis

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

2016-05-13 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-219100429 This one errored again in both Jenkins and Travis. Not sure if that signifies an actual problem or if things are just acting up. I fix to some of the issues in Jenk

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-05-13 Thread insom
Github user insom commented on the pull request: https://github.com/apache/cloudstack/pull/1513#issuecomment-219101084 @swill Hmm. Now it's a _different_ Cobertura error --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: Kvm plugin restructure

2016-05-13 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1521#issuecomment-219101062 We have merge conflicts on this one. As soon as the merge conflicts are sorted out, I will run CI against it and hopefully we can get some code reviews quickly so we

[DISCUSS] Moving to Java8

2016-05-13 Thread Rohit Yadav
All, I've started some work [pr] that aims to adapt CloudStack to recent changes in the environments and the ecosystem: - Java8, Spring 4.x - SystemD - MariaDB and MySQL - Reduce distro provided package dependency - Packaging, CI and testing These are long term goals but I've identified

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add channel to Instances...

2016-05-13 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1545#issuecomment-219104928 Ya, I like this. I think this is a nice advancement. If we are going to try to get this into 4.9, I will need some help getting this moving forward cause we are pre

[GitHub] cloudstack pull request: CPU socket count reporting correction

2016-05-13 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1520#issuecomment-219105793 Awesome, thanks guys. I will merge this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

2016-05-13 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1513#issuecomment-219109520 Holy errors batman!!! It looks like it started like this: ``` [INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ cloud-server

  1   2   >