Re: Please review changes to WildcardHelper

2006-06-01 Thread Carsten Ziegeler
Antonio Gallardo wrote: > Hi Carsten, > > I think we fixed a bug but got another. Hmpf, this was what I expected :( > That is good, because by > introducing a new test case for the new bug and fixing it, our code get > better. Yepp, can you come up with a test case? > Anyhow, here is how to se

[issue tracker] remove Attachment field from initial entry screen

2006-06-01 Thread David Crossley
One of the Forrest developers (thanks Brian) has pointed out that the initial Issue entry screen for our Jira does not enable to grant ASF license for attachments. This option is only available when following up to add attachments. Looking around at other projects in ASF Jira, i see that most do n

[continuum] BUILD SUCCESSFUL: Cocoon Core

2006-06-01 Thread [EMAIL PROTECTED]
Online report : http://cocoon.zones.apache.org:12000/continuum/servlet/continuum/target/ProjectBuild.vm/view/ProjectBuild/id/162/buildId/1310 Build statistics: State: Ok Previous State: Failed Started at: Fri, 2 Jun 2006 03:08:18 + Finished at: Fri, 2 Jun 2006 03:09:51 + Total ti

Re: Please review changes to WildcardHelper

2006-06-01 Thread Antonio Gallardo
Hi Carsten, I think we fixed a bug but got another. That is good, because by introducing a new test case for the new bug and fixing it, our code get better. Anyhow, here is how to see the new bug in the WildcardMatcher: 1- Open: http://cocoon.zones.apache.org/demos/21branch/ 2- Click on link

Re: Please review changes to WildcardHelper

2006-06-01 Thread Sylvain Wallez
Bruno Dumon wrote: > This won't be of much help, but I thought the wildcard matcher is > significantly faster than regexpes. > > PS: I like the idea of moving it to commons-lang. I've used it on > several occasions outside Cocoon. > Ditto. I even have a refactored version that returns a String[

Re: Please review changes to WildcardHelper

2006-06-01 Thread Torsten Curdt
> Yes, the wildcard matcher is indeed faster (although the question is if > it really makes a difference for the performance of the whole request). I _seem to remember_ that lng time ago Stefano did some profiling and one of the results was that in his test scenario about 10 % of the time was

Re: Please review changes to WildcardHelper

2006-06-01 Thread Reinhard Poetz
Carsten Ziegeler wrote: Yes, the wildcard matcher is indeed faster (although the question is if it really makes a difference for the performance of the whole request). I _seem to remember_ that lng time ago Stefano did some profiling and one of the results was that in his test scenario ab

Re: Please review changes to WildcardHelper

2006-06-01 Thread Bruno Dumon
On Thu, 2006-06-01 at 15:59 +0200, Carsten Ziegeler wrote: > Bruno Dumon wrote: > > On Thu, 2006-06-01 at 11:27 +0200, Carsten Ziegeler wrote: > >> I'm not sure if the code of the wildcard helper is correct at all; I > >> guess there are still other cases where the pattern does not match > >> altho

Re: Please review changes to WildcardHelper

2006-06-01 Thread Carsten Ziegeler
Bruno Dumon wrote: > On Thu, 2006-06-01 at 11:27 +0200, Carsten Ziegeler wrote: >> I'm not sure if the code of the wildcard helper is correct at all; I >> guess there are still other cases where the pattern does not match >> although it should. So I think we have to rewrite the code anyway. One >>

Re: Please review changes to WildcardHelper

2006-06-01 Thread Bruno Dumon
On Thu, 2006-06-01 at 11:27 +0200, Carsten Ziegeler wrote: > Hi, > > I just fixed the bug in our wildcard helper. The problem was the > following: if a pattern ends with a constant string (like ".xml") > and the uri in question contained this constant twice (like > ("hello.xml.xml") the pattern di

Re: Please review changes to WildcardHelper

2006-06-01 Thread Carsten Ziegeler
Reinhard Poetz wrote: > Great!!! I was wondering who really understands this class ;-) I'm happy that > it's at least one of us. Hehe, thanks for the compliments, but it took me some time to understand *parts* of it :) > > My following proposal might sound strange but I would like to see the >

Re: Please review changes to WildcardHelper

2006-06-01 Thread Reinhard Poetz
Carsten Ziegeler wrote: I just fixed the bug in our wildcard helper. The problem was the following: if a pattern ends with a constant string (like ".xml") and the uri in question contained this constant twice (like ("hello.xml.xml") the pattern did not match. I added a junit test case for this

Please review changes to WildcardHelper

2006-06-01 Thread Carsten Ziegeler
Hi, I just fixed the bug in our wildcard helper. The problem was the following: if a pattern ends with a constant string (like ".xml") and the uri in question contained this constant twice (like ("hello.xml.xml") the pattern did not match. I added a junit test case for this and now the tests all

Re: poi hssf-serializer built in limitation

2006-06-01 Thread Antonio Gallardo
Hi Marc, Jira is now our bug tracking system. Best Regards, Antonio Gallardo. Marc Portier escribió: Hi there, I've ran accross a hard-coded limit in our ms-excel-format serizalizer (and it looks like I'm the second one :-) http://issues.apache.org/bugzilla/show_bug.cgi?id=24490 ) $ find -