Re: [compress] zip64 writing seems to be broken

2015-01-04 Thread Stefan Bodewig
On 2015-01-04, Stefan Bodewig wrote: > I'll try to reproduce this as a unit test for compress later today, svn revision 1649312 - run via $ mvn test -Dtest=Zip64SupportIT#writeAndRead5GBOfZerosUsingZipFile I'll leave my box alone to run the whole suite of ZIP64 ITs (i.e. enable the run-zipit pr

Re: [compress] zip64 writing seems to be broken

2015-01-04 Thread Kristian Rosenvold
Not entirely unsurprisingly this broken in r1648585. I'll try to understand it tonight Kristia 2015-01-04 11:37 GMT+01:00 Stefan Bodewig : > On 2015-01-04, Stefan Bodewig wrote: > >> I'll try to reproduce this as a unit test for compress later today, > > svn revision 1649312 - run via > > $ mvn

Re: [math][dbcp][pool] Apachecon NA (Austin)

2015-01-04 Thread Luc Maisonobe
Hi all, Le 04/01/2015 02:07, Gilles a écrit : > On Fri, 02 Jan 2015 14:45:15 -0700, Phil Steitz wrote: >> I am thinking about submitting a proposal or two for Austin. I >> could update / extend the pool/dbcp talk I did last year or try a >> [math] talk. I would love to have company developing an

Re: [compress] zip64 writing seems to be broken

2015-01-04 Thread Stefan Bodewig
On 2015-01-04, Stefan Bodewig wrote: > I'll leave my box alone to run the whole suite of ZIP64 ITs (i.e. enable > the run-zipit profile) and report back later. Failed tests: Zip64SupportIT.write100KFilesFile:305->withTemporaryArchive:2342 arrays first differed at element [8]; expected:<52> bu

Re: [compress] zip64 writing seems to be broken

2015-01-04 Thread Stefan Bodewig
On 2015-01-04, Kristian Rosenvold wrote: > Not entirely unsurprisingly this broken in r1648585. I'll try to > understand it tonight I might find time before that, not sure, but I'll have a look myself as well. It might be a good idea to run the zip and tar ITs in some continuous build environmen

Re: [compress] zip64 writing seems to be broken

2015-01-04 Thread Stefan Bodewig
On 2015-01-04, Kristian Rosenvold wrote: > Not entirely unsurprisingly this broken in r1648585. I'll try to > understand it tonight getBytesWritten vs getTotalBytesWritten - svn revision 1649322 Maybe we should rename getBytesWritten to something like getBytesWrittenForLastEntry to make the diff

Re: [math][dbcp][pool] Apachecon NA (Austin)

2015-01-04 Thread Gilles
Hello. On Sun, 04 Jan 2015 12:09:35 +0100, Luc Maisonobe wrote: Hi all, Le 04/01/2015 02:07, Gilles a écrit : On Fri, 02 Jan 2015 14:45:15 -0700, Phil Steitz wrote: I am thinking about submitting a proposal or two for Austin. I could update / extend the pool/dbcp talk I did last year or try

Re: [compress] zip64 writing seems to be broken

2015-01-04 Thread Stefan Bodewig
On 2015-01-04, Stefan Bodewig wrote: > I'm just running all ITs again to be sure. Tests run: 79, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1,400.308 sec - in org.apache.commons.compress.archivers.zip.Zip64SupportIT Stefan -

Compiling and running examples [was [math][dbcp][pool] Apachecon NA (Austin))

2015-01-04 Thread sebb
On 4 January 2015 at 12:58, Gilles wrote: > Hello. > > On Sun, 04 Jan 2015 12:09:35 +0100, Luc Maisonobe wrote: >> >> Hi all, >> >> Le 04/01/2015 02:07, Gilles a écrit : >>> >>> >>> It reminded me that I had yet to improve one toy example in the >>> "src/userguide/java/org/apache/commons/math3/use

Re: help to setup license/notice files for JCS

2015-01-04 Thread Benedikt Ritter
Hi Romain, 2014-12-31 18:14 GMT+01:00 Romain Manni-Bucau : > Hi guys, > > anyone with a knowledge of [parent] pom could help me to setup > license/notice files in binaries/sources/javadoc jars? > > I added LICENSE.txt and NOTICE.txt in submodules but it doesnt pop up > in built jar. What do I mi

Re: [VALIDATOR] Working on the TLD list (Was: Re: [CANCEL][VOTE] Release Apache Commons Validator 1.4.1 based on RC2)

2015-01-04 Thread Benedikt Ritter
2015-01-03 19:32 GMT+01:00 sebb : > On 3 January 2015 at 12:34, Benedikt Ritter wrote: > > Hello Sebb, > > > > 2015-01-03 4:35 GMT+01:00 sebb : > > > >> I've made quite a bit of progress. > >> > >> However the IANA text file merges all the TLDs into one file - there > >> is no indication of wheth

Re: [VALIDATOR] Working on the TLD list (Was: Re: [CANCEL][VOTE] Release Apache Commons Validator 1.4.1 based on RC2)

2015-01-04 Thread Benedikt Ritter
2015-01-03 20:26 GMT+01:00 sebb : > I've just noticed VALIDATOR-297, which points out that the punycode > versions of the TLDs are not regarded as valid. > > I just added the Unicode versions, but perhaps I should have added the > punycode ones as well or instead? > > DomainVal. does not currently

Re: Announce: Commons Inject

2015-01-04 Thread Mark Struberg
Hi Jochen! The code is now indeed self-contained. I did not really look at the code but like to start with just a few small observations: 1.) the repo contains the whole eclipse project files. I'd rather remove those from the repos and add them (+ idea files) to svn:ignore. 2.) javax-inject.a

Re: Announce: Commons Inject

2015-01-04 Thread Benedikt Ritter
2015-01-04 17:57 GMT+01:00 Mark Struberg : > Hi Jochen! > > > The code is now indeed self-contained. I did not really look at the code > but like to start with just a few small observations: > > 1.) the repo contains the whole eclipse project files. I'd rather remove > those from the repos and add

Re: help to setup license/notice files for JCS

2015-01-04 Thread Romain Manni-Bucau
looked weaver but it basically redefines/skips what is done in pom. Wondered if I missed a way to not do it myself again. I'll go this way short term but if anyone has some time to have a look and find a shorter/better solution it is still welcomed! Romain Manni-Bucau @rmannibucau http://www.tom

Re: svn commit: r1649362 - /commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/scanlinefilters/

2015-01-04 Thread Thomas Neidhart
On 01/04/2015 06:07 PM, brit...@apache.org wrote: > Author: britter > Date: Sun Jan 4 17:07:51 2015 > New Revision: 1649362 > > URL: http://svn.apache.org/r1649362 > Log: > ScanlineFilter really is an interface there is usually a good reason to use an abstract class instead of an interface in ca

Re: [compress] zip64 writing seems to be broken

2015-01-04 Thread Kristian Rosenvold
Great stuff ! > getBytesWritten vs getTotalBytesWritten - svn revision 1649322 > > Maybe we should rename getBytesWritten to something like > getBytesWrittenForLastEntry to make the difference more obvious? I had hard time keeping those "written" counters correct - which you found out :) I renam

Jenkins build became unstable: commons-jcs » Apache Commons JCS :: Core #72

2015-01-04 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

Jenkins build became unstable: commons-jcs #72

2015-01-04 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

[Math] Maven profile for running the examples?

2015-01-04 Thread Gilles
Hi. In the "src/userguide/java" directory, there are a few self-contained usage examples. I think that we should have some way to 1. automatically compile its content (so that we can ensure that the source tree does not contain any non-compilable stuff) and 2. run selected classes (so that us

Re: svn commit: r1649362 - /commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/scanlinefilters/

2015-01-04 Thread Benedikt Ritter
Hello Thomas, 2015-01-04 18:37 GMT+01:00 Thomas Neidhart : > On 01/04/2015 06:07 PM, brit...@apache.org wrote: > > Author: britter > > Date: Sun Jan 4 17:07:51 2015 > > New Revision: 1649362 > > > > URL: http://svn.apache.org/r1649362 > > Log: > > ScanlineFilter really is an interface > > there

Re: svn commit: r1649362 - /commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/scanlinefilters/

2015-01-04 Thread Thomas Neidhart
On 01/04/2015 07:48 PM, Benedikt Ritter wrote: > Hello Thomas, > > 2015-01-04 18:37 GMT+01:00 Thomas Neidhart : > >> On 01/04/2015 06:07 PM, brit...@apache.org wrote: >>> Author: britter >>> Date: Sun Jan 4 17:07:51 2015 >>> New Revision: 1649362 >>> >>> URL: http://svn.apache.org/r1649362 >>> L

[IMAGING] Constant interfaces vs. constant classes

2015-01-04 Thread Benedikt Ritter
Hi all, imaging has a lot of constant interfaces and even the org.apache.commons.imaging.formats.tiff.constants.AllTagConstants interface which combine several interfaces. I'm in the "no constant interfaces" group. An interface should be used to, well, define an interface. Defining interfaces onl

Re: Announce: Commons Inject

2015-01-04 Thread Mark Struberg
>> http://repo1.maven.org/maven2/org/apache/geronimo/specs/geronimo-atinject_1.0_spec/1.0/ > > why? (just out of curiosity :-) dogfooding? :) The main reason why I always favour those geronimo-spec jar artifacts over their javax counterparts is that I can be 100% sure that they are IP clean and

Re: [IMAGING] Constant interfaces vs. constant classes

2015-01-04 Thread Gary Gregory
+1: Interfaces should be used to define contracts, not constants. I like using classes to define constants. Gary On Sun, Jan 4, 2015 at 1:58 PM, Benedikt Ritter wrote: > Hi all, > > imaging has a lot of constant interfaces and even the > org.apache.commons.imaging.formats.tiff.constants.AllTagC

Re: Announce: Commons Inject

2015-01-04 Thread Benedikt Ritter
2015-01-04 20:00 GMT+01:00 Mark Struberg : > >> > http://repo1.maven.org/maven2/org/apache/geronimo/specs/geronimo-atinject_1.0_spec/1.0/ > > > > why? (just out of curiosity :-) > > dogfooding? :) > > The main reason why I always favour those geronimo-spec jar artifacts over > their javax counterp

Re: svn commit: r1649362 - /commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/scanlinefilters/

2015-01-04 Thread Benedikt Ritter
2015-01-04 19:56 GMT+01:00 Thomas Neidhart : > On 01/04/2015 07:48 PM, Benedikt Ritter wrote: > > Hello Thomas, > > > > 2015-01-04 18:37 GMT+01:00 Thomas Neidhart : > > > >> On 01/04/2015 06:07 PM, brit...@apache.org wrote: > >>> Author: britter > >>> Date: Sun Jan 4 17:07:51 2015 > >>> New Revis

Re: svn commit: r1649362 - /commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/scanlinefilters/

2015-01-04 Thread Thomas Neidhart
On 01/04/2015 08:27 PM, Benedikt Ritter wrote: > 2015-01-04 19:56 GMT+01:00 Thomas Neidhart : > >> On 01/04/2015 07:48 PM, Benedikt Ritter wrote: >>> Hello Thomas, >>> >>> 2015-01-04 18:37 GMT+01:00 Thomas Neidhart : >>> On 01/04/2015 06:07 PM, brit...@apache.org wrote: > Author: britter

[IMAGING] Interfaces vs. abstract classes without logic (Was: Re: svn commit: r1649362 - /commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/scanlinefilters/)

2015-01-04 Thread Benedikt Ritter
*bringing this to a wider audience* Hi All, today I've committed some changes, that should probably have been discussed before. There were a few abstract classes in [imaging], which had no logic at all. They just defined abstract methods. I've changed this and replaced these abstract classes wit

Re: [Math] Maven profile for running the examples?

2015-01-04 Thread Phil Steitz
> On Jan 4, 2015, at 11:21 AM, Gilles wrote: > > Hi. > > In the "src/userguide/java" directory, there are a few > self-contained usage examples. > > I think that we should have some way to > 1. automatically compile its content (so that we can ensure that the > source tree does not contai

Re: [IMAGING] Constant interfaces vs. constant classes

2015-01-04 Thread sebb
+1 On 4 January 2015 at 19:15, Gary Gregory wrote: > +1: Interfaces should be used to define contracts, not constants. I like > using classes to define constants. > > Gary > > On Sun, Jan 4, 2015 at 1:58 PM, Benedikt Ritter wrote: > >> Hi all, >> >> imaging has a lot of constant interfaces and e

Jenkins build is still unstable: commons-jcs #73

2015-01-04 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

Jenkins build is still unstable: commons-jcs » Apache Commons JCS :: Core #73

2015-01-04 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

Re: [Math] Maven profile for running the examples?

2015-01-04 Thread Luc Maisonobe
Le 04/01/2015 21:05, Phil Steitz a écrit : > > > > >> On Jan 4, 2015, at 11:21 AM, Gilles wrote: >> >> Hi. >> >> In the "src/userguide/java" directory, there are a few >> self-contained usage examples. >> >> I think that we should have some way to >> 1. automatically compile its content (so th

Re: [Math] Maven profile for running the examples?

2015-01-04 Thread sebb
Did you see my mail from earlier today titled as below ? Compiling and running examples This explains how Commons NET examples are built and used. On 4 January 2015 at 18:21, Gilles wrote: > Hi. > > In the "src/userguide/java" directory, there are a few > self-contained usage examples. > > I th

Re: [dbcp] Preparing 2.1

2015-01-04 Thread Thomas Neidhart
On 01/04/2015 01:28 AM, Phil Steitz wrote: > There are just a few issues open for 2.1. I have DBCP-424 about > done using the approach on the last comment on that ticket. > Patches, comments or commits for DBCP-423, 427 are welcome. One > other thing that would be nice to clean up for this relea

[VOTE][JCS] release [jcs] 2.0-beta-1 (take 3)

2015-01-04 Thread Romain Manni-Bucau
Hi Another try with license/notice files - here is the maven repo: https://repository.apache.org/content/repositories/orgapachecommons-1074/ - assemblies can be found here https://repository.apache.org/content/repositories/orgapachecommons-1074/org/apache/commons/commons-jcs-dist/2.0-beta-1/ - ta

Re: [math][dbcp][pool] Apachecon NA (Austin)

2015-01-04 Thread Phil Steitz
On 1/4/15 5:58 AM, Gilles wrote: > Hello. > > On Sun, 04 Jan 2015 12:09:35 +0100, Luc Maisonobe wrote: >> Hi all, >> >> Le 04/01/2015 02:07, Gilles a écrit : >>> On Fri, 02 Jan 2015 14:45:15 -0700, Phil Steitz wrote: I am thinking about submitting a proposal or two for Austin. I could up

Re: [dbcp] Preparing 2.1

2015-01-04 Thread Phil Steitz
On 1/4/15 2:15 PM, Thomas Neidhart wrote: > On 01/04/2015 01:28 AM, Phil Steitz wrote: >> There are just a few issues open for 2.1. I have DBCP-424 about >> done using the approach on the last comment on that ticket. >> Patches, comments or commits for DBCP-423, 427 are welcome. One >> other thi

[VALIDATOR] Ready for 1.4.1 RC3?

2015-01-04 Thread Benedikt Ritter
Hi all, there have been some fixes in the last few days (mostly thanks to sebb) and my feeling is, that we're ready to cut 1.4.1 RC3. If there is something left you would like to add, then please let me know. Otherwise I'll cut RC3 tonight or tomorrow. Regards, Benedikt -- http://people.apache.