Re: [compress] Preparations for 1.10

2015-01-24 Thread Stefan Bodewig
On 2015-01-24, Kristian Rosenvold wrote: > After an intense few minutes discussing the color of the bike shed > with myself (package name) I moved the zip-unspecific parallel stuff > to org.apache.commons.compress.parallel in r1654572. Maybe add a package-info.java? I'll need to add one to the e

Re: [compress] Preparations for 1.10

2015-01-24 Thread Stefan Bodewig
On 2015-01-24, Kristian Rosenvold wrote: > I suppose the "what's new section" on the site also needs to be > updated to 1.10 ? Yes, that would be good. > Anything else I can assist with before the release ? Thanks. I intend to spend a bit of time with BitInputStream and cut the RC tomorrow, at

Re: [VOTE][JCS] release [jcs] 2.0-beta-1 (take 3)

2015-01-24 Thread Romain Manni-Bucau
Up^2? didnt move since almost 20 days :( Romain Manni-Bucau @rmannibucau http://www.tomitribe.com http://rmannibucau.wordpress.com https://github.com/rmannibucau 2015-01-18 21:45 GMT+01:00 Romain Manni-Bucau : > Up? > > Le 5 janv. 2015 20:18, "Benedikt Ritter" a écrit : > >> 2015-01-05 20:09

Re: [collections] Revert a performance related fix in 4.1

2015-01-24 Thread Phil Steitz
On 1/24/15 1:16 PM, Oliver Heger wrote: > Hi Thomas, > > On 24.01.2015 19:21, Thomas Neidhart wrote: >> Hi, >> >> from time to time some researchers trying to find performance >> bugs in >> open-source software create issues for collections. >> >> One of the easy targets is the Collection#retainAll

Re: [collections] Revert a performance related fix in 4.1

2015-01-24 Thread Oliver Heger
Hi Thomas, On 24.01.2015 19:21, Thomas Neidhart wrote: Hi, from time to time some researchers trying to find performance bugs in open-source software create issues for collections. One of the easy targets is the Collection#retainAll(Collection) method as the default implementation in AbstractC

Re: [compress] Preparations for 1.10

2015-01-24 Thread Kristian Rosenvold
After an intense few minutes discussing the color of the bike shed with myself (package name) I moved the zip-unspecific parallel stuff to org.apache.commons.compress.parallel in r1654572. This concludes the changes Emmanuel suggested. I have already responded to a few of the comments that did not

Re: [collections] Revert a performance related fix in 4.1

2015-01-24 Thread Adrian Crum
Slightly off-topic but somewhat related... I saw a recent commit where a "performance improvement" went something like this: StringBuilder sb = new StringBuilder(); sb.append("foo"); was replaced with StringBuilder sb = new StringBuilder("foo"); The change reduced the code by one line, but

[collections] Revert a performance related fix in 4.1

2015-01-24 Thread Thomas Neidhart
Hi, from time to time some researchers trying to find performance bugs in open-source software create issues for collections. One of the easy targets is the Collection#retainAll(Collection) method as the default implementation in AbstractCollection calls contains on the provided collection. Now,

[GitHub] commons-collections pull request: COLLECTIONS-550

2015-01-24 Thread gonmarques
GitHub user gonmarques opened a pull request: https://github.com/apache/commons-collections/pull/7 COLLECTIONS-550 [COLLECTIONS-550] Provide a simple way for creating an arbitrary String representation of a given Iterable You can merge this pull request into a Git repository by run

[GitHub] commons-collections pull request: Removing unnecessary method from...

2015-01-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-collections/pull/2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

Re: [ALL] Time for CP 37?

2015-01-24 Thread sebb
I think I've solved the issue with the icu class. I had mistakenly added animal-sniffer to the test phase, however it defaults to process-classes. This phase occurs before the test phase when it appears that cobertura updates the classpath. So now animal-sniffer does not see ICU (read that aloud

Re: [ALL] Time for CP 37?

2015-01-24 Thread sebb
Looks like the cobertura plugin is one source of the bad icu dependency This works: mvn site -Psite-basic This causes animal sniffer to fail mvn site -Psite-basic -Dcobertura.skip=false On 24 January 2015 at 13:13, sebb wrote: > I get the problem as well with mvn site. > > It looks like additi

Re: [ALL] Time for CP 37?

2015-01-24 Thread sebb
I get the problem as well with mvn site. It looks like additional jars are added to the classpath when the site phase is specified. I don't think animal sniffer should be considering them, but that may be a Maven plugin restriction rather than a bug in animal sniffer. I am a bit wary of unconditi

Re: [compress] Preparations for 1.10

2015-01-24 Thread Stefan Bodewig
On 2015-01-23, Emmanuel Bourg wrote: > Le 22/01/2015 17:30, Stefan Bodewig a écrit : >> Please have a look and identify stuff that looks as if I'd have to >> reroll a new RC should it come to a vote with the current code base. > I reviewed the API changes, here are my comments: > - PasswordRequ

Re: svn commit: r1654500 - in /commons/proper/validator/trunk/src: changes/ main/java/org/apache/commons/validator/routines/ test/java/org/apache/commons/validator/routines/

2015-01-24 Thread sebb
On 24 January 2015 at 12:01, wrote: > Author: britter > Date: Sat Jan 24 12:01:20 2015 > New Revision: 1654500 > > URL: http://svn.apache.org/r1654500 > Log: > VALIDATOR-358: Underscores in domain names are not supported. This fixes #3 > from github. Thanks to Nykolas Laurentino de Lima. -1 Th

Re: [bcel] new to list - introduction

2015-01-24 Thread Benedikt Ritter
2015-01-23 20:55 GMT+01:00 Mark Roberts : > My name is Mark Roberts and I work in the Programming Languages and > Software Engineering group (PLSE) at the University of Washington. ( > http://www.cs.washington.edu/research/plse) > > Our team develops and supports a number of open source tools. On

[GitHub] commons-validator pull request: supporting emails and URL's domain...

2015-01-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-validator/pull/3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

Re: [ALL] Time for CP 37?

2015-01-24 Thread Benedikt Ritter
2015-01-24 13:05 GMT+01:00 Benedikt Ritter : > > > 2015-01-23 16:39 GMT+01:00 sebb : > >> On 23 January 2015 at 14:52, Benedikt Ritter wrote: >> > 2015-01-23 15:10 GMT+01:00 sebb : >> > >> >> On 23 January 2015 at 13:48, Benedikt Ritter >> wrote: >> >> > 2015-01-23 14:20 GMT+01:00 sebb : >> >> >

Re: [ALL] Time for CP 37?

2015-01-24 Thread Benedikt Ritter
2015-01-23 16:39 GMT+01:00 sebb : > On 23 January 2015 at 14:52, Benedikt Ritter wrote: > > 2015-01-23 15:10 GMT+01:00 sebb : > > > >> On 23 January 2015 at 13:48, Benedikt Ritter > wrote: > >> > 2015-01-23 14:20 GMT+01:00 sebb : > >> > > >> >> I think it's probably time to release Commons Paren