Re: [rng] New "checkstyle" config is checking "src/test"

On Thu, Aug 18, 2016 at 2:20 AM, Gilles wrote: > It's something related to the plain >>> checkstyle:checkstyle >>> target. >>> >> >> >> ​Added a rule to skip these files, looks better now.​ >> > > But why was it working fine with "mvn site"? ​Still reading about

Re: [rng] New "checkstyle" config is checking "src/test"

On Thu, 18 Aug 2016 02:12:21 +0300, Artem Barger wrote: On Thu, Aug 18, 2016 at 1:45 AM, Gilles wrote: It's something related to the plain checkstyle:checkstyle target. ​Added a rule to skip these files, looks better now.​ But why was it working fine with

Re: [rng] New "checkstyle" config is checking "src/test"

On Thu, Aug 18, 2016 at 1:45 AM, Gilles wrote: > > It's something related to the plain > checkstyle:checkstyle > target. ​Added a rule to skip these files, looks better now.​ Best regards, Artem Barger.

Re: [rng] New "checkstyle" config is checking "src/test"

On Thu, 18 Aug 2016 01:32:04 +0300, Artem Barger wrote: On Thu, Aug 18, 2016 at 1:30 AM, Gilles wrote: They are not the "src/main/java" directory; why would they be scanned? Looks like a Mac problem... Perhaps ask in a new ML thread. ​Look at Jenkins, not

Re: [rng] Checkstyle on Jenkins

On Thu, Aug 18, 2016 at 1:36 AM, Gilles wrote: > >> /Users/bartem/sandbox/commons-rng/LICENSE.txt:1: error: Line does not >> match >> expected header line of '/*'. >> /Users/bartem/sandbox/commons-rng/NOTICE.txt:1: error: Missing a header - >> not enough lines in

Re: [rng] New "checkstyle" config is checking "src/test"

On Thu, Aug 18, 2016 at 1:30 AM, Gilles wrote: > They are not the "src/main/java" directory; why would they be scanned? > > Looks like a Mac problem... > Perhaps ask in a new ML thread. > ​Look at Jenkins, not sure why these files scanned, but on Jenkins there is

[rng] Checkstyle on Jenkins

Hi. On Thu, 18 Aug 2016 01:11:16 +0300, Artem Barger wrote: On Thu, Aug 18, 2016 at 1:12 AM, Gilles wrote: I have zero here. What are the errors you get? /Users/bartem/sandbox/commons-rng/LICENSE.txt:1: error: Line does not match expected header line of

Re: [rng] New "checkstyle" config is checking "src/test"

On Thu, 18 Aug 2016 01:11:16 +0300, Artem Barger wrote: On Thu, Aug 18, 2016 at 1:12 AM, Gilles wrote: I have zero here. What are the errors you get? /Users/bartem/sandbox/commons-rng/LICENSE.txt:1: error: Line does not match expected header line of '/*'.

Re: [rng] New "checkstyle" config is checking "src/test"

On Thu, Aug 18, 2016 at 1:12 AM, Gilles wrote: > > I have zero here. > What are the errors you get? /Users/bartem/sandbox/commons-rng/LICENSE.txt:1: error: Line does not match expected header line of '/*'. /Users/bartem/sandbox/commons-rng/NOTICE.txt:1: error:

Re: [rng] New "checkstyle" config is checking "src/test"

On Thu, 18 Aug 2016 00:53:14 +0300, Artem Barger wrote: On Thu, Aug 18, 2016 at 12:51 AM, Artem Barger wrote: he "test" part of the source code need not have the same level of cleanliness as the "main" part. It was not usually scanned by checkstyle, which now outputs many

Re: [rng] New "checkstyle" config is checking "src/test"

On Thu, 18 Aug 2016 00:51:23 +0300, Artem Barger wrote: On Thu, Aug 18, 2016 at 12:48 AM, Gilles wrote: The "test" part of the source code need not have the same level of cleanliness as the "main" part. It was not usually scanned by checkstyle, which now outputs

Re: [rng] New "checkstyle" config is checking "src/test"

On Thu, Aug 18, 2016 at 12:51 AM, Artem Barger wrote: > he "test" part of the source code need not have the same level >> of cleanliness as the "main" part. >> It was not usually scanned by checkstyle, which now outputs >> many spurious errors. >> > > ​Well, test code is also a

Re: [rng] New "checkstyle" config is checking "src/test"

On Thu, Aug 18, 2016 at 12:48 AM, Gilles wrote: > The "test" part of the source code need not have the same level > of cleanliness as the "main" part. > It was not usually scanned by checkstyle, which now outputs > many spurious errors. > ​Well, test code is also a

[GitHub] commons-bcel pull request #11: BCEL-278: Resolving NoSuchElementException

GitHub user valery-barysok opened a pull request: https://github.com/apache/commons-bcel/pull/11 BCEL-278: Resolving NoSuchElementException You can merge this pull request into a Git repository by running: $ git pull https://github.com/valery-barysok/commons-bcel trunk

[rng] New "checkstyle" config is checking "src/test"

Artem, The "test" part of the source code need not have the same level of cleanliness as the "main" part. It was not usually scanned by checkstyle, which now outputs many spurious errors. Regards, Gilles - To unsubscribe,

Re: [rng] Re: commons-rng git commit: Do not output checkstyle error to the console.

On Thu, Aug 18, 2016 at 12:38 AM, Gilles wrote: > >> Artem, >>> >>> You have introduced spurious blank spaces. >>> >>> >> ​Actually I've removed them.​ >> > > Ah, OK. Sorry; I had the "diff" arguments in revers order. > > Anyways, when you do that, do it in a

Re: [rng] Re: commons-rng git commit: Do not output checkstyle error to the console.

On Thu, 18 Aug 2016 00:25:15 +0300, Artem Barger wrote: On Thu, Aug 18, 2016 at 12:17 AM, Gilles wrote: Artem, You have introduced spurious blank spaces. ​Actually I've removed them.​ Ah, OK. Sorry; I had the "diff" arguments in revers order. Anyways,

Re: [rng] Re: commons-rng git commit: Add checkstyle plugin configuration, to read project checkstyle.xml

On Thu, Aug 18, 2016 at 12:21 AM, Gilles wrote: > Please check that you do not introduce unwanted formatting changes. > In this commit, the tabulation setting is different from the rest > of the file. > ​Committed fixes into "checkstyle" branch, can you please

Re: [rng] Re: commons-rng git commit: Do not output checkstyle error to the console.

On Thu, Aug 18, 2016 at 12:17 AM, Gilles wrote: > Artem, > > You have introduced spurious blank spaces. > ​Actually I've removed them.​ > > You should perform > $ git diff --check > > You committed a file ("checkstyle.xml") unrelated to the > commit message... >

Re: [rng] Re: commons-rng git commit: Add checkstyle plugin configuration, to read project checkstyle.xml

On Thu, Aug 18, 2016 at 12:21 AM, Gilles wrote: > Artem, > > Please check that you do not introduce unwanted formatting changes. > In this commit, the tabulation setting is different from the rest > of the file. > ​Thanks, will fix it.​ Best regards,

[rng] Re: commons-rng git commit: Add checkstyle plugin configuration, to read project checkstyle.xml

Artem, Please check that you do not introduce unwanted formatting changes. In this commit, the tabulation setting is different from the rest of the file. Regards, Gilles On Wed, 17 Aug 2016 20:49:06 + (UTC), bar...@apache.org wrote: Repository: commons-rng Updated Branches:

[rng] Re: commons-rng git commit: Do not output checkstyle error to the console.

Artem, You have introduced spurious blank spaces. You should perform $ git diff --check You committed a file ("checkstyle.xml") unrelated to the commit message... Regards, Gilles On Wed, 17 Aug 2016 21:00:17 + (UTC), bar...@apache.org wrote: Repository: commons-rng Updated Branches:

Re: [Website] download link could not redirect consistently

On 17 August 2016 at 17:07, sebb wrote: > On 17 August 2016 at 16:38, sebb wrote: >> On 5 August 2016 at 10:34, Sun, Dapeng wrote: >>> Hello >>> >>> The following link cannot redirect. Anyone know the reason about it? >>>

Re: [Website] download link could not redirect consistently

On 17 August 2016 at 16:38, sebb wrote: > On 5 August 2016 at 10:34, Sun, Dapeng wrote: >> Hello >> >> The following link cannot redirect. Anyone know the reason about it? >> https://commons.apache.org/crypto/download_crypto.cgi >> It should redirect to

Re: [Website] download link could not redirect consistently

On 5 August 2016 at 10:34, Sun, Dapeng wrote: > Hello > > The following link cannot redirect. Anyone know the reason about it? > https://commons.apache.org/crypto/download_crypto.cgi > It should redirect to >

Re: [RNG] Checkstyle

On Wed, Aug 17, 2016 at 3:55 PM, Brent Worden wrote: > It appears is it not using the correct checkstyle ruleset. From the build > output: > > [INFO] *--- maven-checkstyle-plugin:2.17:checkstyle (default-cli) @ > commons-rng --- > *[INFO] There are 702 errors reported by

Re: [RNG] Checkstyle

It appears is it not using the correct checkstyle ruleset. From the build output: [INFO] *--- maven-checkstyle-plugin:2.17:checkstyle (default-cli) @ commons-rng --- *[INFO] There are 702 errors reported by Checkstyle 6.11.2 with sun_checks.xml ruleset. Brent On Wed, Aug 17, 2016 at 5:40 AM,

Re: [rng] JARs with different dependencies within the same component?

On Wed, 17 Aug 2016 00:42:47 +0200, Jörg Schaible wrote: Gilles wrote: On Tue, 16 Aug 2016 15:53:44 +0300, Artem Barger wrote: On Tue, Aug 16, 2016 at 3:00 PM, Gilles wrote: That's what I was afraid of; in this case, it would defeat the purpose: We shouldn't

Re: [RNG] Checkstyle

On Wed, 17 Aug 2016 09:43:41 +0300, Artem Barger wrote: Hi, I've enabled checkstyle Jenkins plugin and executed checkstyle plugin on the current code base and it resulted in a lot of high priority warning see here:

RE: [Website] download link could not redirect consistently

Thank Benedikt for your help, and I have updated crypto/download_crypto.cgi to proper/commons-crypto/download_crypto.cgi as a workround. Regards Dapeng -Original Message- From: Benedikt Ritter [mailto:brit...@apache.org] Sent: Wednesday, August 17, 2016 3:02 AM To: Commons Developers

RE: commons-crypto git commit: CRYPTO-122: Fix CRYPTO website after 1.0.0

Hi Benedikt, Thank you for your review and suggestion, I think the commit is mainly fixing some typos and error links, I will also pay attention to the formatting. Welcome back :) Regards Dapeng -Original Message- From: Benedikt Ritter [mailto:brit...@apache.org] Sent: Wednesday,

Re: [RESULT][VOTE] Release Configuration 2.1 based on RC3

If it's a majority win vote and if my vote counts +1 from me too. On Tue, Aug 16, 2016 at 6:33 PM, Gary Gregory wrote: > You can wait and ask for more reviews too... > > Gary > > On Tue, Aug 16, 2016 at 12:40 PM, Oliver Heger < > oliver.he...@oliver-heger.de > > wrote: >

[RNG] Checkstyle

Hi, I've enabled checkstyle Jenkins plugin and executed checkstyle plugin on the current code base and it resulted in a lot of high priority warning see here: https://builds.apache.org/view/Apache%20Commons/job/Commons_Rng/14/checkstyleResult/HIGH/ Now, I'm wondering whenever it gets a wrong

Re: commons-crypto git commit: CRYPTO-122: Fix CRYPTO website after 1.0.0

Hello Dapeng, it looks like this commit contains a lot of unrelated formatting changes. Keeping change sets small an focused makes it easier for others to review the changes. Thank you! Benedikt schrieb am Mi., 17. Aug. 2016 um 03:43 Uhr: > Repository: commons-crypto >