Re: [apache/commons-text] [TEXT-102] StrLookup.resourceBundleLookup(ResourceBundle). Make new (0b06169)

2017-09-23 Thread Pascal Schumacher
Thank you very much. Sadly there are still two violations: [INFO] There are 2 checkstyle errors. [ERROR] StrLookup.java[179] (design) FinalClass: Class ResourceBundleLookup should be declared as final. [ERROR] StrLookup.java[181:9] (javadoc) JavadocVariable: Missing a Javadoc comment. see: h

Re: [All][RNG] Generate signatures and checksums

2017-09-23 Thread Stefan Bodewig
On 2017-09-21, Gilles wrote: > On Thu, 21 Sep 2017 07:47:07 +0200, Stefan Bodewig wrote: >> On 2017-09-20, Gilles wrote: >>> [...] Unfortunately I cannot answer the question about signatures for modular builds, I'm not really a maven person. What I can say is that I never >>>

Re: [All][RNG] Generate signatures and checksums

2017-09-23 Thread Gilles
On Sat, 23 Sep 2017 11:13:04 +0200, Stefan Bodewig wrote: On 2017-09-21, Gilles wrote: On Thu, 21 Sep 2017 07:47:07 +0200, Stefan Bodewig wrote: On 2017-09-20, Gilles wrote: [...] Unfortunately I cannot answer the question about signatures for modular builds, I'm not really a maven perso

Re: [apache/commons-text] [TEXT-102] StrLookup.resourceBundleLookup(ResourceBundle). Make new (0b06169)

2017-09-23 Thread Gary Gregory
Back to green! :-) https://travis-ci.org/apache/commons-text Gary On Sat, Sep 23, 2017 at 2:15 AM, Pascal Schumacher wrote: > > Thank you very much. Sadly there are still two violations: > > [INFO] There are 2 checkstyle errors. > [ERROR] StrLookup.java[179] (design) FinalClass: Class > Resourc

[text] Release 1.2

2017-09-23 Thread Gary Gregory
Hi All: I'd like to see Apache Commons Text 1.2 out. We have a stack of changes [1] waiting. - If you'd like to volunteer to RM, please do so :-) - If you have some fixes, consider putting them in now. - I might have the time to RM an RC this weekend, not 100% sure on my avail. Gary [1] From ch

Re: [apache/commons-text] [TEXT-102] StrLookup.resourceBundleLookup(ResourceBundle). Make new (0b06169)

2017-09-23 Thread Pascal Schumacher
Thanks! :) Am 23.09.2017 um 16:13 schrieb Gary Gregory: Back to green! :-) https://travis-ci.org/apache/commons-text Gary On Sat, Sep 23, 2017 at 2:15 AM, Pascal Schumacher wrote: Thank you very much. Sadly there are still two violations: [INFO] There are 2 checkstyle errors. [ERROR] StrLook

Re: [apache/commons-text] [TEXT-102] StrLookup.resourceBundleLookup(ResourceBundle). Make new (0b06169)

2017-09-23 Thread Gary Gregory
Amazing what happens when I actually run the Checkstyle plugin myself ;-) Gary On Sat, Sep 23, 2017 at 9:34 AM, Pascal Schumacher wrote: > Thanks! :) > > Am 23.09.2017 um 16:13 schrieb Gary Gregory: > >> Back to green! :-) https://travis-ci.org/apache/commons-text >> >> Gary >> >> On Sat, Sep 2

Re: [VOTE] Release commons-jelly-1.0.1 based on RC6

2017-09-23 Thread Gary Gregory
Tally time! :-) On Wed, Sep 20, 2017 at 7:36 AM, Rob Tompkins wrote: > Hello, > > Commons Jelly 1.0.1 RC6 is available for review here: > https://dist.apache.org/repos/dist/dev/commons/jelly (svn revision > 21718) > > The tag is here (tag commit 1808993): > https://svn.apache.org/repos/asf/c

[VOTE] Release Apache Commons VFS 2.2 from RC1.

2017-09-23 Thread Gary Gregory
We have fixed quite a few bugs and added some significant enhancements since Apache Commons VFS 2.1 was released, so I would like to release Apache Commons VFS 2.2. Apache Commons VFS 2.2 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/vfs/ (svn revision 21925)

Re: [text] Release 1.2

2017-09-23 Thread Amey Jadiye
I wish to see TEXT-101 part of release which will settle down many enquiries from user-dl about RandomStringUtils without releasing commons-lang 3.6.1. I have open PR for it, may be you or Rob have to check that. Regards, Amey On Sat, Sep 23, 2017 at 8:53 PM, Gary Gregory wrote: > Hi All: > > I

Re: [apache/commons-text] [TEXT-102] StrLookup.resourceBundleLookup(ResourceBundle). Make new (0b06169)

2017-09-23 Thread Amey Jadiye
I usually keep the practice of running just `mvn` (which indeed run clean verify apache-rat:check clirr:check checkstyle:check findbugs:check javadoc:javadoc) and if that's fine my submitted PR is always and 100% looks green. Regards, Amey On Sat, Sep 23, 2017 at 9:06 PM, Gary Gregory wrote: >

[GitHub] commons-text issue #63: small-code-quality-improvements

2017-09-23 Thread TheRealHaui
Github user TheRealHaui commented on the issue: https://github.com/apache/commons-text/pull/63 @chtompki If you want me to re-push any minor change to re-trigger the build just tell. --- - To unsubscribe, e-mai

Re: [VOTE] Release Apache Commons VFS 2.2 from RC1.

2017-09-23 Thread Bernd Eckenfels
Have no computer access for a couple more days so I can't verify with the needed due diligence, but thank you for the work, thumbs up. In case the vote last till Friday I might be able to vote. Gruss Bernd -- http://bernd.eckenfels.net From: Gary Gregory Sent: S

[GitHub] commons-text issue #63: small-code-quality-improvements

2017-09-23 Thread TheRealHaui
Github user TheRealHaui commented on the issue: https://github.com/apache/commons-text/pull/63 Well, of course! And much, much, much more in Java! --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org

[GitHub] commons-text issue #63: small-code-quality-improvements

2017-09-23 Thread TheRealHaui
Github user TheRealHaui commented on the issue: https://github.com/apache/commons-text/pull/63 :-) --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.ap

[GitHub] commons-rdf issue #39: COMMONSRDF-62 : Ignore japicmp by default while versi...

2017-09-23 Thread wikier
Github user wikier commented on the issue: https://github.com/apache/commons-rdf/pull/39 LGTM --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.

[GitHub] commons-text pull request #63: small-code-quality-improvements

2017-09-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-text/pull/63 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #63: small-code-quality-improvements

2017-09-23 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/63 Merged in : https://github.com/apache/commons-text/commit/5598109efb2365384b9a9110323ed9a7004cc905 Thanks! --- - T

[GitHub] commons-cli issue #16: added findbug and checkstyle support while building

2017-09-23 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-cli/pull/16 As I said before this can not be merged as it is, because it fails on java 6. The simple fix of just downgrading the findbugs version can not be applied, because 2.x versions do

[GitHub] commons-cli issue #16: added findbug and checkstyle support while building

2017-09-23 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-cli/pull/16 As I said before this can not be merged as it is, because it fails on java 6. The simple fix of just downgrading the findbugs version can not be applied, because 2.x versions do

[GitHub] commons-text issue #63: small-code-quality-improvements

2017-09-23 Thread TheRealHaui
Github user TheRealHaui commented on the issue: https://github.com/apache/commons-text/pull/63 You're welcome. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h..

Re: [VOTE] Release Apache Commons VFS 2.2 from RC1.

2017-09-23 Thread Gary Gregory
On Sat, Sep 23, 2017 at 12:21 PM, Bernd Eckenfels wrote: > Have no computer access for a couple more days so I can't verify with the > needed due diligence, but thank you for the work, thumbs up. > > In case the vote last till Friday I might be able to vote. > Hi Bernd, I hope we can reach a qu

Re: [VOTE] Release commons-jelly-1.0.1 based on RC6

2017-09-23 Thread Rob Tompkins
Here’s my +1. > On Sep 23, 2017, at 11:37 AM, Gary Gregory wrote: > > Tally time! :-) > > On Wed, Sep 20, 2017 at 7:36 AM, Rob Tompkins wrote: > >> Hello, >> >> Commons Jelly 1.0.1 RC6 is available for review here: >> https://dist.apache.org/repos/dist/dev/commons/jelly (svn revision >> 217

[RESULT][VOTE] Release commons-jelly-1.0.1 based on RC6

2017-09-23 Thread Rob Tompkins
The following votes were case: Gary Gregory +1 (binding) Oliver Heger +1 (binding) Rob Tompkins +1 (binding) Thus, the vote passes. Many thanks to all who voted. I will proceed with the release processing. > On Sep 20, 2017, at 9:36 AM, Rob Tompkins wrote: > > Hello, > > Commons Jelly 1.0.1