Re: [VOTE] Release Apache Commons Validator 1.7 based on RC2

2020-08-03 Thread sebb
On Sun, 2 Aug 2020 at 22:16, sebb wrote: > > On Sun, 2 Aug 2020 at 19:27, Gary Gregory wrote: > > > > On Sun, Aug 2, 2020 at 12:00 PM sebb wrote: > > > > > On Sun, 2 Aug 2020 at 14:13, Gary Gregory wrote: > > > > > > > > -1: I do not think we should release when a test breaks on Java 11, an > >

Re: [LAZY][VOTE] Release Apache Commons Parent 52 based on RC1

2020-08-03 Thread Rob Tompkins
Here’s my +1. -Rob > On Jul 30, 2020, at 1:50 PM, Rob Tompkins wrote: > > We have fixed quite a few bugs and added some significant enhancements since > Apache Commons Parent ${commons.bc.version} was released, so I would like to > release Apache Commons Parent 52. > > Apache Commons Parent

[RESULT][LAZY][VOTE] Release Apache Commons Parent 52 based on RC1

2020-08-03 Thread Rob Tompkins
This [VOTE] passes with +1’s from Gary Gregory, and Rob Tompkins. Given no opposition, and the fact that it was a [LAZY][VOTE], it indeed passes. I will begin with the release procedure shortly. Cheers, -Rob > On Jul 30, 2020, at 1:50 PM, Rob Tompkins wrote: > > We have fixed quite a few bu

Re: [VOTE] Release Apache Commons Validator 1.7 based on RC2

2020-08-03 Thread Gary Gregory
The changes made to master now lets the build pass on OpenJDK 11 and Oracle JDK 11. I think we should roll an RC3 with these changes. Gary On Mon, Aug 3, 2020 at 6:23 AM sebb wrote: > On Sun, 2 Aug 2020 at 22:16, sebb wrote: > > > > On Sun, 2 Aug 2020 at 19:27, Gary Gregory > wrote: > > > >

[ALL] Commons Parent RAT check: change to verify phase?

2020-08-03 Thread sebb
RAT is currently run during the validate phase, which is very early in the cycle. I think that is a nuisance, as it gets in the way of local testing. Any new file has to have an AL header, or you have to remember to use -Drat.skip. This makes it harder to use test cases, e.g. provided in bug repor

Re: [VOTE] Release Apache Commons Validator 1.7 based on RC2

2020-08-03 Thread Matt Sicker
One of the main changes in that Surefire release was native support for JUnit 5. I was just using that yesterday on Log4j2. On Mon, Aug 3, 2020 at 08:19 Gary Gregory wrote: > The changes made to master now lets the build pass on OpenJDK 11 and Oracle > JDK 11. > > I think we should roll an RC3 w

Re: [ALL] Commons Parent RAT check: change to verify phase?

2020-08-03 Thread Gary Gregory
I think it is also fine to not force feed it in a component's Maven lifecycle as long as it is listed in the defaultGoal element for that POM. Maybe that would make a POM slightly less unwieldy. Gary On Mon, Aug 3, 2020 at 9:37 AM sebb wrote: > RAT is currently run during the validate phase, w

Re: [ALL] Commons Parent RAT check: change to verify phase?

2020-08-03 Thread Rob Tompkins
Indifferent. Though, I personally like forcing as much of the build/validation into the developer’s machine in a default way as possible. :-p -Rob > On Aug 3, 2020, at 9:51 AM, Gary Gregory wrote: > > I think it is also fine to not force feed it in a component's Maven > lifecycle as long as it

Re: [crypto] Releasing 1.1.0 with Mac64 support

2020-08-03 Thread Geoffrey Blake
Hi Gary, has a solution for the Mac build been reached? Do you require some assistance here? As Bindul suggested, Travis has support for uploading artifacts to AWS S3: https://docs.travis-ci.com/user/uploading-artifacts/ This may alleviate the issue with accepting an unknown artifact, and with

[CANCELLED][VOTE] Release Apache Commons Validator 1.7 based on RC2

2020-08-03 Thread sebb
CANCELLED due to issues with Surefire plugin. New VOTE to follow soon. On Mon, 3 Aug 2020 at 14:41, Matt Sicker wrote: > > One of the main changes in that Surefire release was native support for > JUnit 5. I was just using that yesterday on Log4j2. > > On Mon, Aug 3, 2020 at 08:19 Gary Gregory w

[OFF-LIST][CANCELLED][VOTE] Release Apache Commons Validator 1.7 based on RC2

2020-08-03 Thread Rob Tompkins
I’m happy to roll RC3 if you want another set of hands in there….less busy work for you. -Rob > On Aug 3, 2020, at 12:48 PM, sebb wrote: > > CANCELLED due to issues with Surefire plugin. > New VOTE to follow soon. > > On Mon, 3 Aug 2020 at 14:41, Matt Sicker wrote: >> >> One of the main cha

Re: [OFF-LIST][CANCELLED][VOTE] Release Apache Commons Validator 1.7 based on RC2

2020-08-03 Thread sebb
On Mon, 3 Aug 2020 at 17:50, Rob Tompkins wrote: > > I’m happy to roll RC3 if you want another set of hands in there….less busy > work for you. Thanks, but I'm already almost done. The release plugin has made it much easier. > -Rob > > > On Aug 3, 2020, at 12:48 PM, sebb wrote: > > > > CANCEL

Re: [OFF-LIST][CANCELLED][VOTE] Release Apache Commons Validator 1.7 based on RC2

2020-08-03 Thread Rob Tompkins
> On Aug 3, 2020, at 12:57 PM, sebb wrote: > > On Mon, 3 Aug 2020 at 17:50, Rob Tompkins > wrote: >> >> I’m happy to roll RC3 if you want another set of hands in there….less busy >> work for you. > > Thanks, but I'm already almost done. > > The release plugin has

[VOTE] Release Apache Commons Validator 1.7 based on RC3

2020-08-03 Thread sebb
Thanks to those who voted for RC2, hopefully this will be OK We have fixed quite a few bugs and added some significant enhancements since Apache Commons Validator 1.6 was released, so I would like to release Apache Commons Validator 1.7. Apache Commons Validator 1.7 RC3 is available for review he

[release-plugin] thoughts on automated validation of releases

2020-08-03 Thread Rob Tompkins
Currently I run the following scripts for signature valitaion: https://github.com/chtompki/notes/blob/master/commons-release-validation/commons-text-1.7-downloader.sh and https://github.co

Re: [release-plugin] thoughts on automated validation of releases

2020-08-03 Thread Gary Gregory
Hi Rob, I am missing something. Is this something you will provide for each component? Or, is this a command that is generated in the VOTE.txt? The latter seems more reasonable since there are so many variables. Note that some components have different component names from their artifact IDs: poo

Re: [release-plugin] thoughts on automated validation of releases

2020-08-03 Thread Matt Sicker
At OpenWhisk, they've come up with a more standardized process around this as they have a lot of components, too. https://github.com/apache/openwhisk-release And the related utilities for enforcing releasability and similar things: https://github.com/apache/openwhisk-utilities This began as a r

Re: [release-plugin] thoughts on automated validation of releases

2020-08-03 Thread Rob Tompkins
That’s just an example of what I’ve been doing. The question is whether we move this logic into the release plugin for the sake of validation. > On Aug 3, 2020, at 2:19 PM, Gary Gregory wrote: > > Hi Rob, > > I am missing something. Is this something you will provide for each > component? Or

Re: [release-plugin] thoughts on automated validation of releases

2020-08-03 Thread sebb
On Mon, 3 Aug 2020 at 19:43, Rob Tompkins wrote: > > That’s just an example of what I’ve been doing. The question is whether we > move this logic into the release plugin for the sake of validation. I think it's best to keep any checking scripts entirely separate from the Maven generation process

Re: [release-plugin] thoughts on automated validation of releases

2020-08-03 Thread Rob Tompkins
> On Aug 3, 2020, at 5:14 PM, sebb wrote: > > On Mon, 3 Aug 2020 at 19:43, Rob Tompkins wrote: >> >> That’s just an example of what I’ve been doing. The question is whether we >> move this logic into the release plugin for the sake of validation. > > I think it's best to keep any checking

Re: [release-plugin] thoughts on automated validation of releases

2020-08-03 Thread sebb
On Mon, 3 Aug 2020 at 22:15, Rob Tompkins wrote: > > > > > On Aug 3, 2020, at 5:14 PM, sebb wrote: > > > > On Mon, 3 Aug 2020 at 19:43, Rob Tompkins wrote: > >> > >> That’s just an example of what I’ve been doing. The question is whether we > >> move this logic into the release plugin for the

Re: [VOTE] Release Apache Commons Validator 1.7 based on RC3

2020-08-03 Thread Gary Gregory
+1 Testing based on the git tag Running: mvn clean -V install site Reports OK (RAT clean, manual JApiCmp OK) Building OK with: Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) Maven home: C:\Java\apache-maven-3.6.3\bin\.. Java version: *1.8.0_262*, vendor: AdoptOpenJDK, runtime: C

Re: [VOTE] Release Apache Commons Validator 1.7 based on RC3

2020-08-03 Thread Rob Tompkins
+1 Java 8, Java 11 builds successfully Signatures validated (see https://github.com/chtompki/notes/tree/master/commons-release-validation ) if anyone else wants to use my process Reports look good enough (curious about ja

Re: [release-plugin] thoughts on automated validation of releases

2020-08-03 Thread Romain Manni-Bucau
Maybe use creadur as home, it is exactly its goal: https://creadur.apache.org/ Le mar. 4 août 2020 à 00:13, sebb a écrit : > On Mon, 3 Aug 2020 at 22:15, Rob Tompkins wrote: > > > > > > > > > On Aug 3, 2020, at 5:14 PM, sebb wrote: > > > > > > On Mon, 3 Aug 2020 at 19:43, Rob Tompkins wrote