I suggest just migrate 1 or 2 tests first, and create a pr, and we discuss
it there.
Discussing without codes seems hollow.
Gilles Sadowski 于2022年2月17日周四 09:16写道：
> Hello.
>
> > [...]
> >
> > One more practical question: since the tests are not anymore based on the
> > methods name and are
Hello.
> [...]
>
> One more practical question: since the tests are not anymore based on the
> methods name and are indicated by annotations now, I've seen tests without
> this "test" in the beginning. Looks like common practice (including it's
> the way it's presented in the JUnit 5 docs). Since
Please do not remove "test" from method names, it's the convention we use
today, there is no reason to make a PR noisier than it has to be. Recall
that a human has to do a review ;-)
TY,
Gary
On Wed, Feb 16, 2022, 19:28 Itamar C wrote:
> >
> > > There is too much information and some of them
>
> > There is too much information and some of them are inconsistent. For
> > example:
> > https://issues.apache.org/jira/projects/CODEC/issues/CODEC-286 is open
> > but
> > https://github.com/apache/commons-codec/pull/40 is closed
> >
> > Maybe there should be a better integration between GH and
Hello.
Le mer. 16 févr. 2022 à 17:31, Avijit Basak a écrit :
>
> Hi All
>
> Please find my comments.
>
> >> (2)
> >> >The "GeneticException" class seems to mostly deal with "illegal"
> >> >arguments; hence it should be a subclass of the JDK's standard
> >> >"IllegalArgumentException"
Commons VFS needs help migrating to Junit 5. It still has tests on Junit 3.
Gary
On Wed, Feb 16, 2022, 13:11 Matt Sicker wrote:
> IntelliJ has a useful feature for helping automate migration of JUnit
> tests. Works wherever you have tests that don't use rules or
> parameterized tests (those
IntelliJ has a useful feature for helping automate migration of JUnit
tests. Works wherever you have tests that don't use rules or
parameterized tests (those need to be manually migrated still).
On Wed, Feb 16, 2022 at 9:17 AM Alex Herbert wrote:
>
> On Wed, 16 Feb 2022 at 14:30, Gilles Sadowski
Hi All
Please find my comments.
>> (2)
>> >The "GeneticException" class seems to mostly deal with "illegal"
>> >arguments; hence it should be a subclass of the JDK's standard
>> >"IllegalArgumentException" (and be renamed accordingly).
>> >If other condition types are needed, then
On Wed, 16 Feb 2022 at 14:30, Gilles Sadowski wrote:
> > I've finally found that CODEC-285 is an issue that maybe I can help
> > (Upgrade to JUnit v5.6.0). But there are already 4 PRs there. I'm not sure
> > from where I should start: create a branch from the master or from some
> > branch in
Hello.
Le mer. 16 févr. 2022 à 16:01, Alex Herbert a écrit :
>
> On Wed, 16 Feb 2022 at 14:07, Gilles Sadowski wrote:
>
> > >
> > > Use Double.MIN_VALUE for the SAFE_MIN constant.
> >
> > Nit-pick: s/VALUE/NORMAL/ ?
>
> Oops. However the value is correct (the existing unit test for it was
>
On Wed, 16 Feb 2022 at 14:07, Gilles Sadowski wrote:
> >
> > Use Double.MIN_VALUE for the SAFE_MIN constant.
>
> Nit-pick: s/VALUE/NORMAL/ ?
Oops. However the value is correct (the existing unit test for it was
unchanged). The commit log is wrong which I cannot change now without
some
Hello.
Le mer. 16 févr. 2022 à 15:05, Itamar C a écrit :
>
> That's my first message on this list, but I've been reading the messages
> for some months.
>
> I'm interested in contributing to Apache Commons, but it was a little
> confusing to find where to help. Some of the issues in Jira are
Hello.
Le mer. 16 févr. 2022 à 14:47, a écrit :
>
> This is an automated email from the ASF dual-hosted git repository.
>
> aherbert pushed a commit to branch master
> in repository https://gitbox.apache.org/repos/asf/commons-numbers.git
>
> commit 3be4da9c24b0bde0ffc8e68387d2b03c966365cd
>
That's my first message on this list, but I've been reading the messages
for some months.
I'm interested in contributing to Apache Commons, but it was a little
confusing to find where to help. Some of the issues in Jira are very old,
but not solved. It's difficult for a newcomer like me to
14 matches
Mail list logo
