CODED-285 - JUnit5

2022-02-19 Thread Itamar C
(as > in v5 will reflectively allow access to your test code if it’s not public). > > — > Matt Sicker > > > On Feb 17, 2022, at 19:59, Gary Gregory wrote: > > > > On Thu, Feb 17, 2022 at 8:47 PM Itamar C wrote: > > > >>> On Thu, Feb 17, 2022 at 8:16 P

Re: [All] Maintenance (Re: [GitHub] [... PR] #104: Maven Wrapper [...])

2022-02-17 Thread Itamar C
On Thu, Feb 17, 2022 at 8:16 PM Gilles Sadowski wrote: > Which discussion (since this thread covered more than one subject)? > If you mean the "migration to Junit 5" task for [Codec], it's already > there.[1] > If you mean the method rename (to remove the "test" prefix), then > the "dev" ML is wh

Re: [All] Maintenance (Re: [GitHub] [... PR] #104: Maven Wrapper [...])

2022-02-17 Thread Itamar C
Hello, My suggestion: I'll work on the methods without renaming and after the migration is completed, if we decide to rename, it's not difficult to rename all test methods with a script and put in a new PR. A simple regexp like "^\\s*@Test\\s*\n\\s*(.+)\\s+test(\\w)(\\w+)\\s*\\(.*" changing to m.

Re: [All] Maintenance (Re: [GitHub] [... PR] #104: Maven Wrapper [...])

2022-02-16 Thread Itamar C
> > > There is too much information and some of them are inconsistent. For > > example: > > https://issues.apache.org/jira/projects/CODEC/issues/CODEC-286 is open > > but > > https://github.com/apache/commons-codec/pull/40 is closed > > > > Maybe there should be a better integration between GH and

Re: [All] Maintenance (Re: [GitHub] [... PR] #104: Maven Wrapper [...])

2022-02-16 Thread Itamar C
That's my first message on this list, but I've been reading the messages for some months. I'm interested in contributing to Apache Commons, but it was a little confusing to find where to help. Some of the issues in Jira are very old, but not solved. It's difficult for a newcomer like me to underst