Re: [commons-lang] branch master updated: Use Collection#toArray(new T[0]) instead of a presized array as it is faster on modern JVMs.

2019-12-27 Thread Pascal Schumacher
2019 at 09:28, Pascal Schumacher wrote: see https://shipilev.net/blog/2016/arrays-wisdom-ancients/ Am 27.12.2019 um 01:24 schrieb sebb: Also, where is it documented that modern JVMs are faster? To which JVMs does this apply? S. On Thu, 26 Dec 2019 at 22:08, Gary Gregory wrote: Please do

Re: [commons-lang] branch master updated: Use Collection#toArray(new T[0]) instead of a presized array as it is faster on modern JVMs.

2019-12-27 Thread Pascal Schumacher
see https://shipilev.net/blog/2016/arrays-wisdom-ancients/ Am 27.12.2019 um 01:24 schrieb sebb: Also, where is it documented that modern JVMs are faster? To which JVMs does this apply? S. On Thu, 26 Dec 2019 at 22:08, Gary Gregory wrote: Please do not cause garbage to apparently be

Re: [VOTE] Release Apache Commons RNG 1.3 based on RC1

2019-11-07 Thread Pascal Schumacher
+1 Am 05.11.2019 um 17:36 schrieb Alex Herbert: We have fixed quite a few bugs and added some significant enhancements since Apache Commons RNG 1.2 was released, so I would like to release Apache Commons RNG 1.3. Apache Commons RNG 1.3 RC1 is available for review here:  

Re: [IO] Don't deprecate IOUtils#closeQuietly()

2019-11-05 Thread Pascal Schumacher
+1, for removing the deprecatio Am 05.11.2019 um 16:10 schrieb Gary Gregory: Hi All: I propose that we do NOT deprecate IOUtils#closeQuietly(). There are use-cases for this method outside of try-with-resources blocks. For example, I have some wrapper objects that contain Closeable objects.

Re: [exec] Update from Java 5 to 6

2019-10-09 Thread Pascal Schumacher
+1 Am 09.10.2019 um 17:25 schrieb John Patrick: What about Java 5 to 8. I'm current sat at Jax London and was the sole person who put their hand up for Java 6, and next Conference I hope to have migrated everything to at least Java 8. From the rest I saw 1 hand being raised for Java 7, about

Re: [VOTE] Release Apache Commons BCEL 6.4.1 based on RC1

2019-10-02 Thread Pascal Schumacher
+1 Am 29.09.2019 um 18:23 schrieb Gary Gregory: My +1 Gary On Thu, Sep 26, 2019 at 9:38 PM Gary Gregory wrote: We have fixed one important bug since Apache Commons BCEL 6.4.0 was released, so I would like to release Apache Commons BCEL 6.4.1. Apache Commons BCEL 6.4.1 RC1 is available for

Re: [VOTE] Release Apache Commons Configuration 2.6 based on RC1

2019-09-17 Thread Pascal Schumacher
+1 Am 14.09.2019 um 03:23 schrieb Gary Gregory: We have fixed a few bugs and added some enhancements since Apache Commons Configuration 2.5 was released, so I would like to release Apache Commons Configuration 2.6. Apache Commons Configuration 2.6 RC1 is available for review here:

Re: [lang] Missing Javadocs

2019-09-05 Thread Pascal Schumacher
Checkstyle can be used to enforce the presence of javadoc. At least the Travis CI build executes checkstyle and fails if checkstyle fails. Am 05.09.2019 um 18:04 schrieb sebb: Can the CI build be changed to fail the build when Javadoc is omitted? On Thu, 5 Sep 2019 at 17:00, Gary Gregory

Re: [All] Source Repo page

2019-08-14 Thread Pascal Schumacher
+1 Am 12.08.2019 um 14:48 schrieb Gary Gregory: Hi All, I'm thinking that our components source repo page should also include a link to the GitHub version of the repo. Thoughts? Gary - To unsubscribe, e-mail:

Re: [All][parent] RAT check

2019-08-12 Thread Pascal Schumacher
+1 Am 10.08.2019 um 16:42 schrieb Gary Gregory: Hi all, It seems to me the commons-parent should cause the RAT check to run for all builds, say in the... validate phase? Gary - To unsubscribe, e-mail:

Re: [IO] Travis builds fail for Java 7, 13 and ea

2019-08-02 Thread Pascal Schumacher
Build is green now. Thanks for reporting! Cheers, Pascal Am 02.08.2019 um 16:24 schrieb Pascal Schumacher: Java 7 is not available on travis anymore. Java 13+ fails because of incorrect javadoc: An error has occurred in Javadoc report generation: 3336[ERROR] Exit code: 1 - /home/travis

Re: [VOTE] Release Apache Commons BeanUtils 1.9.4 based on RC2

2019-08-02 Thread Pascal Schumacher
+1 Am 29.07.2019 um 00:35 schrieb Rob Tompkins: We have fixed quite a few bugs and added some significant enhancements since Apache Commons BeanUtils 1.9.3 was released, so I would like to release Apache Commons BeanUtils 1.9.4. Apache Commons BeanUtils 1.9.4 RC2 is available for review

Re: [IO] Travis builds fail for Java 7, 13 and ea

2019-08-02 Thread Pascal Schumacher
Java 7 is not available on travis anymore. Java 13+ fails because of incorrect javadoc: An error has occurred in Javadoc report generation: 3336[ERROR] Exit code: 1 - /home/travis/build/apache/commons-io/src/main/java/org/apache/commons/io/DirectoryWalker.java:49: error: heading used out of

Re: [VOTE] Release Apache Commons Pool 2.7.0 based on RC1

2019-07-28 Thread Pascal Schumacher
+1 Am 25.07.2019 um 16:59 schrieb Gary Gregory: We have fixed quite a few bugs and added some significant enhancements since Apache Commons Pool 2.6.2 was released, so I would like to release Apache Commons Pool 2.7.0. Apache Commons Pool 2.7.0 RC1 is available for review here:

Re: [VOTE] Release Apache Commons Codec 1.13 based on RC1

2019-07-22 Thread Pascal Schumacher
+1 Am 22.07.2019 um 03:05 schrieb Bruno P. Kinoshita: [x] +1 Release these artifacts Passing with `mvn clean test install site -e -X` on: $ mvn -v Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T20:58:13+13:00) Maven home: /opt/apache-maven-3.5.2 Java version:

Re: [VOTE] Release Apache Commons VFS Project 2.4 based on RC1

2019-07-16 Thread Pascal Schumacher
+1 Am 16.07.2019 um 17:13 schrieb Otto Fowler: +1 thanks Gary for keeping the VFS momentum up. On July 16, 2019 at 07:20:20, Gary Gregory (garydgreg...@gmail.com) wrote: May we have more (binding) VOTE(s) please? Gary On Fri, Jul 12, 2019, 12:27 Gary Gregory wrote: We have fixed quite

Re: [VOTE] Release Apache Commons Text 1.7 based on RC1

2019-07-03 Thread Pascal Schumacher
+ 1 Am 30. Juni 2019 16:28:45 MESZ schrieb Gary Gregory : >We have fixed quite a few bugs and added some significant enhancements >since Apache Commons Text 1.6 was released, so I would like to release >Apache Commons Text 1.7. > >Apache Commons Text 1.7 RC1 is available for review here: >

Re: [git] please avoid force pushes

2019-06-13 Thread Pascal Schumacher
Am 13.06.2019 um 19:29 schrieb Eric Barnhill: Apologies if everyone knows this but... There has been some force pushing in the git repos lately. Unfortunately there are a lot of Stack Overflow answers that will tell the user to solve a complex commit situation by force pushing. These answers

Re: Is there some plans for implementing some primitive datas tructures?

2019-06-07 Thread Pascal Schumacher
Am 07.06.2019 um 21:53 schrieb Xeno Amess: 1. Is this thing done by some libraries before? Not Apache, but two popular open collection libraries offering primitive collections are trove4j (https://bitbucket.org/trove4j) and Eclipse Collections (https://www.eclipse.org/collections/).

Re: [codec] Java 8

2019-03-23 Thread Pascal Schumacher
Am 22. März 2019 19:56:29 MEZ schrieb Gary Gregory : >On Fri, Mar 22, 2019 at 2:53 PM sebb wrote: > >> I see no reason to update to Java 8 unless continuing with Java 7 >> becomes a big hassle. >> >> Why penalise people stuck on Java 7 unnecessarily? >> > >I see it the other way around: Why do

Re: [Parent] RAT check

2019-03-10 Thread Pascal Schumacher
+1 Am 09.03.2019 um 23:44 schrieb Gary Gregory: Hi all: How about making apache-rat:check run automatically in commons-parent? In the Maven validate phase? That would mean one less thing to check when integrating a patch and validating an RC. Gary

Re: [VOTE] Redirect github notifications to issues@

2019-03-04 Thread Pascal Schumacher
Thank you very much! Am 04.03.2019 um 18:25 schrieb Marcelo Vanzin: FYI, it should all be done now, so if you want to get notifications, either sign up to issues@, or watch the repo on github. On Fri, Feb 22, 2019 at 9:49 AM Marcelo Vanzin wrote: Jira link:

Re: [LANG] Jenkins Pipeline DSL

2019-03-03 Thread Pascal Schumacher
Am 03.03.2019 um 14:56 schrieb sebb: For example, what about notifications for failed builds - is that maintained in Jenkins or in the pipeline file? Notification can be defined in the pipeline. Pretty much everything can be defined in a jenkins file nowadays (some plugins do not have

Re: [ALL][RFC] Github subjects don't contain the repo name

2019-03-01 Thread Pascal Schumacher
Am 01.03.2019 um 22:53 schrieb Mark Thomas: Why not [commons-io] zsoltii opened a new pull request #74: Add new function: byteCountToDisplayRoundedSize to match the format of the commit messages? And to make the subject a little shorter. +1

Re: [VOTE] Redirect github notifications to issues@

2019-02-22 Thread Pascal Schumacher
Thank you very much for taking care of this! Am 22.02.2019 um 18:49 schrieb Marcelo Vanzin: Jira link: https://issues.apache.org/jira/browse/INFRA-17892 On Fri, Feb 22, 2019 at 9:44 AM Marcelo Vanzin wrote: Thanks all, vote passes with 11 +1s, no -1s. I'll file the INFRA ticket and link it

Github notification and Jira Issues (was: Re: [VOTE] Redirect github notifications to issues@)

2019-02-20 Thread Pascal Schumacher
Am 20.02.2019 um 19:39 schrieb Marcelo Vanzin: Rob: I almost think that we should have Pull Requests generate jiras. I've seen this set up in a couple of projects and jira becomes unreadable... the updates generated by github are horrible to read. I really don't like them. Imho the way to

Re: [text] TEXT-104 clirr errors, prepare 2.0 or revert change

2019-02-20 Thread Pascal Schumacher
I'm fine with either solution, but my preference would be to remove all deprecated stuff and release version 2.0. Am 20.02.2019 um 08:42 schrieb Bruno P. Kinoshita: Hi all, Just finished merging a pull request to TEXT-104, where the JaroWinkler distance was updated. The class was actually

Re: [VOTE] Redirect github notifications to issues@

2019-02-19 Thread Pascal Schumacher
+1 Am 19.02.2019 um 22:35 schrieb Marcelo Vanzin: I'm opening a vote based on recent discussions about the extra noise generated by github updates going to dev@. So please vote: - +1 to redirect github updates of all commons repos to the issues@ list - -1 to keep things as is If the vote

Re: [LANG] Jenkins Pipeline DSL

2019-02-17 Thread Pascal Schumacher
+1 to using a pipeline Am 17.02.2019 um 18:35 schrieb Benedikt Ritter: Hi all, I feel like maintaining separate build descriptions on Jenkins is a PITA. Any objections against adopting Jenkins Pipeline DSL for Lang? Regards, Benedikt

Re: [DISCUSS] Change github notifications for all commons sub-projects

2019-02-15 Thread Pascal Schumacher
+1 for moving github notifications to issues@ Am 15.02.2019 um 20:02 schrieb Marcelo Vanzin: Hey all, There was a recent thread ([1]) with a brief discussion about the number of github updates that are currently ending up in the dev@ mailing list. Personally I find that a little too noisy

Re: [RNG, ALL] Checkstyle version

2019-02-12 Thread Pascal Schumacher
Am 11.02.2019 um 22:15 schrieb sebb: Aren't there different profiles for different Java versions? There was at least one plugin which needed different versions, so maybe take the same approach here. It's a bit more work to set up the pom, but it saves a lot of work downstream fixing component

Re: [RNG, ALL] Checkstyle version

2019-02-11 Thread Pascal Schumacher
Am 11.02.2019 um 12:19 schrieb Alex Herbert: I would like to upgrade the checkstyle version in commons-rng. Currently the project uses maven-checkstyle-plugin 3.0.0 which defaults to checkstyle 6.18. This version is old [1] and not supported by modern IDEs. An update (to version 8.x) would

Re: [ALL] Broken builds

2019-02-10 Thread Pascal Schumacher
I'm not sure if the error can be fixed in the Maven Javadoc Plugin. While the bug was rejected by OpenJDK at first, is was later reopened and fixed, but only in Java 13 and 12.0.1: https://bugs.openjdk.java.net/browse/JDK-8212233 Am 10.02.2019 um 14:24 schrieb Gary Gregory: Note that builds

Re: [VFS] Tests fail on Java 11

2019-02-05 Thread Pascal Schumacher
Just a guess, but Caused by: javax.net.ssl.SSLHandshakeException: No available authentication scheme seems to hint at TLS  version / cypher suite changes. The antique versions probably want to use a cypher suite that is disabled on Java 11, e.g. 3DES

Re: [VOTE] Release Apache Commons VFS 2.3 based on RC2

2019-02-04 Thread Pascal Schumacher
+1 looks good Am 04.02.2019 um 17:00 schrieb Rob Tompkins: +1 signatures, rat, (minor nits) checkstyle issues, (minor nits) findbugs issues. I had a build issue with java11 that looks insurmountable for this release. Specifically: Tests in error:

Re: [lang] Ready for 3.9???

2019-02-03 Thread Pascal Schumacher
No sure if it worth it, as there are very few new features and no bugfixes, see: https://github.com/apache/commons-lang/blob/master/src/changes/changes.xml Also the function class addition: https://github.com/apache/commons-lang/commit/11d9eb47a40359e74a5e24daf681beacd71b35f0

Re: [ANNOUNCE] Commons Release Plugin 1.5 released.

2019-02-01 Thread Pascal Schumacher
+1 Am 01.02.2019 um 03:13 schrieb Gary Gregory: Thank you Rob! Gary On Wed, Jan 30, 2019 at 9:21 AM Rob Tompkins wrote: [This announcement is only going to the dev list.] The Apache Commons Release Plugin team is pleased to announce the release of Apache Commons Release Plugin 1.5. The

Re: [LANG] Checked Functions PR

2019-01-30 Thread Pascal Schumacher
Am 30.01.2019 um 20:27 schrieb Jochen Wiedmann: Have you seen [1]? 1: https://gitbox.apache.org/repos/asf?p=commons-lang.git;a=blob_plain;f=src/main/java/org/apache/commons/lang3/Functions.java;h=5eaed0c6fa8dbb8ed7a2ba37d499130ba62f138b;hb=HEAD By the way:

Re: JAPICMP Collections-4.3-RC2 report pdf (Was: Re: [VOTE][RC2] Commons collections 4.3)

2019-01-28 Thread Pascal Schumacher
Am 28.01.2019 um 20:01 schrieb Rob Tompkins: Before I vote on the the thread, does adding a method to an interface cause BC to break? "Adding a method to an interface does not break compatibility with pre-existing binaries." Source:

Re: [VOTE] Release Apache Commons BCEL 6.3 based on RC1

2019-01-27 Thread Pascal Schumacher
+1 Am 27.01.2019 um 16:06 schrieb Rob Tompkins: +1 signatures good, sha1 (nexus), md5 (nexus), sha512, asc builds in java8 and java11 Issue: RELEASE-NOTES.txt has 6.3-SNAPSHOT not 6.3 in it (Fixable) Nits: checkstyle, pmd, cpd, findbugs few issues. ——— Aside: I will try to get to

Re: [VOTE][LAZY] Move commons-codec to gitbox after 1.12 release.

2018-12-28 Thread Pascal Schumacher
+1 Am 28.12.2018 um 15:51 schrieb Rob Tompkins: After doing the 1.12 release I propose we move commons-codec to gitbox. This is a [LAZY] consensus [VOTE] for doing such after I get through the release. This [LAZY][VOTE] will be open for at least 72 hours form now. Cheers, -Rob

Re: [VOTE][LAZY] move commons git-wip repos to gitbox

2018-12-09 Thread Pascal Schumacher
+1 Am 08.12.2018 um 21:09 schrieb Rob Tompkins: Infra stated that we need documented consensus on this. So, let’s have at it. I propose that we move the following repos over to gitbox: commons-build-plugin.git 11 weeks ago commons-cli.git30 weeks ago commons-collections.git

Re: [Lang] CheckedFunction#unchecked

2018-11-24 Thread Pascal Schumacher
Hi Aleksander, thanks. Imho this would be a useful addition to commons-lang. Any other opinions? Cheers, Pascal Am 21.11.2018 um 22:52 schrieb Aleksander Ściborek: Hi I've just created pull request for CheeckedFunction interface. This is an

Re: [IO] Provenance of copied code in InfiniteCircularInputStream

2018-11-19 Thread Pascal Schumacher
Hi everybody, the code is from a pull request which I merged: https://github.com/apache/commons-io/pull/8 I did not author the code. The comment seems incorrect because I do not think there is a field "repeatedContent" in java.io.ByteArrayInputStream. The current OpenJDK implementation

Re: [all] Amazon Corretto

2018-11-14 Thread Pascal Schumacher
Isn't this basically the same as Adopt Open JDK: https://adoptopenjdk.net or am I missing something? -Pascal Am 14.11.2018 um 15:14 schrieb Rob Tompkins: Curious to see what people’s thoughts are to this: https://aws.amazon.com/corretto/ -Rob

Re: [CONFIGURATION] 2.4 RC2 test failures with java 11 (Was: [VOTE] Release Apache Commons Configuration 2.4 based on RC2)

2018-10-26 Thread Pascal Schumacher
I would guess this is caused by a byte code manipulation library like ASM which does not support Java 11 yet. Am 26.10.2018 um 16:28 schrieb Rob Tompkins: Yes…those failures happen in 11, but not 10. Thoughts? On Oct 26, 2018, at 9:59 AM, Gary Gregory wrote: Ping? Anybody see this as well?

Re: [VOTE] Release Apache Commons Text 1.6 based on RC1

2018-10-14 Thread Pascal Schumacher
+1 Am 13.10.2018 um 17:56 schrieb Gary Gregory: *+1* Thank you Rob for preparing this RC. From src zip: ASC, SHA256, and SHA512 OK. Building 'mvn -V clean package site' OK using: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T12:33:14-06:00) Maven home:

Re: GitHub Pull Requests

2018-10-12 Thread Pascal Schumacher
Hi Zack, there is no hard and fast rule when pull request get reviewed and/or commented on. It happens whenever a committer feels motivated to do so (we are all volunteers). I understand that waiting a long time for pull request reviews is demotivating. Sorry, Pascal Am 11.10.2018 um

Re: [VOTE] Release Apache Commons Text 1.5 based on RC3

2018-10-02 Thread Pascal Schumacher
+1 Am 01.10.2018 um 17:03 schrieb Gary Gregory: +1 From src zip: ASC, SHA256, SHA512 OK. Build from src zip with 'mvn clean package site' OK using: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T12:33:14-06:00) Maven home: C:\Java\apache-maven-3.5.4 Java version:

Re: [VOTE] Release Apache Commons Text 1.5 based on RC1

2018-09-29 Thread Pascal Schumacher
+1 Am 29.09.2018 um 03:36 schrieb Gary Gregory: Hi, It looks like I did not spot what Spotbugs found :-( https://dist.apache.org/repos/dist/dev/commons/text/1.5-RC1/site/spotbugs.html The only real worrisome one IMO is: "org.apache.commons.text.lookup.PropertiesStringLookup.lookup(String)

Re: [LANG] Request for Comments for LANG-1417

2018-08-28 Thread Pascal Schumacher
Hi Benedikt, not sure if anything is gained this change. It is already possible use lambda expressions or method references instead of ThreadPredicate/ThreadGroupPredicate. Users will have to change their code to avoid deprecation warnings. I would prefer to just annotate ThreadPredicate

Re: [ALL] Make checkstyle:check part of default maven goal?

2018-08-27 Thread Pascal Schumacher
At least RAT and clirr/japicmp should be part of default goal. I'm personally prefer checkstyle and findbugs/spotbugs (although I prefer error-prone nowadays) to be part of the default goal. On Java 8+ it is also helpful to make javadoc part of the default goal. I think it is very convenient

[text] Recently added Checkstyle Violations

2018-08-26 Thread Pascal Schumacher
Hi, the build of text fails, because of checkstyle violations: [INFO] There are 8 errors reported by Checkstyle 8.12 with /home/travis/build/apache/commons-text/checkstyle.xml ruleset. [ERROR] src/main/java/org/apache/commons/text/lookup/AbstractStringLookup.java:[27,5] (javadoc)

Re: [LANG] Minimum required Java version for 3.9

2018-08-21 Thread Pascal Schumacher
+1 Am 20. August 2018 19:09:27 MESZ schrieb Benedikt Ritter : >Hi, > >any objections against raising the minimum required Java version for >lang >3.9 to Java 1.8? > >Regards, >Benedikt

Re: I'm alive!

2018-08-16 Thread Pascal Schumacher
Welcome back! :-) Am 16.08.2018 um 16:59 schrieb Benedikt Ritter: Hi all, I have been pretty quite over the past 12 month. There are a lot of reasons for this. The most important reasons are: - I've been Lead Developer in a very challenging project which included a lot of traveling between my

Re: [lang] preparing for 3.8

2018-08-14 Thread Pascal Schumacher
Am 14.08.2018 um 14:15 schrieb Gary Gregory: Not a blocker IMO. We can release 3.8 and work on this for 3.9. +1 - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail:

Re: [lang] preparing for 3.8

2018-08-14 Thread Pascal Schumacher
Yes, a new lang release would be great. :-) Thanks, Pascal Am 14.08.2018 um 03:31 schrieb Gary Gregory: Go for it! :-) Gary On Mon, Aug 13, 2018, 18:36 Rob Tompkins wrote: Hello all, I’m planning on working on 3.8 for lang later this week. Does anyone want to get any specific jira's in?

Re: [imaging] Move from Java7 to Java8

2018-08-12 Thread Pascal Schumacher
Hi Bruno, imho it would be preferable to release 1.0 using Java 7. That would allow everybody using snapshots to replace them with a release. E.g. https://github.com/LibrePDF/OpenPDF is using a snapshot but is still on Java 7. After the release we can update to Java 8 for 1.1. Cheers,

Re: [LANG] Java 9 problems because of dependencies to java.desktop (Was: Re: [LANG] Thoughts about Lang 4.0)

2018-07-17 Thread Pascal Schumacher
I think we should deprecate without replacement. There are already plenty Apache 2.0 licensed libraries offering circuit breaker implementations: https://github.com/Netflix/Hystrix https://github.com/jhalterman/failsafe https://github.com/resilience4j/resilience4j Cheers, Pascal Am

Re: [LANG] Java 9 problems because of dependencies to java.desktop (Was: Re: [LANG] Thoughts about Lang 4.0)

2018-07-16 Thread Pascal Schumacher
Am 16.07.2018 um 13:40 schrieb Bruno P. Kinoshita: Saw some recent activity around lang 3.8, and remembered about this issue, and then looked for this thread. Gilles' point is really good! Here's the Java 9 docs with the deprecation warning, copied below as well

Re: [Lang] Rounding Duration

2018-07-15 Thread Pascal Schumacher
Am 15.07.2018 um 22:09 schrieb Gary Gregory: Let's cut a Lang release and then update to Java 8. +1 - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

Re: [Lang] Rounding Duration

2018-07-15 Thread Pascal Schumacher
Hi Aleksander, guess you are referring to java.time.Duration? This class was added in Java 8 and commons-lang currently only requires Java 7. Therefore we can not add this at the moment. Sorry, Pascal Am 14.07.2018 um 21:26 schrieb Aleksander Ściborek: Hello everyone During implamanting a

Re: Porting URIBuilder call sites

2018-07-13 Thread Pascal Schumacher
I guess this was send to the wrong mailing list? Am 12.07.2018 um 17:22 schrieb Gary Gregory: Hi All, I just had to port this 'nice' fluent code: final String uri = new URIBuilder() .setScheme(scheme) .setHost("localhost")

Re: [dbcp] Next

2018-06-21 Thread Pascal Schumacher
+1 Am 21.06.2018 um 20:33 schrieb Matt Sicker: I'd stick with 2.x since it's still backwards compatible. Upgrading the base Java version is not a semantic change IMO, but it shouldn't be done in a patch release. On 19 June 2018 at 16:48, Gary Gregory wrote: To be clear: DBCP 2.4.0 - Java

Re: [parent] release?

2018-06-20 Thread Pascal Schumacher
+1 Am 20.06.2018 um 19:58 schrieb Gary Gregory: Are we ready? Gary - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

Re: [parent] cobertura dead, replace with jacoco?

2018-06-20 Thread Pascal Schumacher
+1 Am 20.06.2018 um 22:37 schrieb Gary Gregory: It seems cobertura has not been updated since 2015 ( https://github.com/cobertura/cobertura/releases) and does not work on Java 9: [INFO] [INFO] BUILD FAILURE [INFO]

Re: [release-plugin][build-plugin] Java 8

2018-06-13 Thread Pascal Schumacher
+1 Am 13.06.2018 um 23:07 schrieb Gary Gregory: I propose we make our release-plugin require Java 8. Newer dependencies like the latest Checkstyle require Java 8. Gary - To unsubscribe, e-mail:

Re: [VOTE] Release Apache Commons Text 1.4 based on RC1

2018-06-10 Thread Pascal Schumacher
+1 Thank you very much for being the release manager! Cheers, Pascal Am 09.06.2018 um 19:49 schrieb Gary Gregory: We have fixed quite a few bugs and added some significant enhancements since Apache Commons Text 1.3 was released, so I would like to release Apache Commons Text 1.4. Apache

[all] - git: prevent unnecessary merge commits?

2018-06-09 Thread Pascal Schumacher
Hello everybody, in my opinion it is a good practice to always use the "--rebase" option when using "git pull". This keeps the history free of unnecessary merge commits like "Merge branch 'master' of https://git-wip-us.apache.org/repo...;. You can also tell git to automatically rebase when

Re: [VOTE] Release Compress 1.17 based on RC1

2018-06-01 Thread Pascal Schumacher
I guess the build fails on java 11 because jacoco does not support java 11 yet, see: https://github.com/jacoco/jacoco/issues/663 Cheers, Pascal Am 01.06.2018 um 17:19 schrieb Gary Gregory: +1 From src zip file: ASC, SHA-1, SHA-256 OK. mvn apache-rat:check OK mvn japicmp:cmp OK mvn clean

Re: [io] Black Duck apparently sees vulnerability in 2.5

2018-05-17 Thread Pascal Schumacher
Am 16.05.2018 um 08:24 schrieb Stefan Bodewig: Also, would there be any reason to not cut a new release from master? I mean is there any work in progress that needs to be finished? I think a new release from master can be done any time. -Pascal

Re: [DBCP] Drop Ant build?

2018-05-12 Thread Pascal Schumacher
+1 for droping it Am 12.05.2018 um 20:36 schrieb Gary Gregory: Commons DBCP still has an Ant build. Should we drop it? - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail:

Re: [BBUTILS] Update from Java 6 to 7

2018-05-04 Thread Pascal Schumacher
+1 Am 04.05.2018 um 18:19 schrieb Gary Gregory: Hi All: DBUtils contains the kind of code that would benefit from bullet proofing using try-with-resources statementds. To this end I propose we update from Java 6 to 7. Gary

Re: [VOTE] Migrate existing Git repos to GitBox

2018-04-22 Thread Pascal Schumacher
+1 Am 22.04.2018 um 19:07 schrieb Matt Sicker: This is a vote to migrate existing Git repositories from the old git-wip-us infrastructure to the new gitbox infrastructure. New Apache projects are not allowed to use git-wip-us and are instead directed to use gitbox. As such, it makes sense for

Re: [VOTE] Migrate Commons Weaver to Git

2018-04-19 Thread Pascal Schumacher
+1 Am 19.04.2018 um 17:46 schrieb Matt Benson: Hello, After having received some support from a "feeler" email, I would like to propose the formal vote to migrate this Commons component to Git for version control. This vote will be open for at least 72 hours, or until April 22, 2018 @ 16:00

[text] Move to Java 8?

2018-04-04 Thread Pascal Schumacher
Hello, what about moving text to Java 8, now that version 1.3 has been released? Cheers, Pascal - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

Re: [VOTE] Release Commons Text 1.3 based on RC1

2018-03-20 Thread Pascal Schumacher
+1 Am 16.03.2018 um 16:35 schrieb Rob Tompkins: Hello all, This is a [VOTE] for releasing Apache Commons Text 1.3 (from RC1). Tag name: commons-text-1.3-RC1 (signature can be checked from git using 'git tag -v') Tag URL:

Re: [email] Update from Java 6 to 7

2018-03-02 Thread Pascal Schumacher
+1, otherwise we would have to revert https://github.com/apache/commons-email/commit/2239326be5c2791a23eea07eaed3d81f2e7000cf Am 02.03.2018 um 17:45 schrieb Gary Gregory: I propose we update Commons Email from Java 6 to Java 7. Gary

Re: Commit => Update Jira Issue

2018-02-21 Thread Pascal Schumacher
Hi Jochen, you did not miss anything. Commons does not have any synchronization between commit messages and jira issues (or at least the projects I am aware of). -Pascal Am 21.02.2018 um 10:58 schrieb Jochen Wiedmann: Hi, I notice that my commit in [1] did not update the Jira issue in

Re: [text] LocalHostStringLookupTest: correct order of assertEquals arguments

2018-02-14 Thread Pascal Schumacher
org/repos/asf/commons-text/diff/6e9107dc Branch: refs/heads/master Commit: 6e9107dc826cee43629af6a3857c98c90da18eba Parents: fb5d8c9 Author: Pascal Schumacher <pascalschumac...@gmx.net> Authored: Wed Feb 14 20:58:41 2018 +0100 Committer: Pascal Schumacher <pascalschumac...@gmx.net> Com

Re: [text] Update from Java 7 to Java 8?

2018-02-13 Thread Pascal Schumacher
Am 13.02.2018 um 23:14 schrieb Gary Gregory: What about: - Release 1.3 as is WRT Java, which is Java 7 - Switch to Java 8 for 1.4. Fine with me. - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional

Re: [text] Adapt the Log4j 2 Interpolator to [text]

2018-02-13 Thread Pascal Schumacher
Am 12.02.2018 um 21:53 schrieb Gary Gregory: On Mon, Feb 12, 2018 at 12:53 PM, Gary Gregory <garydgreg...@gmail.com> wrote: On Mon, Feb 12, 2018 at 12:30 PM, Pascal Schumacher < pascalschumac...@gmx.net> wrote: please revert "Update actual Checkstyle from 6.19 to 8.8.&

Re: [text] Update from Java 7 to Java 8?

2018-02-12 Thread Pascal Schumacher
What about now? :-) Am 12.02.2018 um 20:53 schrieb Gary Gregory: When? Gary - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

[text] Deprecation of StrMatcher/StrBuilder/StrTokenizer classes

2018-02-12 Thread Pascal Schumacher
Hello everybody, after further consideration I'm not sure if it is a good idea to deprecate StrMatcher (to convert it to an interface and make the naming match *StringLookup), as this means that StrBuilder and StrTokenizer also have to be deprecated. Not long ago we told users of these

Re: [text] Adapt the Log4j 2 Interpolator to [text]

2018-02-12 Thread Pascal Schumacher
Am 12.02.2018 um 18:52 schrieb Gary Gregory: I agree 100% and will proceed. I thought about it overnight and it does not make sense to leave a mix of abstract classes and interfaces in StrSubstitutor. +1, but please revert "Update actual Checkstyle from 6.19 to 8.8.", as Checkstyle 7+

Re: [text] Adapt the Log4j 2 Interpolator to [text]

2018-02-11 Thread Pascal Schumacher
Am 11.02.2018 um 19:24 schrieb Gary Gregory: I'd like a code review and then a release of 1.3. Right now we only depend on java.base and Commons Lang, so let's keep it that way for 1.3 I think. My comments: - Given "TEXT-80: StrLookup API confusing generic type parameter" I think we should

Re: [text] Adapt the Log4j 2 Interpolator to [text]

2018-02-11 Thread Pascal Schumacher
Am 11.02.2018 um 19:10 schrieb Gary Gregory: Done but there is one checkstyle "Error" left for a TODO comment I left in the code. Thanks! - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands,

Re: [text] Adapt the Log4j 2 Interpolator to [text]

2018-02-11 Thread Pascal Schumacher
Hi Gary, thanks for adding this, looks useful. +1 Please fix the checkstyle violations. Thanks! - Pascal Am 11.02.2018 um 01:32 schrieb Gary Gregory: On Sat, Feb 10, 2018 at 12:44 PM, Gary Gregory wrote: I created the ticket "[TEXT-113] Add an interpolator string

Re: CP43 and Java 6

2018-02-04 Thread Pascal Schumacher
Am 04.02.2018 um 12:57 schrieb sebb: What is the failure message? [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.7.0:compile (default-compile) on project commons-email: Compilation failure -> [Help 1] org.apache.maven.lifecycle.LifecycleExecutionException:

Re: CP43 and Java 6 (was: svn commit: r1822088 - /commons/proper/email/trunk/pom.xml)

2018-02-04 Thread Pascal Schumacher
Am 25.01.2018 um 15:44 schrieb sebb: Have you tried CP43 using Java 7 and -Pjava-1.6 ? I tried to run "mvn clean test -Pjava-1.6" on java 7 but it causes a compilation failure (on helpful output is displayed even when I add "-X").

Re: CP43 and Java 6 (was: svn commit: r1822088 - /commons/proper/email/trunk/pom.xml)

2018-01-25 Thread Pascal Schumacher
You are right. Just revert my revert. Sorry, Pascal Am 25. Januar 2018 17:50:41 MEZ schrieb Gary Gregory <garydgreg...@gmail.com>: >On Thu, Jan 25, 2018 at 9:35 AM, Pascal Schumacher ><pascalschumac...@gmx.net >> wrote: > >> No I have not. >> >

Re: CP43 and Java 6 (was: svn commit: r1822088 - /commons/proper/email/trunk/pom.xml)

2018-01-25 Thread Pascal Schumacher
No I have not. I expect to be able to build projects with a source and target level of java 6 on java 6. Am 25. Januar 2018 15:44:10 MEZ schrieb sebb <seb...@gmail.com>: >On 25 January 2018 at 14:04, Pascal Schumacher ><pascalschumac...@gmx.net> wrote: >> commons

Re: CP43 and Java 6 (was: svn commit: r1822088 - /commons/proper/email/trunk/pom.xml)

2018-01-25 Thread Pascal Schumacher
commons parent 43 includes maven plugins which require java 7 Am 25. Januar 2018 12:44:49 MEZ schrieb sebb : >On 24 January 2018 at 08:35, wrote: >> Author: pascalschumacher >> Date: Wed Jan 24 08:35:29 2018 >> New Revision: 1822088 >> >> URL:

Re: Drop dist entries for dormant components?

2018-01-20 Thread Pascal Schumacher
+1 Am 20.01.2018 um 15:28 schrieb sebb: The following directories under dist [1] relate to dormant components: attributes discovery el launcher modeler primitives transaction Since these are not being developed [2], I guess we should drop them. The code will still be available from the

Re: [All] Source compatibility policy

2018-01-16 Thread Pascal Schumacher
Am 16.01.2018 um 00:06 schrieb Gary Gregory: For me, breaking source compatibility should be limited to what can be adjusted to in my sources very easily. I would also consider whether the breaks are for a cosmetic reasons for an actual bug fix. I would probably pass on cosmetic breaks within

[All] Source compatibility policy

2018-01-15 Thread Pascal Schumacher
Hello, what is our policy regarding source incompatible changes to our APIs? Context: This commons io pull request: https://github.com/apache/commons-io/pull/54/files propose removing unnecessary throws declarations from public method signatures. Thanks, Pascal

Re: [Net] When should we update net from Java 6 to 7?

2018-01-13 Thread Pascal Schumacher
Am 13.01.2018 um 01:31 schrieb Gilles: On Fri, 12 Jan 2018 21:51:58 +0100, Pascal Schumacher wrote: imho we should drop support for java 6 and make every component java 7+ Why? Imho old java versions discourage contributions. Java 7 was released in 2011 8 (and Java 8 in 2014), so

Re: [Net] When should we update net from Java 6 to 7?

2018-01-12 Thread Pascal Schumacher
imho we should drop support for java 6 and make every component java 7+ Am 12.01.2018 um 18:54 schrieb Gary Gregory: Hi All: When should we update Commons Net from Java 6 to 7? Gary - To unsubscribe, e-mail:

Re: [lang] new IllegalArgumentException shorcut.

2018-01-12 Thread Pascal Schumacher
Hi Gary, we already have Validate#isTrue(boolean expression, String message, Object... values), which throws an IllegalArgumentException when the expression is false. Cheers, Pascal Am 12.01.2018 um 18:30 schrieb Gary Gregory: Hi All: We have code like: throw new

[lang] - Pull Requests containing new StringUtils methods

2018-01-12 Thread Pascal Schumacher
Hello everybody, currently there are three open pull requests containing new StringUtils methods: 1. astIndexOfAnyChar https://github.com/apache/commons-lang/pull/273 2. extendIfNotBlank/extendIfNotEmpty https://github.com/apache/commons-lang/pull/278

  1   2   3   4   >