Re: [Graph] Weighted as an interface

2011-12-06 Thread Claudio Squarcella
Hi, Moreover, I start having the feeling the {{WeightedGraph}} is a useless interface: it is enough marking the vertices/edges as weighted depending on the problem... or not? At the end of the day, {{WeightedGraph}} does nothing than having the the edges marked as weighted, so Dijkstra

Re: [Graph] Weighted as an interface

2011-12-06 Thread Simone Tripodi
Hola Claudio! for all algorithms implemented in the `shortestpath` package (A*, Dijkstra, Bellmann-Ford, ...), I didn't have the need to add new specific methods for {{WeightedGraph}}es since that interface was used more as a marker - a direct graph, which edges are weighted (granted by

Re: [Graph] Weighted as an interface

2011-12-05 Thread Simone Tripodi
Hi Claudio, what a pleasant surprise! :) I was hoping commons-graph would have caught the interest of researchers on that field, I'm really happy you would like to contribute! I agree with your observations, please fill new issues on JIRA[1] and feel free to provide patches, I'll process them

Re: [Graph] Weighted as an interface

2011-12-05 Thread Claudio Squarcella
Hi, thanks to both for your words! Please find comments below. On 05/12/2011 10:01, Simone Tripodi wrote: Hi Claudio, what a pleasant surprise! :) I was hoping commons-graph would have caught the interest of researchers on that field, I'm really happy you would like to contribute! I agree

Re: [Graph] Weighted as an interface

2011-12-05 Thread Simone Tripodi
Hi Claudio, so nice to see you are already deep in the spirit of the project! :) As for my suggestion on types, should I go for {{WeightedN extends Number}}? Note that I am also concerned about domain-specific requirements (e.g. all weights must be positive) that I would like to see

[Graph] Weighted as an interface

2011-12-04 Thread Claudio Squarcella
Hello, I have been reading the source in the past days and I found that the concept of weight (e.g. weighted edge, graph, etc) could benefit from a bit of abstraction. The basic idea would be to have an interface called Weighted with an obvious method getWeight(). Changes in the code would

Re: [Graph] Weighted as an interface

2011-12-04 Thread James Carman
Welcome! Contributions (and the contributor) are always welcome. In my past life, I did quite a bit of graph programming to solve business problems. We used yfiles, though. I hope to get around to playing with [graph] someday too. Please do submit a patch! On Dec 4, 2011 6:43 PM, Claudio