Re: [RNG, ALL] Checkstyle version

2019-02-12 Thread Alex Herbert
commons-parent has an empty profile jdk7-plugin-fix-version that activates for Java 7. I created a similar profile in the parent for commons-rng that activates for Java 8 and moved the checkstyle configuration into there. It now works with the latest checkstyle version. So the target remains

Re: [RNG, ALL] Checkstyle version

2019-02-12 Thread Pascal Schumacher
Am 11.02.2019 um 22:15 schrieb sebb: Aren't there different profiles for different Java versions? There was at least one plugin which needed different versions, so maybe take the same approach here. It's a bit more work to set up the pom, but it saves a lot of work downstream fixing component

Re: [RNG, ALL] Checkstyle version

2019-02-12 Thread Gilles Sadowski
Hi. Le mar. 12 févr. 2019 à 11:22, Alex Herbert a écrit : > > If checkstyle 7+ requires Java 8 then this is a blocker for common-rng. > That still supports Java 1.6. This is the target (so that it can *run* on older JRE). But the build/validation tools can well have different requirements. > I

Re: [RNG, ALL] Checkstyle version

2019-02-12 Thread Gary Gregory
On Tue, Feb 12, 2019 at 5:22 AM Alex Herbert wrote: > If checkstyle 7+ requires Java 8 then this is a blocker for common-rng. > That still supports Java 1.6. > Java 6? Let's bump that to Java 7 if not 8. Gary > > I did not intend to update commons-parent, only the project. The topic > of the

Re: [RNG, ALL] Checkstyle version

2019-02-12 Thread Alex Herbert
If checkstyle 7+ requires Java 8 then this is a blocker for common-rng. That still supports Java 1.6. I did not intend to update commons-parent, only the project. The topic of the parent was introduced just to state that there was no management of checkstyle. The consensus appears to be that

Re: [RNG, ALL] Checkstyle version

2019-02-11 Thread sebb
On Mon, 11 Feb 2019 at 18:10, Pascal Schumacher wrote: > > Am 11.02.2019 um 12:19 schrieb Alex Herbert: > > I would like to upgrade the checkstyle version in commons-rng. > > Currently the project uses maven-checkstyle-plugin 3.0.0 which > > defaults to checkstyle 6.18. > > > > This version is

Re: [RNG, ALL] Checkstyle version

2019-02-11 Thread Pascal Schumacher
Am 11.02.2019 um 12:19 schrieb Alex Herbert: I would like to upgrade the checkstyle version in commons-rng. Currently the project uses maven-checkstyle-plugin 3.0.0 which defaults to checkstyle 6.18. This version is old [1] and not supported by modern IDEs. An update (to version 8.x) would

Re: [RNG, ALL] Checkstyle version

2019-02-11 Thread Gary Gregory
Depending on how old the version of Checktyle you are currently using is, you may have to update the contents of your checkstyle xml file to work with the current version. Gary On Mon, Feb 11, 2019 at 7:48 AM Gilles Sadowski wrote: > Le lun. 11 févr. 2019 à 12:19, Alex Herbert a > écrit : > >

Re: [RNG, ALL] Checkstyle version

2019-02-11 Thread Gilles Sadowski
Le lun. 11 févr. 2019 à 12:19, Alex Herbert a écrit : > > I would like to upgrade the checkstyle version in commons-rng. Currently > the project uses maven-checkstyle-plugin 3.0.0 which defaults to > checkstyle 6.18. > > This version is old [1] and not supported by modern IDEs. An update (to >

[RNG, ALL] Checkstyle version

2019-02-11 Thread Alex Herbert
I would like to upgrade the checkstyle version in commons-rng. Currently the project uses maven-checkstyle-plugin 3.0.0 which defaults to checkstyle 6.18. This version is old [1] and not supported by modern IDEs. An update (to version 8.x) would allow checkstyle to be run within the IDE and