Re: [VOTE] Release Apache Commons CSV 1.8 based on RC1

I'll should be able to create RC2 at the weekend or sooner. Gary On Tue, Jan 28, 2020 at 10:28 AM Alex Herbert wrote: > > On 28/01/2020 15:15, Gary Gregory wrote: > > On Mon, Jan 27, 2020 at 7:58 PM Gary Gregory > wrote: > > > >> On Mon, Jan 27, 2020 at 6:54 PM Alex Herbert > >> wrote: > >>

Re: [VOTE] Release Apache Commons CSV 1.8 based on RC1

On 28/01/2020 15:15, Gary Gregory wrote: On Mon, Jan 27, 2020 at 7:58 PM Gary Gregory wrote: On Mon, Jan 27, 2020 at 6:54 PM Alex Herbert wrote: I’ve had a look at the Serialization of CSVRecord. Fields have been added and removed from CSVRecord as: 1.0 /** The accumulated comments (if

Re: [VOTE] Release Apache Commons CSV 1.8 based on RC1

On Mon, Jan 27, 2020 at 7:58 PM Gary Gregory wrote: > On Mon, Jan 27, 2020 at 6:54 PM Alex Herbert > wrote: > >> I’ve had a look at the Serialization of CSVRecord. Fields have been added >> and removed from CSVRecord as: >> >> 1.0 >> >> /** The accumulated comments (if any) */ >> private final

Re: [VOTE] Release Apache Commons CSV 1.8 based on RC1

On Mon, Jan 27, 2020 at 6:54 PM Alex Herbert wrote: > I’ve had a look at the Serialization of CSVRecord. Fields have been added > and removed from CSVRecord as: > > 1.0 > > /** The accumulated comments (if any) */ > private final String comment; > > /** The column name to index mapping. */ >

Re: [VOTE] Release Apache Commons CSV 1.8 based on RC1

I’ve had a look at the Serialization of CSVRecord. Fields have been added and removed from CSVRecord as: 1.0 /** The accumulated comments (if any) */ private final String comment; /** The column name to index mapping. */ private final Map mapping; /** The record number. */ private final long

Re: [VOTE] Release Apache Commons CSV 1.8 based on RC1

> On 25 Jan 2020, at 22:05, Gary Gregory wrote: > > Hi Alex, > > Is there more you'd like to do for 1.8? > Not functionality. The remaining things are the documentation of: - the intent to remove Serialisation support to the CSVRecord in 2.0 - the intent to not support Serialisation of

Re: [VOTE] Release Apache Commons CSV 1.8 based on RC1

Hi Alex, Is there more you'd like to do for 1.8? Gary On Fri, Jan 24, 2020 at 12:36 PM Gary Gregory wrote: > On Fri, Jan 24, 2020 at 11:09 AM sebb wrote: > >> On Fri, 24 Jan 2020 at 15:05, Alex Herbert >> wrote: >> > >> > >> > On 24/01/2020 13:34, Gary Gregory wrote: >> > > On Fri, Jan 24,

Re: [VOTE] Release Apache Commons CSV 1.8 based on RC1

On Fri, Jan 24, 2020 at 11:09 AM sebb wrote: > On Fri, 24 Jan 2020 at 15:05, Alex Herbert > wrote: > > > > > > On 24/01/2020 13:34, Gary Gregory wrote: > > > On Fri, Jan 24, 2020 at 6:14 AM sebb wrote: > > > > > >> On Thu, 23 Jan 2020 at 18:10, Alex Herbert > > >> wrote: > > >>> > > >>> On

Re: [VOTE] Release Apache Commons CSV 1.8 based on RC1

On Fri, 24 Jan 2020 at 15:05, Alex Herbert wrote: > > > On 24/01/2020 13:34, Gary Gregory wrote: > > On Fri, Jan 24, 2020 at 6:14 AM sebb wrote: > > > >> On Thu, 23 Jan 2020 at 18:10, Alex Herbert > >> wrote: > >>> > >>> On 23/01/2020 13:55, sebb wrote: > I think we don't want temporary

Re: [VOTE] Release Apache Commons CSV 1.8 based on RC1

On 24/01/2020 13:34, Gary Gregory wrote: On Fri, Jan 24, 2020 at 6:14 AM sebb wrote: On Thu, 23 Jan 2020 at 18:10, Alex Herbert wrote: On 23/01/2020 13:55, sebb wrote: I think we don't want temporary serialisation fixes to encourage the use of serialisation. So I suggest that the

Re: [VOTE] Release Apache Commons CSV 1.8 based on RC1

On Fri, Jan 24, 2020 at 6:14 AM sebb wrote: > On Thu, 23 Jan 2020 at 18:10, Alex Herbert > wrote: > > > > > > On 23/01/2020 13:55, sebb wrote: > > > I think we don't want temporary serialisation fixes to encourage the > > > use of serialisation. > > > > > > So I suggest that the Release Notes

Re: [VOTE] Release Apache Commons CSV 1.8 based on RC1

On Thu, 23 Jan 2020 at 18:10, Alex Herbert wrote: > > > On 23/01/2020 13:55, sebb wrote: > > I think we don't want temporary serialisation fixes to encourage the > > use of serialisation. > > > > So I suggest that the Release Notes and Javadoc should point out that > > although serialisation is

[CSV] discuss 1.8 vote (was: Re: [VOTE] Release Apache Commons CSV 1.8 based on RC1)

> On Jan 23, 2020, at 8:55 AM, sebb wrote: > > I think we don't want temporary serialisation fixes to encourage the > use of serialisation. > > So I suggest that the Release Notes and Javadoc should point out that > although serialisation is possible, it is not fully supported, and > that

Re: [VOTE] Release Apache Commons CSV 1.8 based on RC1

On 23/01/2020 13:55, sebb wrote: I think we don't want temporary serialisation fixes to encourage the use of serialisation. So I suggest that the Release Notes and Javadoc should point out that although serialisation is possible, it is not fully supported, and that there are plans to drop all

Re: [VOTE] Release Apache Commons CSV 1.8 based on RC1

I think we don't want temporary serialisation fixes to encourage the use of serialisation. So I suggest that the Release Notes and Javadoc should point out that although serialisation is possible, it is not fully supported, and that there are plans to drop all serialisation support. On Tue, 21

Re: [VOTE] Release Apache Commons CSV 1.8 based on RC1

On 20/01/2020 23:28, Gary Gregory wrote: On Sun, Jan 19, 2020 at 7:39 AM Alex Herbert wrote: Hi Gary, I raised a few niggles a while back with CSV and the discussion did not receive a response on how to proceed. There is the major bug CSV-248 where the CSVRecord is not Serializable [1].

Re: [VOTE] Release Apache Commons CSV 1.8 based on RC1

> On 21 Jan 2020, at 00:00, Gary Gregory wrote: > > On Mon, Jan 20, 2020 at 6:43 PM Rob Tompkins > wrote: > >> >> >>> On Jan 20, 2020, at 6:41 PM, Gary Gregory >> wrote: >>> >>> On Mon, Jan 20, 2020 at 6:28 PM Gary Gregory >> wrote: >>> > On Sun, Jan 19,

Re: [VOTE] Release Apache Commons CSV 1.8 based on RC1

On Mon, Jan 20, 2020 at 6:43 PM Rob Tompkins wrote: > > > > On Jan 20, 2020, at 6:41 PM, Gary Gregory > wrote: > > > > On Mon, Jan 20, 2020 at 6:28 PM Gary Gregory > wrote: > > > >>> On Sun, Jan 19, 2020 at 7:39 AM Alex Herbert > > >>> wrote: > >>> > >>> Hi Gary, > >>> > >>> I raised a few

Re: [VOTE] Release Apache Commons CSV 1.8 based on RC1

> On 20 Jan 2020, at 23:28, Gary Gregory wrote: > > On Sun, Jan 19, 2020 at 7:39 AM Alex Herbert > > wrote: > >> Hi Gary, >> >> I raised a few niggles a while back with CSV and the discussion did not >> receive a response on how to proceed. >> >> There is

Re: [VOTE] Release Apache Commons CSV 1.8 based on RC1

On Sun, Jan 19, 2020 at 7:39 AM Alex Herbert wrote: > Hi Gary, > > I raised a few niggles a while back with CSV and the discussion did not > receive a response on how to proceed. > > There is the major bug CSV-248 where the CSVRecord is not Serializable > [1]. This requires a decision on what to

Re: [VOTE] Release Apache Commons CSV 1.8 based on RC1

> On Jan 20, 2020, at 6:41 PM, Gary Gregory wrote: > > On Mon, Jan 20, 2020 at 6:28 PM Gary Gregory wrote: > >>> On Sun, Jan 19, 2020 at 7:39 AM Alex Herbert >>> wrote: >>> >>> Hi Gary, >>> >>> I raised a few niggles a while back with CSV and the discussion did not >>> receive a

Re: [VOTE] Release Apache Commons CSV 1.8 based on RC1

On Mon, Jan 20, 2020 at 6:28 PM Gary Gregory wrote: > On Sun, Jan 19, 2020 at 7:39 AM Alex Herbert > wrote: > >> Hi Gary, >> >> I raised a few niggles a while back with CSV and the discussion did not >> receive a response on how to proceed. >> >> There is the major bug CSV-248 where the

Re: [VOTE] Release Apache Commons CSV 1.8 based on RC1

On Sun, Jan 19, 2020 at 7:39 AM Alex Herbert wrote: > Hi Gary, > > I raised a few niggles a while back with CSV and the discussion did not > receive a response on how to proceed. > > There is the major bug CSV-248 where the CSVRecord is not Serializable > [1]. This requires a decision on what to

Re: [VOTE] Release Apache Commons CSV 1.8 based on RC1

On Sun, Jan 19, 2020 at 7:55 PM sebb wrote: > What is the use case for needing serialisation? > It's a lot of effort to maintain a serialisable class, and it opens > the class to deserialisation attacks. > I think the larger context is whether we can effectively remove (or leave broken)

Re: [VOTE] Release Apache Commons CSV 1.8 based on RC1

> On 20 Jan 2020, at 00:54, sebb wrote: > > What is the use case for needing serialisation? > It's a lot of effort to maintain a serialisable class, and it opens > the class to deserialisation attacks. I don’t have a use case. But the class used to support serialization back to the code

Re: [VOTE] Release Apache Commons CSV 1.8 based on RC1

What is the use case for needing serialisation? It's a lot of effort to maintain a serialisable class, and it opens the class to deserialisation attacks. On Sun, 19 Jan 2020 at 12:39, Alex Herbert wrote: > > Hi Gary, > > I raised a few niggles a while back with CSV and the discussion did not >

Re: [VOTE] Release Apache Commons CSV 1.8 based on RC1

Hi Gary, I raised a few niggles a while back with CSV and the discussion did not receive a response on how to proceed. There is the major bug CSV-248 where the CSVRecord is not Serializable [1]. This requires a decision on what to do to fix it. This bug is still present in 1.8 RC1 as found by

[VOTE] Release Apache Commons CSV 1.8 based on RC1

We have fixed quite a few bugs and added some significant enhancements since Apache Commons CSV 1.7 was released, so I would like to release Apache Commons CSV 1.8. Apache Commons CSV 1.8 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC1 (svn