[VOTE] Release Apache Commons FileUpload 1.3.2 based on RC1

2016-05-23 Thread Benedikt Ritter
It has been a long time since the last release of Apache Commons FileUpload, so I'd like to release Apache Commons FileUpload 1.3.2 based on RC1. Apache Commons FileUpload 1.3.2 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/fileupload (rev 13750) Maven artifac

Re: [VOTE] Release Apache Commons FileUpload 1.3.2 based on RC1

2016-05-23 Thread Gary Gregory
+1 >From src zip: MD5, SHA1, ASC OK. Also src tar gz: MD5, SHA1, ASC OK. >From src zip: mvn clean site OK. All reports OK except Checkstyle: I assume the Checkstyle violations are not new compared to 1.3.1. I cannot tell because our site is for 1.4-SNAPSHOT https://commons.apache.org/proper/com

Re: [VOTE] Release Apache Commons FileUpload 1.3.2 based on RC1

2016-05-24 Thread Jochen Wiedmann
+1 Thanks for your work, Benedikt. On Mon, May 23, 2016 at 10:13 PM, Gary Gregory wrote: > +1 > > From src zip: MD5, SHA1, ASC OK. > Also src tar gz: MD5, SHA1, ASC OK. > > From src zip: mvn clean site OK. > > All reports OK except Checkstyle: > > I assume the Checkstyle violations are not new

Re: [VOTE] Release Apache Commons FileUpload 1.3.2 based on RC1

2016-05-24 Thread Oliver Heger
Build (maven) works fine with Java 1.5 and 1.8. Site looks good. The binary distribution is a bit different from other Commons releases: It only contains the jar in a lib subfolder (no source or javadoc jar), and the release notes are missing. But I don't think this is blocking. So +1 Oliver My

Re: [VOTE] Release Apache Commons FileUpload 1.3.2 based on RC1

2016-05-25 Thread Benedikt Ritter
My +1 for this release. Benedikt Ritter schrieb am Mo., 23. Mai 2016 um 17:23 Uhr: > It has been a long time since the last release of Apache Commons > FileUpload, so I'd like to release Apache Commons FileUpload 1.3.2 based on > RC1. > > Apache Commons FileUpload 1.3.2 RC1 is available for revi

Re: [VOTE] Release Apache Commons FileUpload 1.3.2 based on RC1

2016-05-25 Thread Stian Soiland-Reyes
My vote: +1 (binding) FYI - dist sha1 checksums according to svn r13750 6650d1c878b1142a0c8e3be3534ad24d6f422fc2 binaries/commons-fileupload-1.3.2-bin.tar.gz 0d1004f3aab4ecc62b2fb14056b9c92489d79121 binaries/commons-fileupload-1.3.2-bin.zip 6f254ad51f5e2c9d9a039995bc1a2295cabc95f6 source/commons-

Re: [VOTE] Release Apache Commons FileUpload 1.3.2 based on RC1

2016-05-25 Thread Bernd Eckenfels
+1 (binding) i do have some remarks/discussion points: RELEASE-NOTES.txt contains the site link as http instead of https, I had the impression we wanted to switch the defaults? Is the site planned to be "rolled back" to 1.3.2 or will it stay 1.4-SNAPSHOT? Gruss Bernd Am Mon, 23 May 2016 15:23

Re: [VOTE] Release Apache Commons FileUpload 1.3.2 based on RC1

2016-05-25 Thread Gary Gregory
On Wed, May 25, 2016 at 1:31 PM, Bernd Eckenfels wrote: > +1 (binding) > > i do have some remarks/discussion points: > > RELEASE-NOTES.txt contains the site link as http instead of https, I > had the impression we wanted to switch the defaults? > > Is the site planned to be "rolled back" to 1.3.2

Re: [VOTE] Release Apache Commons FileUpload 1.3.2 based on RC1

2016-05-26 Thread Jochen Wiedmann
On Wed, May 25, 2016 at 10:31 PM, Bernd Eckenfels wrote: > RELEASE-NOTES.txt contains the site link as http instead of https, I > had the impression we wanted to switch the defaults? Should be sufficient to keep that in mind for the future, as the http URL still works. It is something, we all go

Re: [VOTE] Release Apache Commons FileUpload 1.3.2 based on RC1

2016-05-26 Thread Benedikt Ritter
This vote passes with the following votes: - Gary Gregory: +1 - Jochen Wiedmann: +1 - Benedikt Ritter: +1 - Stian Soiland-Reyes: +1 - Bernd Eckenfels: +1 I'll continue with the release procedure. Thank you for reviewing! Benedikt Benedikt Ritter schrieb am Mo., 23. Mai 2016 um 17:23 Uhr: > It

Re: [VOTE] Release Apache Commons FileUpload 1.3.2 based on RC1

2016-05-26 Thread Oliver Heger
For the record, I voted +1, too. Oliver Am 26.05.2016 um 21:35 schrieb Benedikt Ritter: > This vote passes with the following votes: > > - Gary Gregory: +1 > - Jochen Wiedmann: +1 > - Benedikt Ritter: +1 > - Stian Soiland-Reyes: +1 > - Bernd Eckenfels: +1 > > I'll continue with the release proc

Re: [VOTE] Release Apache Commons FileUpload 1.3.2 based on RC1

2016-05-26 Thread Benedikt Ritter
Oliver Heger schrieb am Do., 26. Mai 2016 um 21:56 Uhr: > For the record, I voted +1, too. > Yes, sorry! Must have missed that when counting votes. > > Oliver > > Am 26.05.2016 um 21:35 schrieb Benedikt Ritter: > > This vote passes with the following votes: > > > > - Gary Gregory: +1 > > - Joc