On Mon, 16 Aug 2021 at 16:57, Alex Herbert wrote:
> SNIP
>
> Since geometry and numbers are using packages then the javadoc should be
> produced using JDK 8. The workaround would be to add the package-list files
> manually to the numbers site.
>
> These files are very simple. So it may be enoug
On Mon, 16 Aug 2021 at 15:18, Matt Juntunen
wrote:
> I'm cancelling this vote again to address some of the issues that Alex
> found, particularly the method naming convention issue.
>
> Alex,
> The behavior you described for the AbstractNode.depth() method is as
> designed. It is not sufficient f
I'm cancelling this vote again to address some of the issues that Alex
found, particularly the method naming convention issue.
Alex,
The behavior you described for the AbstractNode.depth() method is as
designed. It is not sufficient for a node to not have a parent in
order to be considered a root
Javadoc:
The Javadoc for classes that rely on public components from Commons-Numbers
do not link to the Common Numbers javadoc, e.g.
https://home.apache.org/~mattjuntunen/commons-geometry-1.0-RC3-site/commons-geometry-euclidean/apidocs/org/apache/commons/geometry/euclidean/threed/rotation/Quatern
Hello.
Le dim. 15 août 2021 à 03:54, Matt Juntunen
a écrit :
>
> We have completed initial development work on Apache Commons Geometry,
> so I would like to release Apache Commons Geometry (full distribution)
> 1.0.
>
> Apache Commons Geometry (full distribution) 1.0 RC3 is available for
> review
Hi Matt,
Another partial review here as I found a potential issue:
In core: core.partitioning.bsp.AbstractBSPTree
The inner class 'AbstractNode, N extends AbstractNode>' has a depth property and a depth() method so is flagged by PMD. No
real issue here but the depth() method does lazy loading of
We have completed initial development work on Apache Commons Geometry,
so I would like to release Apache Commons Geometry (full distribution)
1.0.
Apache Commons Geometry (full distribution) 1.0 RC3 is available for
review here:
https://dist.apache.org/repos/dist/dev/commons/geometry/1.0-RC3
(
