Re: [VOTE] Release Apache Commons IO 2.8.0 based on RC1

2020-09-06 Thread Xeno Amess
Got it, maybe I will put a pr for the issue I found. After all codes are more clear than words :) Gary Gregory 于2020年9月6日周日 下午9:44写道: > On Sun, Sep 6, 2020 at 9:36 AM Xeno Amess wrote: > > > > https://github.com/XenoAmess/smoke-test-commons-io/actions/runs/241547041 > > see this > > > > I can'

Re: [VOTE] Release Apache Commons IO 2.8.0 based on RC1

2020-09-06 Thread Gary Gregory
On Sun, Sep 6, 2020 at 9:36 AM Xeno Amess wrote: > https://github.com/XenoAmess/smoke-test-commons-io/actions/runs/241547041 see this > I can't immediately tell why your build is failing and I don't want to take the time today to debug your project. Gary > > Gary Gregory 于2020年9月6日周日 下午9:33

Re: [VOTE] Release Apache Commons IO 2.8.0 based on RC1

2020-09-06 Thread Xeno Amess
Oh I see why it will fail. It read the source codes in main folder when running test... However I did not clone the main folder, so it can read nothing. Well it is not illegal but, is it necessary...? I think it weird, and maybe it is better to change those tests to use test-resources to do such t

Re: [VOTE] Release Apache Commons IO 2.8.0 based on RC1

2020-09-06 Thread Xeno Amess
https://github.com/XenoAmess/smoke-test-commons-io/actions/runs/241547041 see this Gary Gregory 于2020年9月6日周日 下午9:33写道: > On Sun, Sep 6, 2020 at 5:39 AM Xeno Amess wrote: > > > Hi. > > Smoke test seems failed. > > https://github.com/XenoAmess/smoke-test-commons-io > > could some guy run this loc

Re: [VOTE] Release Apache Commons IO 2.8.0 based on RC1

2020-09-06 Thread Gary Gregory
On Sun, Sep 6, 2020 at 5:39 AM Xeno Amess wrote: > Hi. > Smoke test seems failed. > https://github.com/XenoAmess/smoke-test-commons-io > could some guy run this locally and see why it be wrong? > I'm not sure what you are asking, a brief glance at https://github.com/XenoAmess/smoke-test-commons-

Re: [VOTE] Release Apache Commons IO 2.8.0 based on RC1

2020-09-06 Thread Gary Gregory
The file src/assembly/src.xml still refers to the FindBugs config instead of the SpotBugs config. This means you can't build a zip or tar distro. I will cancel this VOTE respin for RC2. Thank you! Gary On Sun, Sep 6, 2020 at 2:16 AM Rob Tompkins wrote: > (undecided) -1 ?? > > [INFO] >

Re: [VOTE] Release Apache Commons IO 2.8.0 based on RC1

2020-09-06 Thread Xeno Amess
Hi. Smoke test seems failed. https://github.com/XenoAmess/smoke-test-commons-io could some guy run this locally and see why it be wrong? the plugin's source is at https://github.com/XenoAmess/add-from-repo-maven-plugin , if anything I wrote uncorrect, please tell me. Bruno P. Kinoshita 于2020年9月6

Re: [VOTE] Release Apache Commons IO 2.8.0 based on RC1

2020-09-06 Thread Bruno P. Kinoshita
  [x] +1 Release these artifacts Building from tag, with `mvn clean test install` working fine on: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-18T06:33:14+12:00) Maven home: /opt/apache-maven-3.5.4 Java version: 1.8.0_265, vendor: Private Build, runtime: /usr/lib/jvm/j

Re: [VOTE] Release Apache Commons IO 2.8.0 based on RC1

2020-09-05 Thread Rob Tompkins
(undecided) -1 ?? [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 04:00 min [INFO] Finished at: 2020-09-06T02:07:20-04:00 [INFO]

[VOTE] Release Apache Commons IO 2.8.0 based on RC1

2020-09-05 Thread Gary Gregory
We have fixed a few bugs and added some enhancements since Apache Commons IO 2.7 was released, so I would like to release Apache Commons IO 2.8.0. Apache Commons IO 2.8.0 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/io/2.8.0-RC1 (svn revision 41326) The Git