Re: [lang] Remove final modifier behaviour in java 12+ (was: Re: [VOTE] Release Apache Commons Lang 3.9 based on RC1)

That’s what I switched to. -Rob > On Apr 11, 2019, at 2:44 PM, Benedikt Ritter wrote: > > An alternative would be to use SystemUtils.isJavaVersionAtMost the have > behavior depending on the current Java versions. This would preserve the > behavior for users on Java < 12. > > Benedikt > > Am Mi

Re: [lang] Remove final modifier behaviour in java 12+ (was: Re: [VOTE] Release Apache Commons Lang 3.9 based on RC1)

An alternative would be to use SystemUtils.isJavaVersionAtMost the have behavior depending on the current Java versions. This would preserve the behavior for users on Java < 12. Benedikt Am Mi., 10. Apr. 2019 um 16:32 Uhr schrieb Rob Tompkins : > I like that. I’ll get that sorted out. > > -Rob >

Re: [VOTE] Release Apache Commons Lang 3.9 based on RC1

> On Apr 10, 2019, at 12:25 PM, Gary Gregory wrote: > > On Wed, Apr 10, 2019 at 12:13 PM Rob Tompkins > wrote: > >> >> >>> On Apr 9, 2019, at 9:16 PM, Gary Gregory >> > wrote: >>> >>> I also see that we are using an old version of j

Re: [VOTE] Release Apache Commons Lang 3.9 based on RC1

On Wed, Apr 10, 2019 at 12:13 PM Rob Tompkins wrote: > > > > On Apr 9, 2019, at 9:16 PM, Gary Gregory wrote: > > > > I also see that we are using an old version of jacoco and surefire, that > > probably matters… > > Maven surefire is 3.0.0-M3. Are we willing to consume a non-release > version of

Re: [VOTE] Release Apache Commons Lang 3.9 based on RC1

> On Apr 9, 2019, at 9:16 PM, Gary Gregory wrote: > > I also see that we are using an old version of jacoco and surefire, that > probably matters… Maven surefire is 3.0.0-M3. Are we willing to consume a non-release version of the plugin? I ask this because I regard "-Mx”, where x is a posit

Re: [lang] Remove final modifier behaviour in java 12+ (was: Re: [VOTE] Release Apache Commons Lang 3.9 based on RC1)

I like that. I’ll get that sorted out. -Rob > On Apr 10, 2019, at 10:28 AM, Gary Gregory wrote: > > I think UnsupportedOperationException with a Java 12 comment, but we should > also add @Deprecated with a comment about it not working at all on Java 12. > > Gary > > On Wed, Apr 10, 2019 at 8:

Re: [lang] Remove final modifier behaviour in java 12+ (was: Re: [VOTE] Release Apache Commons Lang 3.9 based on RC1)

I think UnsupportedOperationException with a Java 12 comment, but we should also add @Deprecated with a comment about it not working at all on Java 12. Gary On Wed, Apr 10, 2019 at 8:55 AM Rob Tompkins wrote: > Looks like we get an exception because the final modifier isn’t removable > in java

[CANCEL][VOTE] Release Apache Commons Lang 3.9 based on RC1

I’m going to cancel this [VOTE] so that we can button up those java 12 problems and upversion jacoco and surefire. -Rob > On Apr 9, 2019, at 3:37 PM, Rob Tompkins wrote: > > We have fixed quite a few bugs and added some significant enhancements since > Apache Commons Lang 3.8.1 was released,

[lang] Remove final modifier behaviour in java 12+ (was: Re: [VOTE] Release Apache Commons Lang 3.9 based on RC1)

Looks like we get an exception because the final modifier isn’t removable in java 12+ and for good reason [1]. So, we probably should throw an exception, but both of the exceptions that arise out of the jvm here https://github.com/apache/commons-lang/blob/master/src/main/java/org/apache/commons/

Re: [VOTE] Release Apache Commons Lang 3.9 based on RC1

Hi B, do you have time to review the [pool] vote? Gary On Wed, Apr 10, 2019, 05:09 Benedikt Ritter wrote: > Damn it, I had it on my list to fix those. Sorry, Rob! > > Am Mi., 10. Apr. 2019 um 03:33 Uhr schrieb Rob Tompkins < > chtom...@gmail.com > >: > > > > > > > > On Apr 9, 2019, at 9:15 PM,

Re: [VOTE] Release Apache Commons Lang 3.9 based on RC1

Damn it, I had it on my list to fix those. Sorry, Rob! Am Mi., 10. Apr. 2019 um 03:33 Uhr schrieb Rob Tompkins : > > > > On Apr 9, 2019, at 9:15 PM, Gary Gregory wrote: > > > > +0... see Java 12 testing below. > > That +0 is almost worth cancelling for in my opinion. I’ll wait until > tomorrow t

Re: [VOTE] Release Apache Commons Lang 3.9 based on RC1

> On Apr 9, 2019, at 9:15 PM, Gary Gregory wrote: > > +0... see Java 12 testing below. That +0 is almost worth cancelling for in my opinion. I’ll wait until tomorrow to see if anyone else wants to have an opinion here, and then I’ll have another go at it. -Rob > > Nit in the release note

Re: [VOTE] Release Apache Commons Lang 3.9 based on RC1

+0... see Java 12 testing below. Nit in the release notes: Replace "Java 8.0" with Java 8". >From the git tag, ran 'mvn -V clean package' OK for: Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T14:41:47-04:00) Maven home: C:\Java\apache-maven-3.6.0\bin\.. Java version: 1

Re: [VOTE] Release Apache Commons Lang 3.9 based on RC1

I also see that we are using an old version of jacoco and surefire, that probably matters... Gary On Tue, Apr 9, 2019 at 9:15 PM Gary Gregory wrote: > +0... see Java 12 testing below. > > Nit in the release notes: Replace "Java 8.0" with Java 8". > > From the git tag, ran 'mvn -V clean package'

[VOTE] Release Apache Commons Lang 3.9 based on RC1

We have fixed quite a few bugs and added some significant enhancements since Apache Commons Lang 3.8.1 was released, so I would like to release Apache Commons Lang 3.9. Apache Commons Lang 3.9 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/lang/3.9-RC1 (svn